From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3137AC2D0A3 for ; Sun, 1 Nov 2020 18:01:34 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id A52E621534 for ; Sun, 1 Nov 2020 18:01:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JsfD1kBy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A52E621534 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 09DE62BDB; Sun, 1 Nov 2020 19:01:32 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 8FF132BD5 for ; Sun, 1 Nov 2020 19:01:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604253688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CWIzMnnjbjYU04jI/uWQqLBerEiq2jQ2ZrUGPFA02Js=; b=JsfD1kByr4DM058MGmMTPy5OXBvSueodg/QBrbXYdQ0lfymvBVPav5jalrH0WqxObby6I2 0xJ9KUUu2gX7ITvsluFeii0bDiFbfo5rn/VlhnW2bYG0pZKGjI6PqVu2Cx/Vl78An6K2w9 +fueki8cYppskvgDoyTmmoYDHkSf6fQ= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-484-kNlj0mJ2MpiJ_k57UmhpHw-1; Sun, 01 Nov 2020 13:01:27 -0500 X-MC-Unique: kNlj0mJ2MpiJ_k57UmhpHw-1 Received: by mail-vs1-f71.google.com with SMTP id t17so193578vsl.18 for ; Sun, 01 Nov 2020 10:01:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=CWIzMnnjbjYU04jI/uWQqLBerEiq2jQ2ZrUGPFA02Js=; b=Ucck+i3r211eKD7yaLSykPNsqnSEWBXeWHbiVD4GjOYIGyBbK0NL+uIoJHdy6yQq14 ZzSaX7GldUG8o6ET4nGVnGzAF8wtiu2qkGuT9FPVavCKHasIeqNL3XNeLw7zFDuN9wq/ rS/hf87LWh9GjVOSWTZP5gUMRfwF4438OR0fH+oBx42JCF4S1Q67ppmylBy8xKmak8mn OIFy3o0h6TTba6eS2JeGi2TRWpweDCV49YVKCmliP2d5R2NvPURoXN48DT8/G20/VT+o 6fpdBPon95oUJwWvpyq9yxLbeNvQuaZzhAmHincbkpu2L6wrRAkdA2958bPhbYG/Zi3O K/Qw== X-Gm-Message-State: AOAM531CLWnTdJ7QPPSYcV4r6YDeuf5MOmWkh5WAfe+0cIycf90bNALC OnweVLpmn2At5kNMAv79ZgpulWsLt3xvu0DIDf20HIUpthAYcqvoziIROEaubFTTwaPYy/moSkJ 3Q5IDGVPBixtNmRr5RaY= X-Received: by 2002:ab0:7313:: with SMTP id v19mr5653214uao.87.1604253686779; Sun, 01 Nov 2020 10:01:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJwDjD3KkQB2DLOvW4C6HqdL4xVhP3wKFoLYAj6CAWCt/F9NWB/TRCU7CK3GJ9lwm4hlyJU09QzZX/g3nizlAns= X-Received: by 2002:ab0:7313:: with SMTP id v19mr5653199uao.87.1604253686317; Sun, 01 Nov 2020 10:01:26 -0800 (PST) MIME-Version: 1.0 References: <20200612212434.6852-2-timothy.mcdaniel@intel.com> <1604168282-30079-1-git-send-email-timothy.mcdaniel@intel.com> <1604168282-30079-6-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: From: David Marchand Date: Sun, 1 Nov 2020 19:01:15 +0100 Message-ID: To: "McDaniel, Timothy" Cc: dev , "Carrillo, Erik G" , "Eads, Gage" , "Van Haaren, Harry" , Jerin Jacob Kollanukkaran , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v14 05/23] event/dlb: add inline functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > + > > > +static inline void > > > +dlb_movdir64b(void *dest, void *src) > > > +{ > > > + asm volatile(".byte 0x66, 0x0f, 0x38, 0xf8, 0x02" > > > + : > > > + : "a" (dest), "d" (src)); > > > +} > > > > NO! > > We introduced stuff in EAL for this, please double check. > I also do not see a replacement for the new MOVDIR64B instruction in dpdk= -next-eventdev or dpdk main. Ok, what got introduced in EAL is for MOVDIRI. So here we go with a MOVDIR64B... Google tells me: Availability of the MOVDIR64B instruction is indicated by the presence of the CPUID feature flag MOVDIR64B (bit 28 of the ECX register in leaf 07H, see =E2=80=9CCPUID=E2=80=94CPU Identification=E2=80=9D in the Int= el=C2=AE 64 and IA-32 Architectures Software Developer=E2=80=99s Manual, Volume 2A). I understand that calling this code must be under a check for RTE_CPUFLAG_MOVDIR64B. Which I can't find in this patchset. What did I miss this time? --=20 David Marchand