From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95FFCC433EF for ; Fri, 29 Apr 2022 07:27:23 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DA67415D7; Fri, 29 Apr 2022 09:27:22 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 72F9940E50 for ; Fri, 29 Apr 2022 09:27:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651217239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qAW7g10rD5cSwHwuDSdIN7jqLnCjPn0LzAQLTIM77Zs=; b=Nxdk+H7q4DnJDE1/WMfTL65Q5AUVPpwHMyaGadUqL7kasqP628F34eQC8rk8OdDyiko9W3 hwCl8ZJoFSAS+m85IJNQpztLBDghrjwBkJ+7Aj9VZagmP0YY0ec5b6SLxW4FCe5ILIj0Sm sbxEkQKfhydbiJQqlkl/JtYmehxl29Q= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-284-f73flPI7ND6q6RgxAYHRrg-1; Fri, 29 Apr 2022 03:27:18 -0400 X-MC-Unique: f73flPI7ND6q6RgxAYHRrg-1 Received: by mail-lj1-f197.google.com with SMTP id d5-20020a05651c088500b0024db8b6a445so2432236ljq.11 for ; Fri, 29 Apr 2022 00:27:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qAW7g10rD5cSwHwuDSdIN7jqLnCjPn0LzAQLTIM77Zs=; b=rHFTtPCjxPJJS2tjpQ+ER2QVLO5UcVrrnRI9Qd13zPOtCf7pJmj6xzT/sLN5U7BhNq F9hJ2mg4FDA7qwNXD8+XDob6k25ExxU7GmXo7dwvnn8f2hMNBKqZ9vdOI7fip8T3rdDj f+/OK+ogMsU+cZ61VG1XPi1rOvS64F1nrQsc4eAg1OfYHHYnxdzwtwP1E/OBxqeP/b+N Nh2vfFKCMM5gnxpKoeThgn+Ci9nGm9T8ka/grMaVeL8vxSKRgPZey0TXqF26oZIt74Su 3Gn4/2YSAoalFZSzbFm4g92u1USiPJIvtIjJ6QFBtYn2O/9Lsqkr79tmXKeAHm1an60R CcMQ== X-Gm-Message-State: AOAM532gw2JGlxq67QMasCCZX4R9oRO13U5ksrPleqxemCprGErqsbBO fEgsTCtWsSQ+QKSe5W3Z0HY2DtFItiE8ZVG0BMVXFqzvXVRo7qxdbcZMtBgES3osvTTTKi1x7pG X0dXqux9DY47e3xpqkqs= X-Received: by 2002:a05:6512:250d:b0:472:816:f613 with SMTP id be13-20020a056512250d00b004720816f613mr16654188lfb.265.1651217236984; Fri, 29 Apr 2022 00:27:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxxWbTIZcmIHwXlrtE4tDMx8tB8CBg5cxILkSarAlU0kzZqK7XAPKedHn6h8KCVheE67TPzsYGv4m3SyAEzbQw= X-Received: by 2002:a05:6512:250d:b0:472:816:f613 with SMTP id be13-20020a056512250d00b004720816f613mr16654173lfb.265.1651217236717; Fri, 29 Apr 2022 00:27:16 -0700 (PDT) MIME-Version: 1.0 References: <20220425092523.52338-1-lihuisong@huawei.com> <20220425092523.52338-2-lihuisong@huawei.com> In-Reply-To: <20220425092523.52338-2-lihuisong@huawei.com> From: David Marchand Date: Fri, 29 Apr 2022 09:27:05 +0200 Message-ID: Subject: Re: [PATCH V1 1/2] app/testpmd: fix supported RSS offload display To: Huisong Li Cc: dev , Thomas Monjalon , ferruh.yigit@xilinx.com, Andrew Rybchenko , huangdaode@huawei.com Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Apr 25, 2022 at 11:26 AM Huisong Li wrote: > @@ -773,20 +787,8 @@ port_infos_display(portid_t port_id) > if (!dev_info.flow_type_rss_offloads) > printf("No RSS offload flow type is supported.\n"); > else { > - uint16_t i; > - char *p; > - > - printf("Supported RSS offload flow types:\n"); > - for (i =3D RTE_ETH_FLOW_UNKNOWN + 1; > - i < sizeof(dev_info.flow_type_rss_offloads) * CHAR_B= IT; i++) { > - if (!(dev_info.flow_type_rss_offloads & (1ULL << = i))) > - continue; > - p =3D flowtype_to_str(i); This patch removes the only call to flowtype_to_str not under #if defined(RTE_NET_I40E) || defined(RTE_NET_IXGBE). As reported by the CI, it breaks compilation when disabling net/i40e and net/ixgbe drivers because it results in a static unused symbol left behind. FAILED: app/a172ced@@dpdk-testpmd@exe/test-pmd_config.c.o ccache gcc -Iapp/a172ced@@dpdk-testpmd@exe -Iapp -I../app -Ilib/ethdev -I../lib/ethdev -I. -I../ -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -I../lib/telemetry/../metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Ilib/cmdline -I../lib/cmdline -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Ilib/bpf -I../lib/bpf -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Wextra -Werror -O2 -g -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-missing-field-initializers -D_GNU_SOURCE -march=3Dcorei7 -DALLOW_EXPERIMENTAL_API -Wno-deprecated-declarations -MD -MQ 'app/a172ced@@dpdk-testpmd@exe/test-pmd_config.c.o' -MF 'app/a172ced@@dpdk-testpmd@exe/test-pmd_config.c.o.d' -o 'app/a172ced@@dpdk-testpmd@exe/test-pmd_config.c.o' -c ../app/test-pmd/config.c ../app/test-pmd/config.c:5506:1: error: =E2=80=98flowtype_to_str=E2=80=99 d= efined but not used [-Werror=3Dunused-function] flowtype_to_str(uint16_t flow_type) ^~~~~~~~~~~~~~~ cc1: all warnings being treated as errors Please fix by removing the unnecessary fwd declaration of this symbol, then moving flowtype_to_str function under the #if defined(RTE_NET_I40E) || defined(RTE_NET_IXGBE) check. I marked this patch as changes requested, thanks. --=20 David Marchand