Re: [dpdk-dev] [PATCH v3 2/2] eal: handle compressed firmwares

From: David Marchand <david.marchand@redhat.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Igor Russkikh <irusskikh@marvell.com>,
	 Aaron Conole <aconole@redhat.com>,
	Michael Santana <maicolgabriel@hotmail.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	Rasesh Mody <rmody@marvell.com>,
	 Shahed Shaikh <shshaikh@marvell.com>,
	"Yang, Qiming" <qiming.yang@intel.com>,
	 "Zhang, Qi Z" <qi.z.zhang@intel.com>,
	Heinrich Kuhn <heinrich.kuhn@netronome.com>,
	 Devendra Singh Rawat <dsinghrawat@marvell.com>,
	Ray Kinsella <mdr@ashroe.eu>,
	 Neil Horman <nhorman@tuxdriver.com>,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	Dmitry Malloy <dmitrym@microsoft.com>,
	 "Kadam, Pallavi" <pallavi.kadam@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 2/2] eal: handle compressed firmwares
Date: Mon, 5 Jul 2021 08:54:10 +0200	[thread overview]
Message-ID: <CAJFAV8wznKKERCGqW0YmD-8=UtGXX6P=MU55Q68uVXR6FLmZgQ@mail.gmail.com> (raw)
In-Reply-To: <BN8PR11MB37952610A42E0C2C7ABA7073F71C9@BN8PR11MB3795.namprd11.prod.outlook.com>

On Mon, Jul 5, 2021 at 8:35 AM Wang, Haiyue <haiyue.wang@intel.com> wrote:
> > +int
> > +rte_firmware_read(const char *name, void **buf, size_t *bufsz)
> > +{
> > +     char path[PATH_MAX];
> > +     int ret;
> > +
> > +     ret = firmware_read(name, buf, bufsz);
> > +     if (ret < 0) {
> > +             snprintf(path, sizeof(path), "%s.xz", name);
> > +             path[PATH_MAX - 1] = '\0';
> > +#ifndef RTE_HAS_LIBARCHIVE
> > +             if (access(path, F_OK) == 0) {
> > +                     RTE_LOG(WARNING, EAL, "libarchive not available, %s cannot be decompressed\n",
> > +                             path);
> > +             }
> > +#else
> > +             ret = firmware_read(path, buf, bufsz);
> > +#endif
> > +     }
> > +     return ret;
> > +}
>
>
> Since ice PMD needs to check if the firmware file with different name can be accessed
> by some kind of order, before doing the final firmware selection. Should we also add
> the firmware access API for handling this ?

I don't see the need.
Is the behavior changed for net/ice with this patch?

-- 
David Marchand