From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3E46C433E0 for ; Fri, 10 Jul 2020 14:05:57 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 77B1420748 for ; Fri, 10 Jul 2020 14:05:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JsDe6ZKZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77B1420748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5DFDA1DE39; Fri, 10 Jul 2020 16:05:56 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id D924B1DDED for ; Fri, 10 Jul 2020 16:05:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594389954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pOtLnDIEWguV3FMSFevzFe9aWZ5fq1Q5MltB/mgqdoU=; b=JsDe6ZKZ497uAGEFg7po0V6D2g2G2qPhWoJQYUzJ4p1SMpogCe0f/g/hcRyhvJUfrx9Wca isS+ZCXQEBSKcCjLFJlcVhBa9AU7HPCH+cfsarCIM+NntfZdi+AdeREijXFqYP4UdAspYk orvRY8jf6NsCxsQPnk8RTYy66+/8MU4= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-157-kkZtlW2ONmWeXmK1jUhpGw-1; Fri, 10 Jul 2020 10:05:52 -0400 X-MC-Unique: kkZtlW2ONmWeXmK1jUhpGw-1 Received: by mail-vk1-f199.google.com with SMTP id v68so1186680vkf.13 for ; Fri, 10 Jul 2020 07:05:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pOtLnDIEWguV3FMSFevzFe9aWZ5fq1Q5MltB/mgqdoU=; b=Kp9b/+xNA9H8zoSb6ZflA8NgX3mhCLTtbAaTzvl5FfegW/UC0+eikPFLvROG6hV4or dVIueAu45tiZ4far6vbG5XP12XFkkTpjertO96FWxuJKtDhtGX4QbCM60e7HhRqilwAx CCjWfjOrjEQRk/mVVftmLlNwRlop5LQOzfuUX8oROsHHnaPE7TLmfMVEXSjUGiC77mAd RPV9ynHKvhSRiNCIf3uU1/GOAZ4Yq3GrRf1MAbiK3yV29eEFkWKN+XqKNjGPgptpySb/ QF0TWYlCMyMc8GfD2LDqSq0C9Jp6/Ustt88Sf161nR5H8+SEVtslKbH1iZXojBhVvtXD rZsA== X-Gm-Message-State: AOAM530BI1WPmMHioZlqKQ3mqgdgWhkBVNX4wBkwF0KQKdOmFHvkQSIs OrGRv4abYItXGa3gd504ysC8YzYcsYM0cm1f9Aykkq6KntQAKpNOrusKDTRnAOTWJILPWkAaG/U GStdU0MRwHBhTBiYHDBQ= X-Received: by 2002:ab0:5a72:: with SMTP id m47mr13159686uad.86.1594389952321; Fri, 10 Jul 2020 07:05:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzSIbQlwVuQA7OwPzBIrRlR6MHwOEkQ4DoW3BJLEHeGaDyV/6USQfgca3/CKwTpJ8sCwM8tDtlpVT6XIvK7OzY= X-Received: by 2002:ab0:5a72:: with SMTP id m47mr13159651uad.86.1594389952046; Fri, 10 Jul 2020 07:05:52 -0700 (PDT) MIME-Version: 1.0 References: <20200611033248.39049-1-joyce.kong@arm.com> <20200710023850.43898-1-joyce.kong@arm.com> In-Reply-To: <20200710023850.43898-1-joyce.kong@arm.com> From: David Marchand Date: Fri, 10 Jul 2020 16:05:41 +0200 Message-ID: To: Joyce Kong Cc: Maxime Coquelin , Jerin Jacob Kollanukkaran , Zhihong Wang , Adrian Moreno Zapata , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Xiaolong Ye , Beilei Xing , Jeff Guo , "Mcnamara, John" , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Honnappa Nagarahalli , Phil Yang , "Ruifeng Wang (Arm Technology China)" , dev , nd X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 0/3] restrict pointer aliasing with a common wrapper X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jul 10, 2020 at 4:42 AM Joyce Kong wrote: > > As the 'restrict' keyword is recognized in C99, this patchset is to > add a wrapper defining '__rte_restrict' which can be supported by > all compilers. Then replace the existing 'restrict' and '__restrict' > in different vpmds, and optimize vhost/virtio with restricted pointer > aliasing for more aggressive loops vectorization. > > The vhost/virtio optimization patches were benchmarked by running PVP > case on ThunderX2 platform and showed positive performance results. > > v3: > 1.Correct the compiling issue on GCC 4.8.5. > 2.Squash the replacement patches and wrapper definition into one > patch.(suggested by David Marchand) > > v2: > Add a common wrapper for restricted pointer aliasing to be supported > by all compilers.(suggested by Maxime Coquelin) > > Joyce Kong (3): > lib/eal: add a common wrapper for restricted pointers > net/virtio: restrict pointer aliasing for NEON vpmd > lib/vhost: restrict pointer aliasing for packed vpmd > > drivers/net/i40e/i40e_rxtx_vec_neon.c | 17 +- > drivers/net/mlx5/mlx5_rxtx.c | 208 +++++++++--------- > drivers/net/virtio/virtio_rxtx_simple_neon.c | 5 +- > .../pthread_shim/pthread_shim.c | 12 +- > lib/librte_eal/include/rte_common.h | 10 + > lib/librte_vhost/virtio_net.c | 14 +- > 6 files changed, 139 insertions(+), 127 deletions(-) > The changes are quite mechanical for the existing drivers. On the vhost/virtio side, Maxime is off but Adrian had a look at the generic bits. The gains in vhost/virtio patches are interesting. So I went and took those patches through the main branch. Series applied, thanks Joyce. -- David Marchand