From: David Marchand <david.marchand@redhat.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>, dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal/freebsd: lock memory device to prevent conflicts
Date: Sat, 2 Oct 2021 16:43:00 +0200 [thread overview]
Message-ID: <CAJFAV8x7NNQqeDq2VVSZdNYqfegfzvF2c3guoBC+x1T-=2kCPg@mail.gmail.com> (raw)
In-Reply-To: <b7675eaf-711a-0a06-f600-a4916580cc3b@intel.com>
On Mon, Sep 13, 2021 at 4:40 PM Burakov, Anatoly
<anatoly.burakov@intel.com> wrote:
> >> I'm a bit uneasy with --in-memory mode pretending to work on
> >> FreeBSD and Windows, but that's a separate problem :)
> >
> > Yes, it is, though one that does belong is the same area as this one. The
> > "fix" is probably to just print a warning when --in-memory is used,
> > informing the user that the flag is ignored and then continue.
> > Alternatively we can error out, but I think the warn+continue is better,
> > myself.
>
> I think erroring out is better. The feature is intended to work a
> certain way, so if we can't guarantee that it does, we can't pretend it
> is "supported" or "is working". But again, irrelevant to this patch :)
>
Please, can you review
https://patchwork.dpdk.org/project/dpdk/patch/20210913140848.184928-1-bruce.richardson@intel.com/
?
Thanks.
--
David Marchand
next prev parent reply other threads:[~2021-10-02 14:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 11:06 [dpdk-dev] [PATCH] eal/freebsd: lock memory device to prevent conflicts Bruce Richardson
2021-09-13 13:14 ` Burakov, Anatoly
2021-09-13 13:36 ` Bruce Richardson
2021-09-13 14:40 ` Burakov, Anatoly
2021-10-02 14:43 ` David Marchand [this message]
2021-09-13 13:59 ` Dmitry Kozlyuk
2021-10-02 14:42 ` David Marchand
2021-09-13 14:08 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2021-10-06 14:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8x7NNQqeDq2VVSZdNYqfegfzvF2c3guoBC+x1T-=2kCPg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.