From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3E06C432C3 for ; Thu, 14 Nov 2019 11:13:34 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 64A76206D8 for ; Thu, 14 Nov 2019 11:13:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BjJpgPH8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64A76206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 89A6F2B86; Thu, 14 Nov 2019 12:13:33 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 2EFCB235 for ; Thu, 14 Nov 2019 12:13:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573730011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oEZOc0ccAx0vt/++6iMITiRGKwYCzW5PXVUgGAjQrhY=; b=BjJpgPH8apma6d1yu8eCZ5yNRZEdT7KWpeKl/bN7It9f3jSQ47WlqFet3GnROIxxm57JbV cIK9nUh90fgoQWSjf92rD+vVG5JS/T6xN55oDCen2tFLxehJ9EBrS2Vg2Ar4pX6h0iZ1yV ym300QgyfI5Ef3GQKxLxtyEEywJOjOc= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-346-rOC6Yzv1PLeW4Gq-j35SWA-1; Thu, 14 Nov 2019 06:13:28 -0500 Received: by mail-ua1-f69.google.com with SMTP id 49so1336896uad.20 for ; Thu, 14 Nov 2019 03:13:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qO7toumAMkOH4Eawe+9/QhBtMCB5Pn9CMEYUcnNHtX8=; b=PkZVc0BSGD4eIgwwBi8ZE63TtB2ctrO8qEVMBVq8F80L6qR4VP4Ho85VEgAtWGd+ax 5d1HziyeTaJXyQswuy2KVqIzOqsATyXU+XrN77D9C+ovPRrM+9FzUYHIesfGX8MGIS2r Q78rDxWx7tqU2b20XmLoSSmCcOUEnaawNLDjUAQM66sfSpk8jdofUwVeo5ASwunDcEqT m/z1M2CQleqoURpWDd6eI/7RnVLMNcpTmkhZ0uXh9MYuDcvaW+V050ZTycFXkYPD8AkY raaUSTgtezUe0pRV0hJCLpYnHjKhCZEKPNf9yBVjxhyqdjjo7OvqIMv39SXjNaOvwQzf 8XtA== X-Gm-Message-State: APjAAAV/qF1iThGKiXvd2n+xpT5sJxWjNmqe8eIVQ1U7XqiCMR9olOY/ WxfQ4bYBUpajYzNXa/EOsphprua86HwckUs0mUGbwnudq0wM15H8kCerCsKft96AzHUzArtDwSp Sv5bw0DRfhpq/rq9ij0c= X-Received: by 2002:a1f:e243:: with SMTP id z64mr373824vkg.56.1573730007990; Thu, 14 Nov 2019 03:13:27 -0800 (PST) X-Google-Smtp-Source: APXvYqxWNDgAUIkjvrzsOMPDCzRNfGFsG088nSjol5S6mB/cOIP2LvFUPT9QaaIEMDi/fPSvxJncW03Nwo2TEZ/ke9Q= X-Received: by 2002:a1f:e243:: with SMTP id z64mr373798vkg.56.1573730007573; Thu, 14 Nov 2019 03:13:27 -0800 (PST) MIME-Version: 1.0 References: <20191021080324.10659-1-vattunuru@marvell.com> <20191105110416.8955-1-vattunuru@marvell.com> <20191105110416.8955-2-vattunuru@marvell.com> In-Reply-To: From: David Marchand Date: Thu, 14 Nov 2019 12:13:16 +0100 Message-ID: To: Vamsi Attunuru Cc: dev , Thomas Monjalon , Jerin Jacob Kollanukkaran , kirankumark@marvell.com, Olivier Matz , "Yigit, Ferruh" , "Burakov, Anatoly" , Andrew Rybchenko , Stephen Hemminger , Luca Boccassi X-MC-Unique: rOC6Yzv1PLeW4Gq-j35SWA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v12 1/2] kni: add IOVA=VA mode support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 14, 2019 at 11:57 AM David Marchand wrote: > On Tue, Nov 5, 2019 at 12:05 PM wrote: > > diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/= eal.c > > index 9e2d50c..a1c5bf6 100644 > > --- a/lib/librte_eal/linux/eal/eal.c > > +++ b/lib/librte_eal/linux/eal/eal.c > > @@ -922,6 +922,19 @@ static int rte_eal_vfio_setup(void) > > } > > #endif > > > > +static enum rte_iova_mode > > +rte_eal_kni_get_iova_mode(enum rte_iova_mode iova_mode) > > +{ > > + if (iova_mode =3D=3D RTE_IOVA_VA) { > > +#if KERNEL_VERSION(4, 6, 0) > LINUX_VERSION_CODE > > I understood that IOVA as VA is possible with kernel >=3D 4.6. > Should it be < ? I meant "Should the #if check be < ?". I did not mention this first, but thinking again, don't we have an issue he= re? This won't work for distributions that ship dpdk with kni built with dkms. Cc: Luca. --=20 David Marchand