All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Dodji Seketeli <dodji@redhat.com>
Cc: Huisong Li <lihuisong@huawei.com>, dev <dev@dpdk.org>,
	 Thomas Monjalon <thomas@monjalon.net>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	Ray Kinsella <mdr@ashroe.eu>
Subject: Re: [dpdk-dev] [PATCH V2] ethdev: add dev configured flag
Date: Wed, 7 Jul 2021 09:39:37 +0200	[thread overview]
Message-ID: <CAJFAV8xVC=WcjFtj-h9kVWM4zU4fmXjeqRm-76oodh9cBiXt1A@mail.gmail.com> (raw)
In-Reply-To: <966ec9cd-9142-b40d-b059-b63c8ece66bf@oktetlabs.ru>

On Tue, Jul 6, 2021 at 10:36 AM Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru> wrote:
>
> @David, could you take a look at the ABI breakage warnings for
> the patch. May we ignore it since ABI looks backward
> compatible? Or should be marked as a minor change ABI
> which is backward compatible with DPDK_21?

The whole eth_dev_shared_data area has always been reset to 0 at the
first port allocation in a dpdk application life.
Subsequent calls to rte_eth_dev_release_port() reset every port
eth_dev->data to 0.

This bit flag is added in a hole of the structure, and it is
set/manipulated internally of ethdev.

So unless the application was doing something nasty like highjacking
this empty hole in the structure, I see no problem with the change wrt
ABI.


I wonder if libabigail is too strict on this report.
Or maybe there is some extreme consideration on what a compiler could
do about this hole...
Dodji?


For now, we can waive the warning.
I'll look into the exception rule to add.


-- 
David Marchand


  parent reply	other threads:[~2021-07-07  7:39 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-08  8:00 [dpdk-dev] [RFC] lib/ethdev: add dev configured flag Huisong Li
2021-05-31  8:51 ` Huisong Li
2021-06-14 15:37 ` Andrew Rybchenko
2021-06-29  2:27   ` Huisong Li
2021-07-02 10:08     ` Andrew Rybchenko
2021-07-02 11:57       ` Ferruh Yigit
2021-07-02 13:23         ` Ananyev, Konstantin
2021-07-03  8:35           ` Huisong Li
2021-07-03 11:04             ` Ananyev, Konstantin
2021-07-05  3:03               ` Huisong Li
2021-07-05  9:50                 ` Andrew Rybchenko
2021-07-05 11:22                   ` Ananyev, Konstantin
2021-07-06  1:47                     ` Huisong Li
2021-07-04 20:05 ` Thomas Monjalon
2021-07-05  3:18   ` Huisong Li
2021-07-05  6:07     ` Thomas Monjalon
2021-07-05  9:50       ` Andrew Rybchenko
2021-07-06  1:48         ` Huisong Li
2021-07-06  3:24 ` [dpdk-dev] [PATCH V1] ethdev: " Huisong Li
2021-07-06  4:10 ` [dpdk-dev] [PATCH V2] " Huisong Li
2021-07-06  8:36   ` Andrew Rybchenko
2021-07-07  2:55     ` Huisong Li
2021-07-07  8:25       ` Andrew Rybchenko
2021-07-07  9:26         ` Huisong Li
2021-07-07  7:39     ` David Marchand [this message]
2021-07-07  8:23       ` Andrew Rybchenko
2021-07-07  9:36         ` David Marchand
2021-07-07  9:59           ` Thomas Monjalon
2021-07-07 10:40             ` David Marchand
2021-07-07 10:57               ` Thomas Monjalon
2021-07-06 17:49   ` Ananyev, Konstantin
2021-07-07  9:53 ` [dpdk-dev] [PATCH V3] " Huisong Li
2021-07-08  9:56   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8xVC=WcjFtj-h9kVWM4zU4fmXjeqRm-76oodh9cBiXt1A@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=dodji@redhat.com \
    --cc=ferruh.yigit@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=lihuisong@huawei.com \
    --cc=mdr@ashroe.eu \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.