Re: [dpdk-dev] [PATCH v3 1/8] net/dpaa: add support for fmlib in dpdk

[David Marchand <david.marchand@redhat.com>]

Hello Hemant,

On Mon, Jul 20, 2020 at 6:50 AM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
> >Why dropping this codebase in DPDK instead of pulling it as a dependency?
> [Hemant] >I don't like seeing DPDK becoming a pile of code duplicated from somewhere else.
> [Hemant] We are not using the library as it is and making some serious changes in the generic library to suit the DPDK use-case.
> So, it is not possible for us to use the *original* code of fmlib, which is public.

Looking at https://github.com/qoriq-open-source/fmlib which I think is
the original code for this library (?).

Some symbols from the original code were dropped in the dpdk copy of the file.
Part of the API changed, with a param pointer now being passed.
The VSP symbols are in the fm_lib.c file from the original code while
they have been separated in a fm_vsp.c file in the dpdk copy.
Some logs / comments have changed.

For the sake of understanding:
- can you point at the problems with reusing this externally maintained library?
- this library is tightly linked to the fm kmod drivers I guess, how
is maintained the compatibility?


Thanks.

-- 
David Marchand