From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BE10FA372C for ; Fri, 8 Nov 2019 14:07:51 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id D0CAA21D6C for ; Fri, 8 Nov 2019 14:07:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0CAA21D6C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DD2C11C1C9; Fri, 8 Nov 2019 15:07:49 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 7A4261C1C4 for ; Fri, 8 Nov 2019 15:07:48 +0100 (CET) Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A6CDCC004E85 for ; Fri, 8 Nov 2019 14:07:47 +0000 (UTC) Received: by mail-ua1-f69.google.com with SMTP id r21so2345305uao.16 for ; Fri, 08 Nov 2019 06:07:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Tvf+75VXHK261EB1vlx6vvaUZabLpMt2GDVc9D03GoY=; b=UkmqXKYpBBvYMDrSjdrW6+vQgXyZu9Nt0HS5co296lBp0ENbhAKBI3dLPGir9HVEYv 2LSMsf6k0iDhbKXFbc5UBx4lqto4R0femWV9FyZV2/mOQpJvEfOjOEDkuNs4JmbsRXEq 1bsi3cHh+Pxtax7VqEeiOTaZ9nmrluesmeirUUxA6BpcRG4r4C16YHp7HLkc8Z9HQF0H pF4bOsOvoQkC1clgC9cKtr6JO9vbCi5xh/Ma4O9p8HCtM9ddbf9Je2oo+ALkU4gSQSdz pPQuz484BAYEOKlQwIeo06TAz/GTxXfNx1lBwE97aekpyC16VdGKxThC6tNyygBnAh3S Y9iQ== X-Gm-Message-State: APjAAAUBJVvOXwDiEelhqzSGNIG/C6/lM+KLwQwUsiB8vEj5JZK5YRNh KAtMSt2gpD4wm09vTxioD3asWQgcAInb1XJ55PlLcEEPSk/BTJJs1O+YKD1GJsDA5c3ZS+tZmNv qNyy1UEdPd28jebnqXgY= X-Received: by 2002:a9f:3772:: with SMTP id a47mr7057475uae.53.1573222066787; Fri, 08 Nov 2019 06:07:46 -0800 (PST) X-Google-Smtp-Source: APXvYqz2LUfsXBEOCDFYaifelOQWGRSAbykNUgLlZbRxz3gTJsNyDgK97j27W1WiUik4oh7eybwMEzJCnW4qv/u9FTg= X-Received: by 2002:a9f:3772:: with SMTP id a47mr7057447uae.53.1573222066348; Fri, 08 Nov 2019 06:07:46 -0800 (PST) MIME-Version: 1.0 References: <20191001125315.6191-1-ktraynor@redhat.com> <20191106190203.10750-1-ktraynor@redhat.com> In-Reply-To: <20191106190203.10750-1-ktraynor@redhat.com> From: David Marchand Date: Fri, 8 Nov 2019 15:07:35 +0100 Message-ID: To: Kevin Traynor Cc: dev , Rosen Xu , Xiaolong Ye Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [v2 PATCH 0/8] Coverity fixes and other cleanups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 6, 2019 at 8:02 PM Kevin Traynor wrote: > > Patches 1-4 are Coverity fixes. > Patches 5-8 are removing commented out code. > > v2: > - 1/8: removed added NULL check for devargs_all > - 2/8: fixed headline to common/cpt > - v1 3/9 'net/bnxt: remove logically dead code' > removed as duplicate patch already applied > > Kevin Traynor (8): > net/pcap: fix argument checks > common/cpt: fix possible NULL deference > net/ipn3ke: fix incorrect commit check logic > net/ipn3ke: remove useless if statement > net/ipn3ke: remove commented out code > compress/octeontx: remove commented out code > event/opdl: remove commented out code > net/bnxt: remove commented out code Dropped patch 3 since I did not see a review on it, and I was not feeling comfortable with it. Applied, thanks. -- David Marchand