From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Marchand <david.marchand@redhat.com>
Subject: Re: [PATCH v4 1/4] app/testpmd: add missing newline when
	showing statistics
Date: Fri, 22 Mar 2019 18:43:14 +0100
Message-ID: <CAJFAV8ximhoQbcg5=pmM2-OiGqWPudL8A8X_Zq6dbX+wJvQc1g@mail.gmail.com>
References: <1553076154-3907-1-git-send-email-david.marchand@redhat.com>
 <1553261824-1881-1-git-send-email-david.marchand@redhat.com>
 <1553261824-1881-2-git-send-email-david.marchand@redhat.com>
 <8568275c-04a1-9d1a-6fa7-ecf7487cce3e@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: dev <dev@dpdk.org>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>, "Iremonger,
 Bernard" <bernard.iremonger@intel.com>,
 Rami Rosen <ramirose@gmail.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 dpdk stable <stable@dpdk.org>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-vk1-f194.google.com (mail-vk1-f194.google.com
 [209.85.221.194]) by dpdk.org (Postfix) with ESMTP id CA7681B725
 for <dev@dpdk.org>; Fri, 22 Mar 2019 18:43:25 +0100 (CET)
Received: by mail-vk1-f194.google.com with SMTP id o187so653567vkg.4
 for <dev@dpdk.org>; Fri, 22 Mar 2019 10:43:25 -0700 (PDT)
In-Reply-To: <8568275c-04a1-9d1a-6fa7-ecf7487cce3e@solarflare.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Mar 22, 2019 at 6:35 PM Andrew Rybchenko <arybchenko@solarflare.com>
wrote:

> On 22.03.2019 16:37, David Marchand wrote:
> > Having the standard stats and the rx burst stats on the same line gives a
> > really long line and is not consistent with the rest.
> >
> > Before:
> >    RX-packets: 3542977        TX-packets: 3542971        TX-dropped: 6
>              RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of
> others]
> >    TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others]
> >
> > After:
> >    RX-packets: 4629969        TX-packets: 4629969        TX-dropped: 0
> >    RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others]
> >    TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others]
> >
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > Reviewed-by: Rami Rosen <ramirose@gmail.com>
> > Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
> > ---
> > Changelog since v2:
> > - Cc'd stable
> >
> > ---
> >   app/test-pmd/testpmd.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> > index 216be47..40199c1 100644
> > --- a/app/test-pmd/testpmd.c
> > +++ b/app/test-pmd/testpmd.c
> > @@ -1459,7 +1459,7 @@ struct extmem_param {
> >              "TX Port=%2d/Queue=%2d %s\n",
> >              fwd_top_stats_border, fs->rx_port, fs->rx_queue,
> >              fs->tx_port, fs->tx_queue, fwd_top_stats_border);
> > -     printf("  RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u",
> > +     printf("  RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u\n",
> >              fs->rx_packets, fs->tx_packets, fs->fwd_dropped);
> >
> >       /* if checksum mode */
>
>
> In fact bad Rx checksum counters follow and I think they should be in
> this line.
>
> That's why there is no \n here from the very beginning.
>
> My fix for the bug (local) just add \n in else branch below.
>


Mm, ok, I will look at this monday.
I might add the \n in pkt_burst_stats_display() and update other callers.


-- 
David Marchand