From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>, Aaron Conole <aconole@redhat.com>,
Michael Santana <maicolgabriel@hotmail.com>
Subject: Re: [dpdk-dev] [PATCH] ci: add minimal check on testpmd
Date: Sun, 24 Nov 2019 15:17:30 +0100 [thread overview]
Message-ID: <CAJFAV8xpmCQAP2kXOqrwsosHsafM=r_SvBucyv_3iHtOE3S9xQ@mail.gmail.com> (raw)
In-Reply-To: <4177024.uonCvJI2tQ@xps>
On Fri, Nov 22, 2019 at 5:29 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 22/11/2019 16:54, David Marchand:
> > --- a/.ci/linux-build.sh
> > +++ b/.ci/linux-build.sh
> > +if [ "$AARCH64" != "1" ]; then
> > + ./devtools/test-null.sh
>
> You are missing the build directory as first parameter,
> otherwise it won't find testpmd.
This parameter is optional.
In test-null.sh:
build=${1:-build} # first argument can be the build directory
travis builds in this directory.
I suppose you noticed that the jobs in travis were all failing, but
this is because the fix [1] on testpmd is not in master yet.
1: https://patchwork.dpdk.org/patch/63226/
>
> One nit: ./ is probably useless.
No strong opinion.
--
David Marchand
next prev parent reply other threads:[~2019-11-24 14:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 15:54 [dpdk-dev] [PATCH] ci: add minimal check on testpmd David Marchand
2019-11-22 16:29 ` Thomas Monjalon
2019-11-24 14:17 ` David Marchand [this message]
2019-11-24 18:12 ` Thomas Monjalon
2019-11-26 22:41 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xpmCQAP2kXOqrwsosHsafM=r_SvBucyv_3iHtOE3S9xQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=maicolgabriel@hotmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.