From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: "Jiang, Cheng1" <cheng1.jiang@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>, dev <dev@dpdk.org>,
"Fu, Patrick" <patrick.fu@intel.com>,
"Yang, YvonneX" <yvonnex.yang@intel.com>,
"Hu, Jiayu" <jiayu.hu@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] examples/vhost: fix ioat dependency issue
Date: Thu, 12 Nov 2020 10:39:33 +0100 [thread overview]
Message-ID: <CAJFAV8yFYXQufQ-BcJ_BidLgF=5cSM4fLO8G3LBAvc_pcoEtUw@mail.gmail.com> (raw)
In-Reply-To: <20201112093113.GB1309@bricha3-MOBL.ger.corp.intel.com>
On Thu, Nov 12, 2020 at 10:31 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> > > main.c should check for RTE_RAW_IOAT before including ioat.h.
> > > And then in this header, you can remove this stub too.
> > >
> >
> > As for this one, ioat.h don't have dependency on IOAT driver, it is needed by the example regardless of whether the raw/ioat driver exists. And I added more RTE_RAW_IOAT check in ioat.h. Now it can be compiled.
> >
>
> The trouble is that the ioat header file won't be installed if the driver
> is not built. They will be available for building inside the source tree,
> but not on a system with dpdk installed using "ninja install"
I tested disabling the driver, and I can see:
installdir/usr/local/share/dpdk/examples/vhost/ioat.h
--
David Marchand
next prev parent reply other threads:[~2020-11-12 9:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 11:19 [dpdk-dev] [PATCH v1] examples/vhost: fix ioat dependency issue Cheng Jiang
2020-11-11 14:36 ` David Marchand
2020-11-11 15:03 ` Bruce Richardson
2020-11-12 7:14 ` Jiang, Cheng1
2020-11-12 9:31 ` Bruce Richardson
2020-11-12 9:39 ` David Marchand [this message]
2020-11-12 10:22 ` Bruce Richardson
2020-11-12 5:16 ` [dpdk-dev] [PATCH v2] " Cheng Jiang
2020-11-12 7:21 ` [dpdk-dev] [PATCH v3] " Cheng Jiang
2020-11-12 9:36 ` David Marchand
2020-11-12 10:28 ` Bruce Richardson
2020-11-12 11:29 ` Jiang, Cheng1
2020-11-12 12:02 ` Bruce Richardson
2020-11-12 14:06 ` Jiang, Cheng1
2020-11-12 13:47 ` [dpdk-dev] [PATCH v4] " Cheng Jiang
2020-11-12 15:01 ` Bruce Richardson
2020-11-12 15:55 ` Jiang, Cheng1
2020-11-12 15:49 ` [dpdk-dev] [PATCH v5] " Cheng Jiang
2020-11-12 16:01 ` Bruce Richardson
2020-11-12 16:51 ` Maxime Coquelin
2020-11-12 18:18 ` David Marchand
2020-11-13 8:40 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yFYXQufQ-BcJ_BidLgF=5cSM4fLO8G3LBAvc_pcoEtUw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=chenbo.xia@intel.com \
--cc=cheng1.jiang@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jiayu.hu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=patrick.fu@intel.com \
--cc=thomas@monjalon.net \
--cc=yvonnex.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.