From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F116C43215 for ; Wed, 20 Nov 2019 21:30:26 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 9411120855 for ; Wed, 20 Nov 2019 21:30:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bScRLmOH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9411120855 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2002127D; Wed, 20 Nov 2019 22:30:24 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 5753D271 for ; Wed, 20 Nov 2019 22:30:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574285421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QD45UN+z7VxP4ggfZsk+Ym0pTJZw+1lp4Yznl4rRIc0=; b=bScRLmOHneEJwFSbFiFtwxEjnnrXM4dkoJTYcXwX/IuB6KAjngSVN2erdrhgg3AqTejdv8 BJB49Un4o45ESwjSH8LJA11OnzEaEcwxipuknt5Jx/7aXVftMD0+33Kms7rrFxUnXUSSvG KVuUllIJEfs+X2kDdA75Srzx9Sjd82Q= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-388-8LhcIGm0N---Ug_sJQWffQ-1; Wed, 20 Nov 2019 16:30:18 -0500 Received: by mail-vk1-f198.google.com with SMTP id i5so417962vkg.21 for ; Wed, 20 Nov 2019 13:30:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4kwkAAV91j/Y7XOkbB/r57EmKtM9Dr5g8QO4P3IDJiU=; b=m28Hg9mIRu9pDgbgXheLwd5mmc1lXPHD3MpPpkz6H5dkwhCO5XZsNuOq4/EBd+1r1i /sXaWe9J0p+jYip2NwxRqKthPQQQH+4H9kh2ttMv5f/b3ko+SjZDQnKQ7+tgXtHLpf+b iJHEPbKqG3plZnIKydmkMbdBndw3Wr/TJCbQeT4cKg+AYiFP9RImmCXPErVnTWTw8NXC RTkHa9LlKpZwzFbUIBdzGe6O6PhYIPJxf5B+GsO9i7j5/QE/GGJFWdhj3r0ejDQoBs2+ vu+d5DcVL0hpzhPf1Rw6O/5IOZ8I9dJCP29gupxyI+W78o15GbDT8TqT9bvxepjvmm+u iRQA== X-Gm-Message-State: APjAAAXI/KuxrvTLhb9hyYUInUyx6WUQWolMxfLr4xI5vkRzTXoiOLgJ MKvALaG8fLuEN96V6wLezwxYYMoAQsR978InO/WU0yR5Ojq2cVaVSpVuIRulRM5Jo6LJ0Po7Sit 04yVZ/qTF6LQbwqWJ66g= X-Received: by 2002:a1f:9553:: with SMTP id x80mr3261401vkd.39.1574285417705; Wed, 20 Nov 2019 13:30:17 -0800 (PST) X-Google-Smtp-Source: APXvYqySGdXa4vI4NDnx7x7qO1IxKrRYq09/RDFd/3iKV7TC3b/b37gjpAt9sq1LJZ9ajq6aB/rjMGlRL70T0hmKjt0= X-Received: by 2002:a1f:9553:: with SMTP id x80mr3261377vkd.39.1574285417365; Wed, 20 Nov 2019 13:30:17 -0800 (PST) MIME-Version: 1.0 References: <1571917119-149534-2-git-send-email-andy.pei@intel.com> <1573722187-148846-1-git-send-email-rosen.xu@intel.com> <1573722187-148846-11-git-send-email-rosen.xu@intel.com> <10496132.hlKR8GaRvu@xps> In-Reply-To: <10496132.hlKR8GaRvu@xps> From: David Marchand Date: Wed, 20 Nov 2019 22:30:05 +0100 Message-ID: To: Thomas Monjalon Cc: Rosen Xu , dev , "Zhang, Tianfei" , "Pei, Andy" , Xiaolong Ye , "Yigit, Ferruh" X-MC-Unique: 8LhcIGm0N---Ug_sJQWffQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v18 10/19] raw/ifpga: add SEU error handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 20, 2019 at 10:23 PM Thomas Monjalon wrot= e: > > Rosen (and most of your colleagues), > Please use --in-reply-to when sending a new version. > All versions must be a reply to the very first cover letter. > > 14/11/2019 10:02, Rosen Xu: > > + IFPGA_RAWDEV_PMD_INFO("seu emr low: 0x%lx\n", val); > > Using %lx is usually wrong. > val is 64-bit. > On 32-bit machines (like some Intel ones), it does not compile. > I had to fix it while pulling next-net. > > The same issue was in "raw/ifpga/base: clean fme errors". > > Please check 32-bit compilation. > > Note: we should have such check in the CI. https://git.dpdk.org/dpdk/commit/?id=3D3be76aa9294f3788b4f9c615642e6027f1b7= 948a --=20 David Marchand