From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFB0CC433EF for ; Tue, 7 Jun 2022 14:16:57 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D5B64021D; Tue, 7 Jun 2022 16:16:56 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5F84F40156 for ; Tue, 7 Jun 2022 16:16:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654611414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cEgHZZyUFDujIQk2LOCRTubZeaDk4dPWCU8S5cZt6kg=; b=RPnPMIG7TFAJUQsFHtQbrWeLzfmGcaZxry1gNxDV7v0s4e6qqdFJCg8d2tjfLn6oJHoYW6 9WvquEkMU82V4AEAMBJ5YIdWDRf4kdCHlarFC92lyxf79DohyHHkoAn7Y++bYFLj0KdlKa FMt3L0oRoJwRqDu3Lha09SkjGUJiPP4= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-605-wQJktwTVMlKVy-XQnwjBsQ-1; Tue, 07 Jun 2022 10:16:48 -0400 X-MC-Unique: wQJktwTVMlKVy-XQnwjBsQ-1 Received: by mail-lf1-f70.google.com with SMTP id n3-20020ac242c3000000b00473d8af3a0cso8815767lfl.21 for ; Tue, 07 Jun 2022 07:16:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cEgHZZyUFDujIQk2LOCRTubZeaDk4dPWCU8S5cZt6kg=; b=V0ekt1ayLudtKUbAneqZjdQsj+3fpxkvgcsT1/DtJ1fMpGHiPuU7/0PQtRsnvtSTbQ LzS0r0qPN/GeTiHER7tLMRINyVcv4fvkeTmCinYkc3omLuxfRlnkiibcVWh7VKriqUm1 Sl41agrkdSc2NZgMuD2I8lNOOS/JVwpCK3SMJ2FOQLm8PoNR4fgLrES/W65YSDl8kCpI m0DWrITwp9NRqbOFYNEwq8yruZiDyAKkkAK1g/BnjSAJK1aQutg86czO/VbQYXksWOD2 Cks2rbeNns2Vicww30AsYLhvlEhg4XSFaW7L6AjEcaUhi1kvbPnWHSvUqOnsV31oQ+UK Vmtg== X-Gm-Message-State: AOAM53189pKS7bDagyyouCx1N4zCJpue+CPngT8lJsxVrWMe6eqNA9ji n8hErFreX48yRRYyYqpfrc4chK4RQzoJl/KCQLH8++tuvoX66P1JsbT4Z8ZDKS1x6KjLRwMRo26 yxncr/N15Ixetsbd5aHI= X-Received: by 2002:ac2:5201:0:b0:479:3923:9559 with SMTP id a1-20020ac25201000000b0047939239559mr8387002lfl.553.1654611405512; Tue, 07 Jun 2022 07:16:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKGRrlVphi8ODSiP/kMtbMXCjVpy3p075xNk7SjZd/7jLc7231zUtzoTsw7GGB1Wc+UoHn3YzQTQDjgV5L+IE= X-Received: by 2002:ac2:5201:0:b0:479:3923:9559 with SMTP id a1-20020ac25201000000b0047939239559mr8386987lfl.553.1654611405269; Tue, 07 Jun 2022 07:16:45 -0700 (PDT) MIME-Version: 1.0 References: <20220602150834.643745-1-bruce.richardson@intel.com> <20220603111625.562070-1-bruce.richardson@intel.com> In-Reply-To: <20220603111625.562070-1-bruce.richardson@intel.com> From: David Marchand Date: Tue, 7 Jun 2022 16:16:34 +0200 Message-ID: Subject: Re: [PATCH v4 0/4] clean up zero-length arrays To: Bruce Richardson Cc: dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jun 3, 2022 at 1:16 PM Bruce Richardson wrote: > > This patchset adds a coccinelle script to clean-up zero-length > arrays in structures. The final patches are the result of running > that script on the DPDK repository. > > > Bruce Richardson (4): > cocci: add script for zero-length arrays in structs > drivers: replace zero-length arrays with undimensioned ones > lib: replace zero-length arrays with undimensioned ones > app: examples: replace zero-length arrays with undimensioned ones > > app/test/test_table_tables.c | 2 +- > devtools/cocci/zero_length_array.cocci | 21 +++++++++++++++++++ > drivers/bus/dpaa/include/netcfg.h | 4 ++-- > drivers/bus/vmbus/rte_vmbus_reg.h | 4 ++-- > drivers/common/cnxk/roc_se.h | 2 +- > drivers/common/dpaax/dpaax_iova_table.h | 2 +- > drivers/common/mlx5/mlx5_prm.h | 10 ++++----- > drivers/crypto/ipsec_mb/ipsec_mb_private.h | 4 ++-- > drivers/crypto/virtio/virtio_ring.h | 4 ++-- > drivers/crypto/virtio/virtqueue.h | 2 +- > drivers/net/atlantic/hw_atl/hw_atl_utils.h | 2 +- > drivers/net/cxgbe/clip_tbl.h | 2 +- > drivers/net/cxgbe/l2t.h | 2 +- > drivers/net/cxgbe/mps_tcam.h | 2 +- > drivers/net/cxgbe/smt.h | 2 +- > drivers/net/enic/base/vnic_devcmd.h | 2 +- > drivers/net/hinic/hinic_pmd_tx.h | 2 +- > drivers/net/nfp/nfpcore/nfp_nsp.h | 2 +- > drivers/net/virtio/virtio_ring.h | 4 ++-- > drivers/net/virtio/virtio_user/vhost_kernel.c | 2 +- > drivers/net/virtio/virtio_user/vhost_vdpa.c | 2 +- > drivers/net/virtio/virtqueue.h | 2 +- > drivers/regex/mlx5/mlx5_rxp.h | 4 ++-- > examples/ip_reassembly/main.c | 2 +- > examples/ptpclient/ptpclient.c | 4 ++-- > lib/cryptodev/cryptodev_pmd.h | 2 +- > lib/cryptodev/rte_cryptodev.h | 2 +- > lib/eventdev/rte_event_timer_adapter.h | 2 +- > lib/ip_frag/ip_reassembly.h | 2 +- > lib/ipsec/sa.h | 2 +- > lib/rib/rte_rib.c | 2 +- > lib/rib/rte_rib6.c | 2 +- > lib/table/rte_swx_table_learner.c | 4 ++-- > lib/table/rte_table_hash_key16.c | 4 ++-- > lib/table/rte_table_hash_key32.c | 4 ++-- > lib/table/rte_table_hash_key8.c | 4 ++-- > lib/vhost/rte_vhost.h | 4 ++-- > 37 files changed, 73 insertions(+), 52 deletions(-) > create mode 100644 devtools/cocci/zero_length_array.cocci Series applied, thanks for the cleanup. -- David Marchand