From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0176C4332F for ; Mon, 17 Oct 2022 07:30:45 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 958B841101; Mon, 17 Oct 2022 09:30:44 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 70CB640143 for ; Mon, 17 Oct 2022 09:30:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665991841; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Mv8mble9sup0HRS4j0LTNL5otiwQ/XU+fKNVd3jlQNY=; b=iQuLRYGyS4DtyLKcAfhkHxshgHhf7VPf8Sbwb6iJ9Txe7QHrMoCY0fp2nAyTTXzVkzz1Ay 81x1ExEBt5Havk0+gmm1B7R/vJTXHlPW2Zruv4YcROAO1c95Mqhqxl6J1/Pxb6QRzhmN67 OXXe20vHkC2kTPJqtPYJoo0cOf23y58= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-427-OnAkbCrMOlaYMp-OfZvuUQ-1; Mon, 17 Oct 2022 03:30:38 -0400 X-MC-Unique: OnAkbCrMOlaYMp-OfZvuUQ-1 Received: by mail-pf1-f200.google.com with SMTP id n56-20020a056a000d7800b00562b27194d1so5663020pfv.19 for ; Mon, 17 Oct 2022 00:30:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Mv8mble9sup0HRS4j0LTNL5otiwQ/XU+fKNVd3jlQNY=; b=f0ay10NFI9b7CMcoO06HJTEIglYoujfTZtyDZDlngjvKnywv7iWNmIVW8jCSz9SYQe +1C9OZckQBNafBvcFZqdlnctEFPMicE64n6WTAdHBkaD/BFMlhjoLKcNvRs6zTyiHzhr B8MM8YakIbza3gJhAFuki4I+tQlXBycPTkxH22hhGdBMlNcZDvR0eRV0NST24QVZTcvE mJQeNYOoE5ucrqKQmZEavY7dtXKNGjXTryZhOV1K/aUOEzjdzzRHC8esR2aTGGS+rLXD tKXiNA8V6R92qWniQ75iQSVUuHM8OdD5VFAOf9LP6TQn4GvDel28vdk9Imu3xLAzEvin KSZw== X-Gm-Message-State: ACrzQf1XZ03eL3kLtt7yT9kJW21IlAaChZAUwmkFYqLpNARsBbpNOQQL ZbjpCGBeAt3UBAnh+hRyOPFQ17pIFpb/OMOUsNt6tazh5xWlFXPlaPdY1olHMZNOj8IzkW6l/UR FlAhH9NsfQ2Lyh+yxz6c= X-Received: by 2002:a17:903:2307:b0:181:e618:b4c5 with SMTP id d7-20020a170903230700b00181e618b4c5mr10432725plh.172.1665991837785; Mon, 17 Oct 2022 00:30:37 -0700 (PDT) X-Google-Smtp-Source: AMsMyM61mxrf9KR+zHeUolQhCMFMz4YSPDMCtuqfyBxjOMQEKxdpfA0ETfDk5sWOEtqPxKwShp/9c/92I4lxstsc5hk= X-Received: by 2002:a17:903:2307:b0:181:e618:b4c5 with SMTP id d7-20020a170903230700b00181e618b4c5mr10432706plh.172.1665991837512; Mon, 17 Oct 2022 00:30:37 -0700 (PDT) MIME-Version: 1.0 References: <20221014203710.6172-1-olivier.matz@6wind.com> In-Reply-To: <20221014203710.6172-1-olivier.matz@6wind.com> From: David Marchand Date: Mon, 17 Oct 2022 09:30:26 +0200 Message-ID: Subject: Re: [PATCH 1/2] event/sw: fix missing flow ID init in selftest To: Olivier Matz Cc: dev@dpdk.org, Harry van Haaren , Bruce Richardson , David Hunt , Anatoly Burakov , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Andrew Rybchenko , stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 14, 2022 at 10:38 PM Olivier Matz wrote: > > The issue is seen by unit tests: > > > root@dpdk-VF-dut247:~/dpdk# MALLOC_PERTURB_=204 \ > > DPDK_TEST=eventdev_selftest_sw \ > > /root/dpdk/x86_64-native-linuxapp-gcc/app/test/dpdk-test -c 0xff > > (...) > > *** Running XStats ID Reset test... > > 12: 1761: qid_0_port_2_pinned_flows value , expected 1 got 7 > > 1778: qid_0_port_2_pinned_flows value incorrect, expected 1 got 7 > > ERROR - XStats ID Reset test FAILED. > > SW Eventdev Selftest Failed. > > Test Failed > > The flow id is not set in the event, which results in an undefined > flow, whose value depends on what was previously in stack. Having > different flows for the packets makes the test to fail, since only one > flow is expected. > > This only happens in -O3, where the same stack area is shared by the > event object and the address of the mbuf allocated in rte_gen_arp(). Good catch. That's scary... > > Fix this by properly initializing the flow id. > > Bugzilla ID: 1101 > Fixes: e21df4b062b5 ("test/eventdev: add SW xstats tests") > Cc: stable@dpdk.org > > Signed-off-by: Olivier Matz Reviewed-by: David Marchand -- David Marchand