From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D6E5CA9EA1 for ; Fri, 18 Oct 2019 13:17:11 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id C4CC1222BD for ; Fri, 18 Oct 2019 13:17:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ea41Y7Dw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4CC1222BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EBB471C231; Fri, 18 Oct 2019 15:17:09 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 8F08A1C21E for ; Fri, 18 Oct 2019 15:17:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571404627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z8Hy6zkafkPWpQ45t3WKFnV/HjNGC+axOwMedhQtn2M=; b=ea41Y7Dw+VTd+y+H+kY8yA9KVPbP7Z6v98TG39eDRmoiaVupdW4r7egz4URM4VE+9H6aqE 3kA5wsECmPo16XuZ6A1E03mb1WVeiWXOPAG8rK76L/b/4GVTAZCE3H53OuKtoFmOB2tQWV WGHbcNkbYciDHdijeUks3rDn9nqEbXE= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-227-NlH6KtriOp-TymSjkfjusQ-1; Fri, 18 Oct 2019 09:17:03 -0400 Received: by mail-vs1-f70.google.com with SMTP id w22so1376607vsw.17 for ; Fri, 18 Oct 2019 06:17:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hjct7YOrAqoco2TQv+uuc95URfO6shNv6gzyftSTiB0=; b=qiiLk4gs3iydtW6O9dsxL5YZn0kB/h9kBRrCsYYbLiSMMJ40PzmbxN/HQcPoPagZEk mIUWBeeR34WWCoyKjxDQ/uu2IvtzCEPE74ZEfVaEEA1xug53Wg9LCHQAyYNY6L/4eraT xjo0OtgMtDMh2EJNYlAUPT8jcSalXh3fLp7JwEnj7kmWk6rPOn2nlxOkp/It/ygLsi4X 6m+UMi8v9k6UoqmWGIkTRXgoVxsPPmLAH9VH642c7WVHmG0cTKea3eilB9YNs3Jb1+Ui xCodM7OgV4tyMk/TaVCTWdaGDAdsJF+BSi6LAmBy8xAdPGOVGxCukv9GghOAkPnuxoGd 3+nA== X-Gm-Message-State: APjAAAUGIlOyCEqRcYnGl5F6eVJe6vExt18c7jeBo1GTnIJmzf9MwE3E 2tzcknYsDWQheSiDT96EALx/EvPbJob9ZXWGmPUEmgUwCsQAbKsoEBLOQ68mdmkD/FdsXZL1tBd bgLA6Ry6GHq2nUA4S+gw= X-Received: by 2002:a67:fc49:: with SMTP id p9mr5183655vsq.198.1571404623382; Fri, 18 Oct 2019 06:17:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqwc8y5oo35IX24gQ5RO4e8w8J6lKv/JyuMDvO2I5FePXvoHkYHHuxAqg2Mt05+Lpg81T4TRNJp3Yt7w14Smnus= X-Received: by 2002:a67:fc49:: with SMTP id p9mr5183633vsq.198.1571404622940; Fri, 18 Oct 2019 06:17:02 -0700 (PDT) MIME-Version: 1.0 References: <20190903105938.33231-1-jerinj@marvell.com> <20190903105938.33231-8-jerinj@marvell.com> In-Reply-To: <20190903105938.33231-8-jerinj@marvell.com> From: David Marchand Date: Fri, 18 Oct 2019 15:16:51 +0200 Message-ID: To: Jerin Jacob Kollanukkaran , Thomas Monjalon Cc: dev , "Ananyev, Konstantin" , Honnappa Nagarahalli , Gavin Hu X-MC-Unique: NlH6KtriOp-TymSjkfjusQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 7/8] bpf/arm64: add atomic-exchange-and-add operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 3, 2019 at 1:00 PM wrote: > > From: Jerin Jacob > > Implement XADD eBPF instruction using STADD arm64 instruction. > If the given platform does not have atomics support, > use LDXR and STXR pair for critical section instead of STADD. For the record, this patch had a missed dependency on the 128-bits atomic for arm64 patch because of RTE_ARM_FEATURE_ATOMICS. This will be resolved once the latter is merged. > --- > lib/librte_bpf/bpf_jit_arm64.c | 85 +++++++++++++++++++++++++++++++++- > 1 file changed, 84 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_bpf/bpf_jit_arm64.c b/lib/librte_bpf/bpf_jit_arm6= 4.c > index c797c9c62..62fa6a505 100644 > --- a/lib/librte_bpf/bpf_jit_arm64.c > +++ b/lib/librte_bpf/bpf_jit_arm64.c [snip] > +static int > +has_atomics(void) > +{ > + int rc =3D 0; > + > +#if defined(__ARM_FEATURE_ATOMICS) || defined(RTE_ARM_FEATURE_ATOMICS) > + rc =3D 1; > +#endif > + return rc; > +} [snip] --=20 David Marchand