All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
	 Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] devtools: refuse indent with tabs in Meson
Date: Tue, 2 Nov 2021 19:22:46 +0100	[thread overview]
Message-ID: <CAJFAV8z1-7fabh=PJ7+NyX+E3i5MqmpavVQbsGMXe32HdMxP+w@mail.gmail.com> (raw)
In-Reply-To: <20211102111559.161c0914@hermes.local>

On Tue, Nov 2, 2021 at 7:16 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Fri, 22 Oct 2021 22:55:31 +0200
> David Marchand <david.marchand@redhat.com> wrote:
>
> > The rule for indentation in Meson in DPDK is 4 spaces.
> >
> > Any tab should be flagged as an issue, let's extend the check and fix
> > existing offenders.
> >
> > Fixes: 4ad4b20a7905 ("drivers: change indentation in build files")
> > Fixes: 2457705e6474 ("crypto/cnxk: add driver skeleton")
> > Fixes: 634b73104482 ("app/testpmd: build on Windows")
> > Fixes: 3a6bfc37eaf4 ("net/ice: support QoS config VF bandwidth in DCF")
> > Fixes: 8ef09fdc506b ("build: add optional NUMA and CPU counts detection")
> > Fixes: e1369718f553 ("common/octeontx: enable build only on 64-bit Linux")
> > Fixes: 2b504721bfda ("app/bbdev: enable la12xx")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> There is also a new one in the dumpcap program, but can send follow on
> for that one.
>
> Approved-by: Stephen Hemminger <stephen@networkplumber.org>

I am not aware of this form of tag, and patchwork does not recognise it either.
Converted to usual ack.


-- 
David Marchand


      reply	other threads:[~2021-11-02 18:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-22 20:55 [dpdk-dev] [PATCH] devtools: refuse indent with tabs in Meson David Marchand
2021-10-27  9:57 ` Bruce Richardson
2021-11-02 17:48   ` David Marchand
2021-11-02 18:05     ` Bruce Richardson
2021-11-02 18:23   ` David Marchand
2021-11-02 18:15 ` Stephen Hemminger
2021-11-02 18:22   ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8z1-7fabh=PJ7+NyX+E3i5MqmpavVQbsGMXe32HdMxP+w@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.