From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Marchand <david.marchand@redhat.com>
Subject: Re: [PATCH v2 2/4] ethdev: add siblings iterators
Date: Mon, 1 Apr 2019 08:46:41 +0200
Message-ID: <CAJFAV8zU7ti3wgdjbp_GoiAigsc84vrPwQLVdPjZr3KCezuBFQ@mail.gmail.com>
References: <20181130002716.27325-1-thomas@monjalon.net>
 <59747746.vl7xl9E5pD@xps>
 <50312a9a-884b-cc7d-24cd-c01a34cc22e7@intel.com> <4063619.5t9VujUhGY@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev <dev@dpdk.org>,
 Andrew Rybchenko <arybchenko@solarflare.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-ua1-f68.google.com (mail-ua1-f68.google.com
 [209.85.222.68]) by dpdk.org (Postfix) with ESMTP id 500A5343C
 for <dev@dpdk.org>; Mon,  1 Apr 2019 08:46:53 +0200 (CEST)
Received: by mail-ua1-f68.google.com with SMTP id e15so2692463uam.3
 for <dev@dpdk.org>; Sun, 31 Mar 2019 23:46:53 -0700 (PDT)
In-Reply-To: <4063619.5t9VujUhGY@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Apr 1, 2019 at 4:16 AM Thomas Monjalon <thomas@monjalon.net> wrote:

> 19/03/2019 19:04, Ferruh Yigit:
> > On 3/19/2019 5:34 PM, Thomas Monjalon wrote:
> > >>> +uint16_t __rte_experimental
> > >>
> > >> Do we need _rte_experimental on function definitions? I guess only in
> .h file,
> > >> function declaration is enough.
> > >
> > > Yes we need them both in .h and .c files.
> >
> > Why we need them in .c file?
> > I think the compiler is interested in ones in .h file, because of the
> > experimental checks.
>
> We need the tag in .c file because a check is done in the ELF object
> by buildtools/check-experimental-syms.sh
>

?
The attribute should be inherited from the declaration in the header.
If you have a case where it does not work, I'd like to look at it.



> David tried a replacement of this script to run on header files,
> but it looks a bit slow:
>         https://patches.dpdk.org/patch/49118/


Never got any review/comment, will do a quick update in this thread.


-- 
David Marchand