From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 567E7C07E95 for ; Wed, 7 Jul 2021 10:40:55 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id D64A761C77 for ; Wed, 7 Jul 2021 10:40:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D64A761C77 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3401A406FF; Wed, 7 Jul 2021 12:40:54 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 00940406B4 for ; Wed, 7 Jul 2021 12:40:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625654451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mAA/KLsw8LMmthwYvHkRqMH2egypymeKsjnbHwpYiMA=; b=hXnOn5QBMXnFXrSjwYkipht/h0bJaJinXfq/YRnqAduhi+vOw6OEKJ7Hj1HQPBgUgmjmfL f8CFObsdYWpB4FcPX2u5Tvxgo8gpwysCUPKPoX6qoHKoHZcwdeDIyXeuAchdQXbknThcKl efVJbz0mPRvnVUe4L1rtpre5c8xZPTE= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-295-u331RL4eO2eJ3hRQyt0TMQ-1; Wed, 07 Jul 2021 06:40:48 -0400 X-MC-Unique: u331RL4eO2eJ3hRQyt0TMQ-1 Received: by mail-ua1-f71.google.com with SMTP id w11-20020ab035eb0000b029029467c865a1so720963uau.14 for ; Wed, 07 Jul 2021 03:40:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mAA/KLsw8LMmthwYvHkRqMH2egypymeKsjnbHwpYiMA=; b=GhQQzcYCbwtNspvT6IB1nkIAnpjODrOJhjp2JWzMTfnQUNz+9K8hjkNMcGBhPBgdtE +yS8RZG8gQi30WoHqz5tqZoc5kYLfNiAPHSUj3LIyUYFm9Q2VWQD54GGom24xd6TfFea Og9W4V2+AHJpGOSUZbBCl0jElPQHfaP4dB8wvgln58ls20N/zmIk467aJVX72bUQgD0q Zx+lNP7aMf7aiZwnQ7EDprN7AlUAHEG5jNe3g5SJJoGWLlxy6BIpjGAzeDv8BW2zuLGl BgF6nCsJwMac4+1zZOBvfw5NWnKTf+rxN4JLYaKfX2Ky054dTefcyDJYr5oOtlf+O6iL bFmg== X-Gm-Message-State: AOAM531Srm+d+dfDab6twI9yql3vOyxLNuJoA8TDn8XEkAZno1OFauPN Kte3ZX9cPP+J3Wcg3QJsnfV+0csAjx/vdbIiRHf43V8qVRIqFSXxsAj/VlBERcfCvzihRrmVSjR ka1Noag1sU/3jogDT4xY= X-Received: by 2002:a67:3001:: with SMTP id w1mr11946674vsw.5.1625654447971; Wed, 07 Jul 2021 03:40:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgFAw8Hc8bvQ/aWwVd/TD8mM38RDSntchdxz2j/GBPu2k6blaxZM1vDAOaGWpU1vPz7KCz/w4lG5FPtLp++eg= X-Received: by 2002:a67:3001:: with SMTP id w1mr11946664vsw.5.1625654447815; Wed, 07 Jul 2021 03:40:47 -0700 (PDT) MIME-Version: 1.0 References: <1620460836-38506-1-git-send-email-lihuisong@huawei.com> <25012025.yGfkWu0M9X@thomas> In-Reply-To: <25012025.yGfkWu0M9X@thomas> From: David Marchand Date: Wed, 7 Jul 2021 12:40:36 +0200 Message-ID: To: Thomas Monjalon Cc: Andrew Rybchenko , Dodji Seketeli , Huisong Li , dev , "Yigit, Ferruh" , "Ananyev, Konstantin" , Ray Kinsella Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH V2] ethdev: add dev configured flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 7, 2021 at 11:59 AM Thomas Monjalon wrote: > > This is problematic, as the following rule does not work: > > > > +; Ignore bitfields added in rte_eth_dev_data hole > > +[suppress_type] > > + name = rte_eth_dev_data > > + has_data_member_inserted_between = {offset_after(lro), > > offset_of(rx_queue_state)} > > > > On the other hand, a (wrong) rule with "has_data_member_inserted_at = > > 2" (2 being the wrong offset you can read in abidiff output) works. > > > > This might force us to waive all changes to rte_eth_dev_data... not > > that I am happy about it. > > We are not going to do other changes until 21.11, so it could be fine. Ok, example of a global exception for the structure: +; Ignore all changes to rte_eth_dev_data +; Note: we only cared about dev_configured bit addition, but libabigail +; seems to wrongly compute bitfields offset. +; https://sourceware.org/bugzilla/show_bug.cgi?id=28060 +[suppress_type] + name = rte_eth_dev_data -- David Marchand