From: David Marchand <david.marchand@redhat.com>
To: Owen Hilyard <ohilyard@iol.unh.edu>
Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH v4] rib: fix max depth IPv6 lookup
Date: Thu, 24 Jun 2021 15:23:24 +0200 [thread overview]
Message-ID: <CAJFAV8zenpdEi6ySvpEmSMza_eKkrG3v-OZs_LCALnT9o5nyBw@mail.gmail.com> (raw)
In-Reply-To: <20210623151730.35276-1-ohilyard@iol.unh.edu>
On Wed, Jun 23, 2021 at 5:17 PM <ohilyard@iol.unh.edu> wrote:
>
> From: Owen Hilyard <ohilyard@iol.unh.edu>
>
> ASAN found a stack buffer overflow in lib/rib/rte_rib6.c:get_dir.
> The fix for the stack buffer overflow was to make sure depth
> was always < 128, since when depth = 128 it caused the index
> into the ip address to be 16, which read off the end of the array.
>
> While trying to solve the buffer overflow, I noticed that a few
> changes could be made to remove the for loop entirely.
>
> Fixes: f7e861e21c ("rib: support IPv6")
Updated sha1.
Cc: stable@dpdk.org
>
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Applied, thanks.
--
David Marchand
next prev parent reply other threads:[~2021-06-24 13:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 16:07 [dpdk-dev] [PATCH] lib/rte_rib6: fix stack buffer overflow ohilyard
2021-06-16 16:56 ` Stephen Hemminger
2021-06-16 17:27 ` Medvedkin, Vladimir
2021-06-16 18:18 ` [dpdk-dev] [PATCH v2] " ohilyard
2021-06-18 16:22 ` Medvedkin, Vladimir
2021-06-18 16:27 ` Medvedkin, Vladimir
2021-06-21 13:28 ` [dpdk-dev] [PATCH v3] " ohilyard
2021-06-22 7:10 ` David Marchand
2021-06-22 10:51 ` Medvedkin, Vladimir
2021-06-23 15:17 ` [dpdk-dev] [PATCH v4] rib: fix max depth IPv6 lookup ohilyard
2021-06-24 13:23 ` David Marchand [this message]
2021-06-24 9:01 ` [dpdk-dev] [PATCH v3] lib/rte_rib6: fix stack buffer overflow Medvedkin, Vladimir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zenpdEi6ySvpEmSMza_eKkrG3v-OZs_LCALnT9o5nyBw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ohilyard@iol.unh.edu \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.