Re: [dpdk-dev] [PATCH v1 1/1] vfio: add page-by-page mapping API

From: David Marchand <david.marchand@redhat.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>,
	 Ray Kinsella <mdr@ashroe.eu>,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	 Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	Dmitry Malloy <dmitrym@microsoft.com>,
	 Pallavi Kadam <pallavi.kadam@intel.com>,
	Xuan Ding <xuan.ding@intel.com>,
	 "Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 1/1] vfio: add page-by-page mapping API
Date: Thu, 28 Oct 2021 10:18:38 +0200	[thread overview]
Message-ID: <CAJFAV8zgi7H6n764_3MKDvgwh81T2sFrW7bLmz+b0x4rJ7zZVw@mail.gmail.com> (raw)
In-Reply-To: <9972054c-c68f-5b8c-d8cd-2330fce82369@intel.com>

On Wed, Sep 29, 2021 at 12:19 PM Burakov, Anatoly
<anatoly.burakov@intel.com> wrote:
> > @@ -2179,7 +2208,29 @@ rte_vfio_container_dma_map(int container_fd, uint64_t vaddr, uint64_t iova,
> >               return -1;
> >       }
> >
> > -     return container_dma_map(vfio_cfg, vaddr, iova, len);
> > +     /* not having page size means we map entire segment */
> > +     return container_dma_map(vfio_cfg, vaddr, iova, len, 0);
> > +}
> > +
> > +int
> > +rte_vfio_container_dma_map_paged(int container_fd, uint64_t vaddr,
> > +             uint64_t iova, uint64_t len, uint64_t pagesz)
> > +{
> > +     struct vfio_config *vfio_cfg;
> > +
> > +     if (len == 0 || pagesz == 0 || !rte_is_power_of_2(pagesz) ||
> > +                     (len % pagesz) != 0) {
>
> This should also check if VA/IOVA is page-aligned. Will fix in v2.

Can you send v2?
Thanks.

-- 
David Marchand