Re: [dpdk-dev] [PATCH 3/3] drivers: align log names

From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>, John Griffin <john.griffin@intel.com>,
	 Fiona Trahe <fiona.trahe@intel.com>,
	Deepak Kumar Jain <deepak.k.jain@intel.com>,
	 Ajit Khaparde <ajit.khaparde@broadcom.com>,
	 Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>,
	Vikas Gupta <vikas.gupta@broadcom.com>,
	 Rosen Xu <rosen.xu@intel.com>,
	Tianfei zhang <tianfei.zhang@intel.com>,
	 Bruce Richardson <bruce.richardson@intel.com>,
	Nipun Gupta <nipun.gupta@nxp.com>,
	 Hemant Agrawal <hemant.agrawal@nxp.com>,
	Xiao Wang <xiao.w.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH 3/3] drivers: align log names
Date: Fri, 19 Mar 2021 21:38:44 +0100	[thread overview]
Message-ID: <CAJFAV8zh3b05szyJbLxnbk7ncqNC2yyZ7bb4K9b+eZfq93P9pw@mail.gmail.com> (raw)
In-Reply-To: <5273226.FjvTQ7qL0s@thomas>

On Fri, Mar 19, 2021 at 6:15 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 19/03/2021 17:29, David Marchand:
> > On Wed, Mar 10, 2021 at 3:02 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > >
> > > The log levels are configured by using the name of the logs.
> > > Some drivers are aligned to follow a common log name standard:
> > >         pmd.class.driver[.sub]
> > > Some "common" drivers skip the "class" part:
> > >         pmd.driver.sub
> >
> > Without a check, this is likely to happen again.
> > I cooked this:
> [...]
> > +RTE_LOG_REGISTER(ixgbe_logtype_init, pmd.net.ixgb.init, NOTICE);
> > Added logtype does not comply with pattern: pmd.net.ixgbe
> > +RTE_LOG_REGISTER(compressdev_logtype, lib.compressde, NOTICE);
> > Added logtype does not comply with pattern: lib.compressdev
> >
> > WDYT?
>
> I cannot parse awk but it looks nice.
> And in general, have more tools is a good thing.
> Would you submit this tool as a patch?

http://inbox.dpdk.org/dev/20210319203737.13526-1-david.marchand@redhat.com/T/#u


-- 
David Marchand