From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E551C43219 for ; Fri, 3 May 2019 07:29:41 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 5A7F920B7C for ; Fri, 3 May 2019 07:29:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A7F920B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3045F2B98; Fri, 3 May 2019 09:29:40 +0200 (CEST) Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com [209.85.217.68]) by dpdk.org (Postfix) with ESMTP id 9DD252B95 for ; Fri, 3 May 2019 09:29:38 +0200 (CEST) Received: by mail-vs1-f68.google.com with SMTP id g187so2996903vsc.8 for ; Fri, 03 May 2019 00:29:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l+qs+iGDwyMhO7MXhN9H73pCIw5OwHRXWJEIiCZlnhM=; b=rC82LKJUswbshIaPdKc5tebf/Kzs0kyZroYK9lBJ8KS283SgRQuWyfDiUNSwWL8UQs IXJXCvl7nE5fBnDdzLDA49zhpomfx172BrkWCj+4TxkJF1KzOhtXfO+CyfEwA/dN4cdi WdjzFN7ClL2zYpHpfuucAfL2fl7p+ExqJtnCbVmfb1Ah25jP0sIr9hGH3KDZUTmqnId2 KjzFUH5Buza7UvvKksKICMhifb1GrRFH8dNKll7AlZzbaJsPg3Kj8qaYdur8K/trmXFN yfyz4vHAwG3eRctvsNMmanyP1fyd0XvQkYRXrSzp5Kh2fiYPXDf32fj3oXehVBpRlmI2 HnhQ== X-Gm-Message-State: APjAAAW7IvunxP9yywtrYTf2w/u3XGsbkDjGSrL0QeW99/eNn0GyJKyh ZmimBZf8fOCrCjo3eHCDMmhw2VJDpGLWQ0Dc6MnT2A== X-Google-Smtp-Source: APXvYqxAuTvoldR/M2//sGx28fczsn/J2zQtjJ38iBpgQZMsEod9QkSaGnQ5u7T4Pzk4KokNgw61/5+I2FoJSN46+ZQ= X-Received: by 2002:a67:a446:: with SMTP id p6mr4725347vsh.198.1556868578071; Fri, 03 May 2019 00:29:38 -0700 (PDT) MIME-Version: 1.0 References: <20190408182510.16078-1-stephen@networkplumber.org> <20190410171603.8979-1-stephen@networkplumber.org> <20190410171603.8979-5-stephen@networkplumber.org> In-Reply-To: <20190410171603.8979-5-stephen@networkplumber.org> From: David Marchand Date: Fri, 3 May 2019 09:29:27 +0200 Message-ID: To: Stephen Hemminger Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 4/5] examples/bond: use lcore accessor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Apr 10, 2019 at 7:16 PM Stephen Hemminger < stephen@networkplumber.org> wrote: > Referring to lcore_config directly is no longer recommended. > > Signed-off-by: Stephen Hemminger > --- > examples/bond/main.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/examples/bond/main.c b/examples/bond/main.c > index ef86194fff4a..b047ab23f01d 100644 > --- a/examples/bond/main.c > +++ b/examples/bond/main.c > @@ -526,8 +526,9 @@ static void cmd_start_parsed(__attribute__((unused)) > void *parsed_result, > int slave_core_id = rte_lcore_id(); > > rte_spinlock_trylock(&global_flag_stru_p->lock); > - if (global_flag_stru_p->LcoreMainIsRunning == 0) { > - if (lcore_config[global_flag_stru_p->LcoreMainCore].state > != WAIT) { > + if (global_flag_stru_p->LcoreMainIsRunning == 0) { > + if > (rte_eal_get_lcore_state(global_flag_stru_p->LcoreMainCore) > + != WAIT) { > rte_spinlock_unlock(&global_flag_stru_p->lock); > return; > } > -- > 2.17.1 > > Same comment than in v2, you missed another lcore_config in this file at line 800. -- David Marchand