From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D720CCA473 for ; Fri, 24 Jun 2022 12:42:09 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 940FA4069D; Fri, 24 Jun 2022 14:42:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 11B9D400EF for ; Fri, 24 Jun 2022 14:42:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656074526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Sreyo9UBRiLf22c+YchXzQvCiD6ZyRPSLSekdjLvQlI=; b=CM9RFliqr00Nup0kcab4DG9yoKR5+6B4heGJkrB/21iSvyOGWmYzzdyOQkY/c4HfyhFk7g Gyhaok92AC8Ja564cii9UPDVblCsD9swJjWUxRbpyo8ZpqhqWkVsCSPV82/AxAFHbwWxvq bofvvW4I1k1Mo8pfj8EqpYVDV7QoAHE= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-630-C2r97ejFNkSAQEwQFDTQGQ-1; Fri, 24 Jun 2022 08:42:05 -0400 X-MC-Unique: C2r97ejFNkSAQEwQFDTQGQ-1 Received: by mail-lj1-f200.google.com with SMTP id k12-20020a05651c10ac00b0025a73553415so262642ljn.5 for ; Fri, 24 Jun 2022 05:42:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Sreyo9UBRiLf22c+YchXzQvCiD6ZyRPSLSekdjLvQlI=; b=x5jGwOKSuEOQrpzKBIaOYxQIKg8mgFY1fKxovF/CXsKeXpy1Hw7j8gb+dEn+OQ+Z+k OIWX7Zg+jgPu386vNQYk0YxCVZwM71tNU/cgy/x1V6O56ABgVcPJHu6QHSpNfvOzULIe /vJ0sNeUEU04TfLbsrzYavmiGKh7ozhkBQzzKZrTEU6jMfVuGXID1XlnnQommkOW6khp AZzNPj4zzETf3Bs58fA0SFoYjybxMcAc6jZnme+bHnOE97GsVsBZ0V4b/rnxkxcFpHYq cUFrtW+CFpGpfefTSyCH/sBp6AZcPE/179btiIGLeMocAEjwNUbfLtiRS/Zrk0S2dJq4 uDrg== X-Gm-Message-State: AJIora+W/ILFpkpHsH56QmSoKozx2JxG6xVE9ybckKWHQq/ruAt2hdcS 0LTKD9Fkxb63+0DJVwS0k3hz5hiWey8pmXzdjW1Id5XuHr7dP52puqGxBz1FtHeBND2RziTqw41 c/v3Xc4XpueXqideWsCo= X-Received: by 2002:a05:651c:17a4:b0:259:d79:1d33 with SMTP id bn36-20020a05651c17a400b002590d791d33mr7390671ljb.477.1656074522575; Fri, 24 Jun 2022 05:42:02 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tc1V2p9aWBwG+Fj76mQyGGsKW99r81FoB62h5Vw4A3XxsBoNHq4fqOfSArLG6P2fbj8dQC45LggDBAXDGiS6U= X-Received: by 2002:a05:651c:17a4:b0:259:d79:1d33 with SMTP id bn36-20020a05651c17a400b002590d791d33mr7390614ljb.477.1656074520878; Fri, 24 Jun 2022 05:42:00 -0700 (PDT) MIME-Version: 1.0 References: <20220219234322.61309-1-stephen@networkplumber.org> <20220220182147.9750-1-stephen@networkplumber.org> In-Reply-To: <20220220182147.9750-1-stephen@networkplumber.org> From: David Marchand Date: Fri, 24 Jun 2022 14:41:49 +0200 Message-ID: Subject: Re: [PATCH v3 0/8] yet more unnecessary NULL checks To: Stephen Hemminger Cc: dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Feb 20, 2022 at 7:22 PM Stephen Hemminger wrote: > > Thomas suggested there are some other functions that could > use the nullfree cleanup; this covers the rest of the story. > > Note: this does not change existing API/ABI, there are still > some outliers that don't use the convention but fixing these > will have to wait until next LTS. > > v3 - fix another typo and add more functions > > v2 - fix spelling typo and add functions > > Stephen Hemminger (8): > cocci/nullfree: add more functions > acl: remove unnecessary null checks > lpm: remove unnecessary NULL checks > lib: document existing free functions > test: remove unnecessary NULL checks before free > fips_validation: remove unnecessary NULL check > event/sw: remove unnecessary NULL check > pipeline: remove unnecessary checks for NULL pointer before free Series applied. I reran the script and fixed two more instances. Thanks for the cleanup Stephen. -- David Marchand