From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29786C636CD for ; Fri, 10 Feb 2023 13:27:58 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F6C340EE6; Fri, 10 Feb 2023 14:27:57 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D2C3040687 for ; Fri, 10 Feb 2023 14:27:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676035675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qlkbqS4wxYHCkVXwBMuSEgdIGAQJTGcmlSlHBXLCNXA=; b=FceS0EkKamxf7SxTCyWb90SU7ss1tmdYn7kC3nlmHb3vMs58E/ltpT6Z6smIipuGU52NXP okzGtl0jmCfE/og1djg1PCyS7hRAmzpnXl88W5cYhNJxDjWlY+F756EH6Vtw5HMj53aC55 ygtwKS5fEHT6US1SJyZoGo3je3KndQM= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-615-Xkk-6VHtPW60Djvbbj4TgA-1; Fri, 10 Feb 2023 08:27:54 -0500 X-MC-Unique: Xkk-6VHtPW60Djvbbj4TgA-1 Received: by mail-pg1-f197.google.com with SMTP id f19-20020a631013000000b004e8c27fa528so2560258pgl.17 for ; Fri, 10 Feb 2023 05:27:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qlkbqS4wxYHCkVXwBMuSEgdIGAQJTGcmlSlHBXLCNXA=; b=MkjZVuvoC6avjGdleyknvM+9iNsDNWhPdR9wvcbNOU4YRN6DM5ZzpAvtkhxbiz4GWt wHMsy6Wq33WoME1x3nqLUvXtYtB9AgbdTqOyZOenTS8s3MpNVkcIozNqZZqp9EQtET9x NRLrujwtpVBFUIblGZ2tMrJf9txPfmnc5qLzd+rleBmzVj4+7V/Z2Y0HS3ymI4t54pWZ ynQXlLrcAUjUyqe/u2SDDztrfq+oEyOtQK8KlPO9ZviR29B4+f0JYxuTZ1+a8NzAt6GD 62vAzfHHSSdT6Spcc+KDeGdv0zq8+bLApBPbW2p4eHuQopjkntfxfq6YkfZdENGHHH/u oEfQ== X-Gm-Message-State: AO0yUKUbhL8iRb/sx8FGEc6N79eKjGrLzdwOJ67EB7M1X4gaRTEznaHh JMRwzS1rJH10VBdFV0HTABRzBhbQkv79n+TGhHZRyVuOKGS67kSpfqTXvpy5gXR2wF+QmSYrAwk qAonOfSuM74V5nuBImqY= X-Received: by 2002:a63:954c:0:b0:4f2:8007:5e1f with SMTP id t12-20020a63954c000000b004f280075e1fmr2869590pgn.58.1676035673421; Fri, 10 Feb 2023 05:27:53 -0800 (PST) X-Google-Smtp-Source: AK7set8xKBX53LAU8iflpcS/HOEvwXo2gOhEP21h6aij/PclpJa8VsfmeUzxeDdAzBVEbSGBb3y/v71WKb7MYabUyUQ= X-Received: by 2002:a63:954c:0:b0:4f2:8007:5e1f with SMTP id t12-20020a63954c000000b004f280075e1fmr2869587pgn.58.1676035673133; Fri, 10 Feb 2023 05:27:53 -0800 (PST) MIME-Version: 1.0 References: <20221123102612.1688865-1-rjarry@redhat.com> <20230209094354.1377424-1-rjarry@redhat.com> In-Reply-To: <20230209094354.1377424-1-rjarry@redhat.com> From: David Marchand Date: Fri, 10 Feb 2023 14:27:41 +0100 Message-ID: Subject: Re: [PATCH v10 0/5] lcore telemetry improvements To: Robin Jarry Cc: dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Kevin Laatz , Konstantin Ananyev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Robin, On Thu, Feb 9, 2023 at 10:45 AM Robin Jarry wrote: > > This is a follow up on previous work by Kevin Laatz: > > http://patches.dpdk.org/project/dpdk/list/?series=24658&state=* > > This series is aimed at allowing DPDK applications to expose their CPU > usage stats in the DPDK telemetry under /eal/lcore/info. This is a much > more basic and naive approach which leaves the cpu cycles accounting > completely up to the application. > > For reference, I have implemented a draft patch in OvS to use > rte_lcore_register_usage_cb() and report the already available busy > cycles information. > > https://github.com/rjarry/ovs/commit/643e672fe388e348ea7ccbbda6f5a87a066fd919 > > v10: > > - Code style fix > - Fixed reset of total_cycles while lcore is running > > v9: > > - Fixed changelog & version.map order. > - Updated with 64-bit integer telemetry functions. > - Refined docstrings (added notice about resetting the callback). > - Fixed accounting of total cycles in testpmd. > > Robin Jarry (5): > eal: add lcore info in telemetry > eal: report applications lcore usage > app/testpmd: add dump command for lcores > app/testpmd: report lcore usage > eal: add lcore usage telemetry endpoint > > app/test-pmd/cmdline.c | 3 + > app/test-pmd/noisy_vnf.c | 8 +- > app/test-pmd/testpmd.c | 44 +++- > app/test-pmd/testpmd.h | 25 ++- > doc/guides/rel_notes/release_23_03.rst | 8 + > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 + > lib/eal/common/eal_common_lcore.c | 222 ++++++++++++++++++-- > lib/eal/include/rte_lcore.h | 48 +++++ > lib/eal/version.map | 1 + > 9 files changed, 335 insertions(+), 31 deletions(-) > This last revision lgtm with an edit on patch 4 (one comment you missed from v9). Series applied, thanks. -- David Marchand