From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CCD9C4707E for ; Fri, 21 May 2021 22:26:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36D17601FD for ; Fri, 21 May 2021 22:26:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230060AbhEUW1y (ORCPT ); Fri, 21 May 2021 18:27:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229638AbhEUW1t (ORCPT ); Fri, 21 May 2021 18:27:49 -0400 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EFBAC0613CE for ; Fri, 21 May 2021 15:26:25 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id a11so21691513ioo.0 for ; Fri, 21 May 2021 15:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/XkWG9p3vuThMnzF5+jHBK0yD8kKyiYj1CsPVcIZG2k=; b=NbxYYDnKLkoxAba68BqL9ZpD3lb2ScBJAQcY7Ca85CXetGoTwjl6vkFeBlTcN0YXWC cakB/2NABQKb7tNbJ2MKqdWXSJWkXwDc/wdJ8H7ra+iLPE55/qTgRwSHMrd07MrYUY75 Kgl+MdH4q6qoh3P/D/eA9hwhI9aygyHy6++nMr5XZJFn3YbAGBkxb+ubQgrwI1dJD3OY 9vRWqUhp82BhFUfhdlge9Gw7weWCJYd2vfR0waS4FJhMBieNYCihC9+e4aQthIz0cPw7 nPcq/dSyh3TQ2iYZM3164IV6Hk3xNVVeEtw/KweHzEb/39DcVr+NmfeTkJfTD0gaB7bH HDpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/XkWG9p3vuThMnzF5+jHBK0yD8kKyiYj1CsPVcIZG2k=; b=rZmcJhEfDov4OTavZbj9VOm+8hA4FRlqoNc74jMSDyKKwq9dIvPWzPvQB62O5sMCFQ N7wpYRgUVH2qKmjbTs3f2mxPx9GZBg9/BGqGDH9uTvUwNMFt/wTrYr2FfOYiWbJ9IizM FohzEa6kC9MteiscOSoEIkYuHmhL8fOio54DZu0fuejKnzggtsRiyuvjHkem/WKtNgv0 qKifdUH/ugOs+FqE+YhLDwNH/BJA7EQ5Ku4yKSZHAJ1x1eBavVhiMDjSl5A0OaHhzphi EnAZ7x+4O0jI2uIXb8rOFVZTDt5ZwwaqvUInNgwDNoVKBpNkzX9aLj+s6nYtHanlmgxL Taaw== X-Gm-Message-State: AOAM531DN5mtVxHVkFUooN7lDc5JbilHePMX0g/zJujsAdBMUCsWdsCT VBOeXybBLIm/PG2MGj0Q2Be4bJce5OUas+IhaFpwpw== X-Google-Smtp-Source: ABdhPJzlwY4snWFXpxBlNWlDJVr5O/yWYAqwfXJReVJK7U77qf3035eHhy3r6Qq2WuRy8RNFs9VDtvKPjIC+Z+H1LKQ= X-Received: by 2002:a02:aa85:: with SMTP id u5mr7968024jai.75.1621635984233; Fri, 21 May 2021 15:26:24 -0700 (PDT) MIME-Version: 1.0 References: <20210521221211.29077-1-yu-cheng.yu@intel.com> <20210521221211.29077-14-yu-cheng.yu@intel.com> In-Reply-To: <20210521221211.29077-14-yu-cheng.yu@intel.com> From: Axel Rasmussen Date: Fri, 21 May 2021 15:25:47 -0700 Message-ID: Subject: Re: [PATCH v27 13/31] mm: Move VM_UFFD_MINOR_BIT from 37 to 38 To: Yu-cheng Yu Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , LKML , linux-doc@vger.kernel.org, Linux MM , linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang , Peter Xu Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This seems reasonable to me. The particular bit used isn't so important from my perspective. I can't think of a way this would break backward compatibility or such. So: Reviewed-by: Axel Rasmussen On Fri, May 21, 2021 at 3:13 PM Yu-cheng Yu wrote: > > To introduce VM_SHADOW_STACK as VM_HIGH_ARCH_BIT (37), and make all > VM_HIGH_ARCH_BITs stay together, move VM_UFFD_MINOR_BIT from 37 to 38. > > Signed-off-by: Yu-cheng Yu > Cc: Axel Rasmussen > Cc: Peter Xu > Cc: Mike Kravetz > --- > include/linux/mm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index c274f75efcf9..923f89b9f1b5 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -373,7 +373,7 @@ extern unsigned int kobjsize(const void *objp); > #endif > > #ifdef CONFIG_HAVE_ARCH_USERFAULTFD_MINOR > -# define VM_UFFD_MINOR_BIT 37 > +# define VM_UFFD_MINOR_BIT 38 > # define VM_UFFD_MINOR BIT(VM_UFFD_MINOR_BIT) /* UFFD minor faults */ > #else /* !CONFIG_HAVE_ARCH_USERFAULTFD_MINOR */ > # define VM_UFFD_MINOR VM_NONE > -- > 2.21.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99A11C04FF3 for ; Fri, 21 May 2021 22:26:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3EA4D601FD for ; Fri, 21 May 2021 22:26:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EA4D601FD Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BE3666B00F5; Fri, 21 May 2021 18:26:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B6BE28E0072; Fri, 21 May 2021 18:26:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 971CE6B00F7; Fri, 21 May 2021 18:26:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id 607C66B00F5 for ; Fri, 21 May 2021 18:26:26 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 03038181AEF3E for ; Fri, 21 May 2021 22:26:26 +0000 (UTC) X-FDA: 78166673172.38.88B2CB2 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by imf02.hostedemail.com (Postfix) with ESMTP id 08A2940B8CFE for ; Fri, 21 May 2021 22:26:23 +0000 (UTC) Received: by mail-io1-f52.google.com with SMTP id k132so8060618iof.4 for ; Fri, 21 May 2021 15:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/XkWG9p3vuThMnzF5+jHBK0yD8kKyiYj1CsPVcIZG2k=; b=NbxYYDnKLkoxAba68BqL9ZpD3lb2ScBJAQcY7Ca85CXetGoTwjl6vkFeBlTcN0YXWC cakB/2NABQKb7tNbJ2MKqdWXSJWkXwDc/wdJ8H7ra+iLPE55/qTgRwSHMrd07MrYUY75 Kgl+MdH4q6qoh3P/D/eA9hwhI9aygyHy6++nMr5XZJFn3YbAGBkxb+ubQgrwI1dJD3OY 9vRWqUhp82BhFUfhdlge9Gw7weWCJYd2vfR0waS4FJhMBieNYCihC9+e4aQthIz0cPw7 nPcq/dSyh3TQ2iYZM3164IV6Hk3xNVVeEtw/KweHzEb/39DcVr+NmfeTkJfTD0gaB7bH HDpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/XkWG9p3vuThMnzF5+jHBK0yD8kKyiYj1CsPVcIZG2k=; b=NRz5gF1DssE1qQjGup4rkqQzZuxFQRRh9e7amsI2fCEA6UTx2UkBYMSIGlqWaC1Glb Zf5adwLVbGO0eALGehXBwT3Q+gL0igZbsRYFpE8zJSESi0k4zmICmVZPgL9aLcL4VizB Md5blls5WMh7uHblYsbpUacJ1HZNMO2h0JciGmieDAMqU69QoT0pcOSstWgObUGlo4Hn 1qrrwsr6wKrEr5rbvSxoU9sTahIBVpcNcj3NGgcLQnDdGpro64Ko0Zo8h6bL+mIY4nLT FHRS4NENYSkRUvUM9fFI7d9lsyVmAAtI1RXknEIRg0sOAiFNdJFRhIiN9X1kbVcYPXVs MVEQ== X-Gm-Message-State: AOAM533qOJyKty7ZYj9JvGi6ozFhXSKj1jBbEI2thiDedizwR/LpiDmS C7aZSVwbFhNEsIoCmcCdbUnYlxbCfhhRZPdyB8bGYw== X-Google-Smtp-Source: ABdhPJzlwY4snWFXpxBlNWlDJVr5O/yWYAqwfXJReVJK7U77qf3035eHhy3r6Qq2WuRy8RNFs9VDtvKPjIC+Z+H1LKQ= X-Received: by 2002:a02:aa85:: with SMTP id u5mr7968024jai.75.1621635984233; Fri, 21 May 2021 15:26:24 -0700 (PDT) MIME-Version: 1.0 References: <20210521221211.29077-1-yu-cheng.yu@intel.com> <20210521221211.29077-14-yu-cheng.yu@intel.com> In-Reply-To: <20210521221211.29077-14-yu-cheng.yu@intel.com> From: Axel Rasmussen Date: Fri, 21 May 2021 15:25:47 -0700 Message-ID: Subject: Re: [PATCH v27 13/31] mm: Move VM_UFFD_MINOR_BIT from 37 to 38 To: Yu-cheng Yu Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , LKML , linux-doc@vger.kernel.org, Linux MM , linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang , Peter Xu Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 08A2940B8CFE Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=NbxYYDnK; spf=pass (imf02.hostedemail.com: domain of axelrasmussen@google.com designates 209.85.166.52 as permitted sender) smtp.mailfrom=axelrasmussen@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam04 X-Stat-Signature: sb87jr6rsgs68pgobhmgbhbbphu4hnom X-HE-Tag: 1621635983-631582 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This seems reasonable to me. The particular bit used isn't so important from my perspective. I can't think of a way this would break backward compatibility or such. So: Reviewed-by: Axel Rasmussen On Fri, May 21, 2021 at 3:13 PM Yu-cheng Yu wrote: > > To introduce VM_SHADOW_STACK as VM_HIGH_ARCH_BIT (37), and make all > VM_HIGH_ARCH_BITs stay together, move VM_UFFD_MINOR_BIT from 37 to 38. > > Signed-off-by: Yu-cheng Yu > Cc: Axel Rasmussen > Cc: Peter Xu > Cc: Mike Kravetz > --- > include/linux/mm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index c274f75efcf9..923f89b9f1b5 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -373,7 +373,7 @@ extern unsigned int kobjsize(const void *objp); > #endif > > #ifdef CONFIG_HAVE_ARCH_USERFAULTFD_MINOR > -# define VM_UFFD_MINOR_BIT 37 > +# define VM_UFFD_MINOR_BIT 38 > # define VM_UFFD_MINOR BIT(VM_UFFD_MINOR_BIT) /* UFFD minor faults */ > #else /* !CONFIG_HAVE_ARCH_USERFAULTFD_MINOR */ > # define VM_UFFD_MINOR VM_NONE > -- > 2.21.0 >