[U-Boot] [PATCH] arm: exynos: odroid: Fix the confict scripaddr extra env setting

From: Krzysztof Kozlowski <krzk@kernel.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: exynos: odroid: Fix the confict scripaddr extra env setting
Date: Wed, 29 May 2019 10:45:31 +0200	[thread overview]
Message-ID: <CAJKOXPc6oSq7CiiQuA+4m5OFL5eDor3Th54we2O7e05yg+Xv_g@mail.gmail.com> (raw)
In-Reply-To: <20190524085133.1261-1-linux.amoon@gmail.com>

On Fri, 24 May 2019 at 10:51, Anand Moon <linux.amoon@gmail.com> wrote:
>
> Fix the confict of scriptaddr address with ramdisk_addr_r used
> in EXTRA_ENV_SETTINGS.
>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>

My comment from previous patch stays valid:
"... but there is no conflict in the first place. These addresses are
not used in the same time."

The patch does not harm but it is not correctly explained. There is no
issue so it is not a fix.

Best regards,
Krzysztof

>
> ---
> Prevoius patch:
>
> [0] https://marc.info/?l=u-boot&m=155411969503169&w=2
>
> changes from prevoius changes:
> drop:  "pxefile_addr_r=0x51000000\0" \
>
> U-Boot 2019.07-rc2-00199-g40920bdecc4-dirty (May 24 2019 - 06:39:42 +0000)
>
> CPU:   Exynos4412 @ 1 GHz
> Model: Odroid based on Exynos4412
> Type:  u3
> DRAM:  2 GiB
> LDO20 at VDDQ_EMMC_1.8V: set 1800000 uV; enabling
> LDO22 at VDDQ_EMMC_2.8V: set 2800000 uV; enabling
> LDO21 at TFLASH_2.8V: set 2800000 uV; enabling
> MMC:   SAMSUNG SDHCI: 1, EXYNOS DWMMC: 0
> Loading Environment from MMC... Card did not respond to voltage select!
> *** Warning - No block device, using default environment
>
> Net:   No ethernet found.
> Hit any key to stop autoboot:  0
> switch to partitions #0, OK
> mmc1 is current device
> Scanning mmc 1:1...
> Found U-Boot script /boot/boot.scr
> 775 bytes read in 5 ms (151.4 KiB/s)
> 6688712 bytes read in 229 ms (27.9 MiB/s)
> 72645 bytes read in 41 ms (1.7 MiB/s)
> 6611360 bytes read in 227 ms (27.8 MiB/s)
> Kernel image @ 0x41000000 [ 0x000000 - 0x660fc8 ]
>    Booting using the fdt blob at 0x40800000
>    Loading Ramdisk to 4f9b1000, end 4ffff1a0 ... OK
>    Loading Device Tree to 4f99c000, end 4f9b0bc4 ... OK
> ---
>  include/configs/odroid.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/odroid.h b/include/configs/odroid.h
> index 9f2d43e3fa3..04bed6b0160 100644
> --- a/include/configs/odroid.h
> +++ b/include/configs/odroid.h
> @@ -168,7 +168,7 @@
>         "consoleoff=set console console=ram; save; reset\0" \
>         "initrdname=uInitrd\0" \
>         "ramdisk_addr_r=0x42000000\0" \
> -       "scriptaddr=0x42000000\0" \
> +       "scriptaddr=0x50000000\0" \
>         "fdt_addr_r=0x40800000\0" \
>         "kernel_addr_r=0x41000000\0" \
>         BOOTENV
> --
> 2.21.0
>