From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AB8JxZpcCeq+LFpce+aznXhvh13Sv7NeqD9glCGBq7bzI+qK5bveuOUM59lEoIFd3+JAvxJ2UYDQ ARC-Seal: i=1; a=rsa-sha256; t=1526301792; cv=none; d=google.com; s=arc-20160816; b=slVqMsD1Po0VaHpyq+1YyaZGonS1DqTojPACwT+RN1o/lkO0riLNmzYoT9S2NV+Usi UAItt9gEA8bfRgatOIRW9nlqKzv28gktfjotMSZMpY/ai+1REzWzYFfaGjO1xj21n2+K fBBCeUUkAiTdlS2abqzhIzm4hmSyadBKQKs37THt0c06auaLkco22DmjAibMuvBiA+5+ 0Bswg1XAnTeTjHSMccrHv4K49sf4MFxjvo8U/QC777VHH0Tw48hMJkVSTeJSg/UT5u5k D56wFKt7Ex6fyfau4RGM+AYu6JldhqM/L2wRwzyEITw631U/CHhbd95K4XhuDliyR94L 0R4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:dkim-signature:arc-authentication-results; bh=mM8EKbDi/AxuTUm9qt152qMc6J+eoGzWj40FKsnNz6o=; b=G7wnvSEKctcOQ+GHdCJ4xdB1OcNrh/MSzOCqckWEpO7xfA17QRseM36tqbqw1/rmJ5 2jzng0mk/3Fll0QwbgkhqUkTGjIz9m70/7aGw2XuHt654xTYDhxynpOcL0dSVHwnElEW 38JcNFod0/adT6Bom0rvUgg6+TQt9oggn4cwlAccsjHCXNfaJP33InDBxNpafNfdU0fP 3Wf3xLsFf8mr0ysT+ug5++pjui1WG5V8zXgfaVTzzS6rdT6XU3dIIn/Zr5SUWY4SrbaX mnjkwHVWbih0+zIo/m6CR5HTJH8HLU03wwL1WXK7i60jN/9HSS+inw5IQ4chZ258XneY /0Ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Vdjhn275; spf=pass (google.com: domain of krzk@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=krzk@kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Vdjhn275; spf=pass (google.com: domain of krzk@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=krzk@kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org MIME-Version: 1.0 In-Reply-To: References: From: Krzysztof Kozlowski Date: Mon, 14 May 2018 14:43:09 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [FAIL bisect] Sound card probe error To: Ulf Hansson Cc: Sylwester Nawrocki , Greg Kroah-Hartman , "Rafael J. Wysocki" , Marek Szyprowski , Mark Brown , Inki Dae , "linux-samsung-soc@vger.kernel.org" , Linux Kernel Mailing List , Linux ARM , Andrzej Hajda Content-Type: text/plain; charset="UTF-8" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1600434255100788752?= X-GMAIL-MSGID: =?utf-8?q?1600443427584743615?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, May 14, 2018 at 2:30 PM, Ulf Hansson wrote: > On 14 May 2018 at 14:22, Sylwester Nawrocki wrote: >> Hi, >> >> On 05/14/2018 12:17 PM, Krzysztof Kozlowski wrote: >> >>> Bisected to: >>> 8c123c14bbba4add148536b6d47a9226deda2f7a is the first bad commit >>> commit 8c123c14bbba4add148536b6d47a9226deda2f7a >>> Author: Ulf Hansson >>> Date: Thu Apr 26 10:53:06 2018 +0200 >>> >>> driver core: Respect all error codes from dev_pm_domain_attach() >>> >>> The limitation of being able to check only for -EPROBE_DEFER from >>> dev_pm_domain_attach() has been removed. Hence let's respect all error >>> codes and bail out accordingly. >>> >>> Signed-off-by: Ulf Hansson >>> Acked-by: Greg Kroah-Hartman >>> Signed-off-by: Rafael J. Wysocki >> >> The DRM driver creates the HDMI codec but its registration fails, due >> to some missing clocks. The clock are missing because the exynos5-subcmu >> driver probing fails. >> >> [ 0.678578] exynos5-subcmu: probe of GSC failed with error -17 >> [ 0.679250] exynos5-subcmu: probe of MFC failed with error -17 >> [ 0.679992] exynos5-subcmu: probe of DISP failed with error -17 >> >> The exynos5-subcmu driver before registering platform device makes >> of_genpd_add_device() call, so in platform_drv_probe() dev_pm_domain_attach() >> call will fail, as dev->pm_domain is already set. Previously the error >> was masked by code removed in the above commit and platform_drv_probe() >> was could complete successfully. > > Thanks for providing this information! > > I was about to tell that I overlooked the fact that there is more than > one way to assign PM domain pointers to devices. To fix the problem, > dev_pm_domain_attach() should return 0, not -EEXIST when it finds and > existing PM domain pointer. > > Does the below patch fix the problem? > > From: Ulf Hansson > Date: Mon, 14 May 2018 14:26:16 +0200 > Subject: [PATCH] PM / Domains: Don't return -EEXIST at attach when PM domain > exists > > As dev_pm_domain_attach() isn't the only way to assign PM domain pointers > to devices, clearly we must allow a device to have the pointer already > being assigned. For this reason, return 0 instead of -EEXIST. > > Reported-by: Krzysztof Kozlowski > Signed-off-by: Ulf Hansson > --- > drivers/base/power/common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Yes, this fixes the issue. Tested-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: krzk@kernel.org (Krzysztof Kozlowski) Date: Mon, 14 May 2018 14:43:09 +0200 Subject: [FAIL bisect] Sound card probe error In-Reply-To: References: Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, May 14, 2018 at 2:30 PM, Ulf Hansson wrote: > On 14 May 2018 at 14:22, Sylwester Nawrocki wrote: >> Hi, >> >> On 05/14/2018 12:17 PM, Krzysztof Kozlowski wrote: >> >>> Bisected to: >>> 8c123c14bbba4add148536b6d47a9226deda2f7a is the first bad commit >>> commit 8c123c14bbba4add148536b6d47a9226deda2f7a >>> Author: Ulf Hansson >>> Date: Thu Apr 26 10:53:06 2018 +0200 >>> >>> driver core: Respect all error codes from dev_pm_domain_attach() >>> >>> The limitation of being able to check only for -EPROBE_DEFER from >>> dev_pm_domain_attach() has been removed. Hence let's respect all error >>> codes and bail out accordingly. >>> >>> Signed-off-by: Ulf Hansson >>> Acked-by: Greg Kroah-Hartman >>> Signed-off-by: Rafael J. Wysocki >> >> The DRM driver creates the HDMI codec but its registration fails, due >> to some missing clocks. The clock are missing because the exynos5-subcmu >> driver probing fails. >> >> [ 0.678578] exynos5-subcmu: probe of GSC failed with error -17 >> [ 0.679250] exynos5-subcmu: probe of MFC failed with error -17 >> [ 0.679992] exynos5-subcmu: probe of DISP failed with error -17 >> >> The exynos5-subcmu driver before registering platform device makes >> of_genpd_add_device() call, so in platform_drv_probe() dev_pm_domain_attach() >> call will fail, as dev->pm_domain is already set. Previously the error >> was masked by code removed in the above commit and platform_drv_probe() >> was could complete successfully. > > Thanks for providing this information! > > I was about to tell that I overlooked the fact that there is more than > one way to assign PM domain pointers to devices. To fix the problem, > dev_pm_domain_attach() should return 0, not -EEXIST when it finds and > existing PM domain pointer. > > Does the below patch fix the problem? > > From: Ulf Hansson > Date: Mon, 14 May 2018 14:26:16 +0200 > Subject: [PATCH] PM / Domains: Don't return -EEXIST at attach when PM domain > exists > > As dev_pm_domain_attach() isn't the only way to assign PM domain pointers > to devices, clearly we must allow a device to have the pointer already > being assigned. For this reason, return 0 instead of -EEXIST. > > Reported-by: Krzysztof Kozlowski > Signed-off-by: Ulf Hansson > --- > drivers/base/power/common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Yes, this fixes the issue. Tested-by: Krzysztof Kozlowski Best regards, Krzysztof