From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54027C2D0A7 for ; Thu, 3 Sep 2020 20:37:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3173D20678 for ; Thu, 3 Sep 2020 20:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599165430; bh=1SAc/pkQ+YvF2FbSZWmb9yACOrCSFl+Cocz2H8qQb9s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=qn1UoNjbi45YX/LqhyElkNf2cDSx2lh4jkZjyBuQLK2XqB6gPUp4pafESH6nd/42g jmSyDy9aLNI7pTA2XDaj51GyZe7KLcwRIzWn3tdyyv2aEqajl310fi1nIhGqfD7Ycn T9R0kj0N+ETHi0tyHP2cZ9kjdhV/T1TBonpLss9A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729743AbgICUhF (ORCPT ); Thu, 3 Sep 2020 16:37:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:45432 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729406AbgICUgr (ORCPT ); Thu, 3 Sep 2020 16:36:47 -0400 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D424320678; Thu, 3 Sep 2020 20:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599165407; bh=1SAc/pkQ+YvF2FbSZWmb9yACOrCSFl+Cocz2H8qQb9s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=GBkpHkU2mNLKVOS/n/yqttR70A8MEzwnA9pn1u05EHDkX4XcWUSfUVZkx7ThPoXOc cOmPUjFm5o0MmRK6kvTOhILNt0h3An0CEiW3YsoWfXt110ZrjP+Rf5jCjnm4Fnjs87 8Ex/F7hfg91BygIg8YxrY4JHq3CyVTmZXo0DMmAU= Received: by mail-ed1-f50.google.com with SMTP id n13so3986700edo.10; Thu, 03 Sep 2020 13:36:46 -0700 (PDT) X-Gm-Message-State: AOAM531RyyFbMZHaVev3FRsiSj78+oZplZI5pzwkXEHdj54bfStT7xvX IwnnzOI/aH30WIeGWD6dLzj7HecBOfF1rMCvpsI= X-Google-Smtp-Source: ABdhPJzxpPlGTe4YpW+4SBi3UyLCfVVsjl/2HCF6ABdQkyPpZO/E8Ki7WEbnMMz1NKYFTDSRsOdBqsPbQLS79oRkX0c= X-Received: by 2002:a05:6402:1a48:: with SMTP id bf8mr5017832edb.298.1599165405346; Thu, 03 Sep 2020 13:36:45 -0700 (PDT) MIME-Version: 1.0 References: <20200829111800.2786-1-krzk@kernel.org> <20200829111800.2786-6-krzk@kernel.org> <20200903164117.GA2922218@bogus> In-Reply-To: <20200903164117.GA2922218@bogus> From: Krzysztof Kozlowski Date: Thu, 3 Sep 2020 22:36:34 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 6/7] dt-bindings: i2c: imx: Use unevaluatedProperties To: Rob Herring Cc: Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Anson Huang , Wolfram Sang , Dong Aisheng , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-kernel@vger.kernel.org" , linux-i2c@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Sep 2020 at 18:41, Rob Herring wrote: > > On Sat, Aug 29, 2020 at 01:17:59PM +0200, Krzysztof Kozlowski wrote: > > Additional properties actually might appear (e.g. power-domains or child > > nodes) so use unevaluatedProperties to fix dtbs_check warnings like: > > > > arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: i2c@30a20000: > > '#address-cells', '#size-cells', 'pmic@25' do not match any of the regexes: 'pinctrl-[0-9]+' > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > NAK. See https://lore.kernel.org/r/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mvQR-WKRnknQVtGGxQ@mail.gmail.com/ I can reference the generic i2c-controller schema and add missing properties but what to do with children (pmic@25 and many other)? I see that all of the other I2C controller dtschema files solve it by skipping "additionalProperties: false". Is this the way to go with I2C controllers? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE8DCC2D0A7 for ; Thu, 3 Sep 2020 20:46:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEA1820709 for ; Thu, 3 Sep 2020 20:46:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ij98dPys"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="GBkpHkU2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEA1820709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/TCFH+uhNniiQ8zoyRv1Zb/kFYNJulKDiY9Y/J/cDVY=; b=ij98dPys+f8UtgjKOK8kxGaVn mfdnHcktumooE6IY2Am25nIo0q14YmrDAC8Rz2FIxPykjHcVCAkaOrv3EXE702talPFXWyxeMpGFl yiU/hzGi3/G71ghW8SknvOAMlPgQeIz0kSRdfa0b6GejIuFAWorWrLZRwLyhxjFe5zOmj8g1fazP7 0P6hdjv9A48JL9jLsNisxdLePyzwMOBySevfGfSHf80NxXScmYRTC9eIrsLUvfLShsFutYhecJQwV F9yz+lHTxFjMeWX3a3kHM5HOfaYE3iW9q28GGrBkqMlqfYjV7Eu2y32CYCyAZOv9HmtZtMz+Ut13N wgMOXNsew==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDw5e-0003Ev-S7; Thu, 03 Sep 2020 20:44:14 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDvyS-0007jo-0O for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 20:36:49 +0000 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D6738208CA for ; Thu, 3 Sep 2020 20:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599165407; bh=1SAc/pkQ+YvF2FbSZWmb9yACOrCSFl+Cocz2H8qQb9s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=GBkpHkU2mNLKVOS/n/yqttR70A8MEzwnA9pn1u05EHDkX4XcWUSfUVZkx7ThPoXOc cOmPUjFm5o0MmRK6kvTOhILNt0h3An0CEiW3YsoWfXt110ZrjP+Rf5jCjnm4Fnjs87 8Ex/F7hfg91BygIg8YxrY4JHq3CyVTmZXo0DMmAU= Received: by mail-ed1-f41.google.com with SMTP id a12so3959170eds.13 for ; Thu, 03 Sep 2020 13:36:46 -0700 (PDT) X-Gm-Message-State: AOAM5317dL7tSMSqIYDYcalHShWMkoGeZaNLuph27uqd9hPG77uClf4X UT0RXJRD9MAIJfOBhop2Ni5zK17MhtcPykakjvg= X-Google-Smtp-Source: ABdhPJzxpPlGTe4YpW+4SBi3UyLCfVVsjl/2HCF6ABdQkyPpZO/E8Ki7WEbnMMz1NKYFTDSRsOdBqsPbQLS79oRkX0c= X-Received: by 2002:a05:6402:1a48:: with SMTP id bf8mr5017832edb.298.1599165405346; Thu, 03 Sep 2020 13:36:45 -0700 (PDT) MIME-Version: 1.0 References: <20200829111800.2786-1-krzk@kernel.org> <20200829111800.2786-6-krzk@kernel.org> <20200903164117.GA2922218@bogus> In-Reply-To: <20200903164117.GA2922218@bogus> From: Krzysztof Kozlowski Date: Thu, 3 Sep 2020 22:36:34 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 6/7] dt-bindings: i2c: imx: Use unevaluatedProperties To: Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_163648_311570_2893B0E5 X-CRM114-Status: GOOD ( 18.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dong Aisheng , devicetree@vger.kernel.org, Anson Huang , Stephen Boyd , Shawn Guo , Michael Turquette , "linux-kernel@vger.kernel.org" , linux-clk@vger.kernel.org, Wolfram Sang , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , Sascha Hauer , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 3 Sep 2020 at 18:41, Rob Herring wrote: > > On Sat, Aug 29, 2020 at 01:17:59PM +0200, Krzysztof Kozlowski wrote: > > Additional properties actually might appear (e.g. power-domains or child > > nodes) so use unevaluatedProperties to fix dtbs_check warnings like: > > > > arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: i2c@30a20000: > > '#address-cells', '#size-cells', 'pmic@25' do not match any of the regexes: 'pinctrl-[0-9]+' > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > NAK. See https://lore.kernel.org/r/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mvQR-WKRnknQVtGGxQ@mail.gmail.com/ I can reference the generic i2c-controller schema and add missing properties but what to do with children (pmic@25 and many other)? I see that all of the other I2C controller dtschema files solve it by skipping "additionalProperties: false". Is this the way to go with I2C controllers? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel