From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85F09C2BA19 for ; Wed, 15 Apr 2020 12:03:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6030620575 for ; Wed, 15 Apr 2020 12:03:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586952208; bh=wuXS7RCUYgyS51p4SeDx49zy51VkJGb5/qdr8yBZ0d4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=kLa5ueD6clyavv4bKM+Zii9ZX2Tov4xSgvUmcmaMavXJoLT+HGQykyva6nuBlnC7j 1bc876+1JxrN9eKi+R7g8nUAIdr3rR3HKeUCZ9RHFCt5JenZtEqsDA5fVia67KXFCG HqyNfKHnElTlBVil200e4ZXZNY6A+YGcINTtxtBg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S368248AbgDOMDZ (ORCPT ); Wed, 15 Apr 2020 08:03:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:45652 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406447AbgDOLt6 (ORCPT ); Wed, 15 Apr 2020 07:49:58 -0400 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4691F21744; Wed, 15 Apr 2020 11:49:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586951397; bh=wuXS7RCUYgyS51p4SeDx49zy51VkJGb5/qdr8yBZ0d4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=xeYP5cgafRPn6YhT6fu/+txsms6Rtv2DIovKV6n2lrE++374gHweZw442o4eW6zsC 0QPce/mOtpt2CYbuX3ZFAnyYNI2ZEwjJnhtikf8CEIIN6kqNvsnWY7Mv65g7qt/ye7 uxrNjWBorfjR3nRfrgurBt9sUOOix1lQMqGuSVeE= Received: by mail-lj1-f172.google.com with SMTP id l14so3320926ljj.5; Wed, 15 Apr 2020 04:49:57 -0700 (PDT) X-Gm-Message-State: AGi0PuZjsKu6zf8LL5CFFTykBFz9Ow4IvwbcDnVlR60DqUO+zLPg55Wi Mn3f2JxQvMpWmfYUIWCrwd9HLJrKBdE/jlykFDA= X-Google-Smtp-Source: APiQypJ6JgZvNxuPA2SlFZq3seBA6kaFPbk0RkqFDGIpIMdWvmYwpqEO8cmLBYYdZ/c1p1IHSS++MGMZGzTZDC6zHHI= X-Received: by 2002:a2e:9845:: with SMTP id e5mr3131512ljj.201.1586951395296; Wed, 15 Apr 2020 04:49:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Krzysztof Kozlowski Date: Wed, 15 Apr 2020 13:49:44 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node To: "H. Nikolaus Schaller" Cc: David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Paul Cercueil , Ralf Baechle , Paul Burton , James Hogan , Kukjin Kim , Maxime Ripard , Chen-Yu Tsai , Thomas Bogendoerfer , Philipp Rossak , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-omap@vger.kernel.org, openpvrsgx-devgroup@letux.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , Jonathan Bakker Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller wrote: > > From: Jonathan Bakker > > to add support for SGX540 GPU. Do not continue the subject in commit msg like it is one sentence. These are two separate sentences, so commit msg starts with capital letter and it is sentence by itself. > Signed-off-by: Jonathan Bakker > Signed-off-by: H. Nikolaus Schaller > --- > arch/arm/boot/dts/s5pv210.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi > index 2ad642f51fd9..e7fc709c0cca 100644 > --- a/arch/arm/boot/dts/s5pv210.dtsi > +++ b/arch/arm/boot/dts/s5pv210.dtsi > @@ -512,6 +512,21 @@ vic3: interrupt-controller@f2300000 { > #interrupt-cells = <1>; > }; > > + g3d: g3d@f3000000 { > + compatible = "samsung,s5pv210-sgx540-120"; > + reg = <0xf3000000 0x10000>; > + interrupt-parent = <&vic2>; > + interrupts = <10>; > + clock-names = "sclk"; > + clocks = <&clocks CLK_G3D>; Not part of bindings, please remove or add to the bindings. > + > + power-domains = <&pd S5PV210_PD_G3D>; Ditto > + > + assigned-clocks = <&clocks MOUT_G3D>, <&clocks DOUT_G3D>; > + assigned-clock-rates = <0>, <66700000>; > + assigned-clock-parents = <&clocks MOUT_MPLL>; Probably this should have status disabled because you do not set regulator supply. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06359C2BA19 for ; Wed, 15 Apr 2020 11:53:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6666206A2 for ; Wed, 15 Apr 2020 11:53:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JgMyGW4B"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="xeYP5cga" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6666206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DUJ5UFSoGm6M1CDGa982mov4O8NtZuCL2+l3RKo4BP8=; b=JgMyGW4B5UfHVt F2h0NU1+w2VAdXZq0XX8WMxWAYR4WuWl4giPATkg4GsdyMvgD00JEQato3SMud9h4RN180O+kGmwE eXhrCZekB09cBXskQvI9AsB9Gv0YbPHiDXMXAfKb3Y9D+jbNfBePFS/CMQkF1BqRkvHQzTRpsovxC LgOun+BHY8U7zHK2wfSg1EG0y4kWPoFe2dT4HzIg5R0hiCLUkUbPxIViCbQw34lslbsyNYWmPpHuP LA3c2qR0HuG4Zccm69iOA1n1PtqrvV1fTrkZzbDkLYDPk0X3v7yImQzBzavT0ccQCSButXwqhqQcw eDw5mJ7Zb4SWwlLob0jw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOgbW-0005IJ-EE; Wed, 15 Apr 2020 11:53:18 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOgYI-0008TY-KE for linux-arm-kernel@lists.infradead.org; Wed, 15 Apr 2020 11:50:00 +0000 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C2D221835 for ; Wed, 15 Apr 2020 11:49:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586951397; bh=wuXS7RCUYgyS51p4SeDx49zy51VkJGb5/qdr8yBZ0d4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=xeYP5cgafRPn6YhT6fu/+txsms6Rtv2DIovKV6n2lrE++374gHweZw442o4eW6zsC 0QPce/mOtpt2CYbuX3ZFAnyYNI2ZEwjJnhtikf8CEIIN6kqNvsnWY7Mv65g7qt/ye7 uxrNjWBorfjR3nRfrgurBt9sUOOix1lQMqGuSVeE= Received: by mail-lj1-f177.google.com with SMTP id u6so1718600ljl.6 for ; Wed, 15 Apr 2020 04:49:57 -0700 (PDT) X-Gm-Message-State: AGi0PuZO5hj/lPaoFk3LfudW9jPShUvHU+zoJexd5ZpH+nwbkAt6THwA hR/CUgSGfNDKMzB0D6nTObh1KmR864eqqMfo8es= X-Google-Smtp-Source: APiQypJ6JgZvNxuPA2SlFZq3seBA6kaFPbk0RkqFDGIpIMdWvmYwpqEO8cmLBYYdZ/c1p1IHSS++MGMZGzTZDC6zHHI= X-Received: by 2002:a2e:9845:: with SMTP id e5mr3131512ljj.201.1586951395296; Wed, 15 Apr 2020 04:49:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Krzysztof Kozlowski Date: Wed, 15 Apr 2020 13:49:44 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node To: "H. Nikolaus Schaller" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200415_044958_791870_23464B40 X-CRM114-Status: GOOD ( 18.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Airlie , James Hogan , Jonathan Bakker , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, Paul Cercueil , "linux-samsung-soc@vger.kernel.org" , linux-omap@vger.kernel.org, Paul Burton , Tony Lindgren , Chen-Yu Tsai , Kukjin Kim , devicetree@vger.kernel.org, =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Maxime Ripard , Rob Herring , letux-kernel@openphoenux.org, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Philipp Rossak , openpvrsgx-devgroup@letux.org, "linux-kernel@vger.kernel.org" , Ralf Baechle , Daniel Vetter , kernel@pyra-handheld.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller wrote: > > From: Jonathan Bakker > > to add support for SGX540 GPU. Do not continue the subject in commit msg like it is one sentence. These are two separate sentences, so commit msg starts with capital letter and it is sentence by itself. > Signed-off-by: Jonathan Bakker > Signed-off-by: H. Nikolaus Schaller > --- > arch/arm/boot/dts/s5pv210.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi > index 2ad642f51fd9..e7fc709c0cca 100644 > --- a/arch/arm/boot/dts/s5pv210.dtsi > +++ b/arch/arm/boot/dts/s5pv210.dtsi > @@ -512,6 +512,21 @@ vic3: interrupt-controller@f2300000 { > #interrupt-cells = <1>; > }; > > + g3d: g3d@f3000000 { > + compatible = "samsung,s5pv210-sgx540-120"; > + reg = <0xf3000000 0x10000>; > + interrupt-parent = <&vic2>; > + interrupts = <10>; > + clock-names = "sclk"; > + clocks = <&clocks CLK_G3D>; Not part of bindings, please remove or add to the bindings. > + > + power-domains = <&pd S5PV210_PD_G3D>; Ditto > + > + assigned-clocks = <&clocks MOUT_G3D>, <&clocks DOUT_G3D>; > + assigned-clock-rates = <0>, <66700000>; > + assigned-clock-parents = <&clocks MOUT_MPLL>; Probably this should have status disabled because you do not set regulator supply. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEC3CC2BA19 for ; Wed, 15 Apr 2020 11:49:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85BB420732 for ; Wed, 15 Apr 2020 11:49:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="xeYP5cga" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85BB420732 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 19F096E9AE; Wed, 15 Apr 2020 11:49:58 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id A45146E9AE for ; Wed, 15 Apr 2020 11:49:57 +0000 (UTC) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 373112166E for ; Wed, 15 Apr 2020 11:49:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586951397; bh=wuXS7RCUYgyS51p4SeDx49zy51VkJGb5/qdr8yBZ0d4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=xeYP5cgafRPn6YhT6fu/+txsms6Rtv2DIovKV6n2lrE++374gHweZw442o4eW6zsC 0QPce/mOtpt2CYbuX3ZFAnyYNI2ZEwjJnhtikf8CEIIN6kqNvsnWY7Mv65g7qt/ye7 uxrNjWBorfjR3nRfrgurBt9sUOOix1lQMqGuSVeE= Received: by mail-lj1-f171.google.com with SMTP id l14so3320924ljj.5 for ; Wed, 15 Apr 2020 04:49:57 -0700 (PDT) X-Gm-Message-State: AGi0PuaJ/0s+Z5tvsIrPtzS0WC7xjC7fWaUIZHY6+uKU7fuy9vLQtth2 JdG8B1BXoiztaVcybjlaPpSjujZ4KFvLeppUBrg= X-Google-Smtp-Source: APiQypJ6JgZvNxuPA2SlFZq3seBA6kaFPbk0RkqFDGIpIMdWvmYwpqEO8cmLBYYdZ/c1p1IHSS++MGMZGzTZDC6zHHI= X-Received: by 2002:a2e:9845:: with SMTP id e5mr3131512ljj.201.1586951395296; Wed, 15 Apr 2020 04:49:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Krzysztof Kozlowski Date: Wed, 15 Apr 2020 13:49:44 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node To: "H. Nikolaus Schaller" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Airlie , James Hogan , Jonathan Bakker , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, Paul Cercueil , "linux-samsung-soc@vger.kernel.org" , linux-omap@vger.kernel.org, Paul Burton , Tony Lindgren , Chen-Yu Tsai , Kukjin Kim , devicetree@vger.kernel.org, =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Rob Herring , letux-kernel@openphoenux.org, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Philipp Rossak , openpvrsgx-devgroup@letux.org, "linux-kernel@vger.kernel.org" , Ralf Baechle , kernel@pyra-handheld.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller wrote: > > From: Jonathan Bakker > > to add support for SGX540 GPU. Do not continue the subject in commit msg like it is one sentence. These are two separate sentences, so commit msg starts with capital letter and it is sentence by itself. > Signed-off-by: Jonathan Bakker > Signed-off-by: H. Nikolaus Schaller > --- > arch/arm/boot/dts/s5pv210.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi > index 2ad642f51fd9..e7fc709c0cca 100644 > --- a/arch/arm/boot/dts/s5pv210.dtsi > +++ b/arch/arm/boot/dts/s5pv210.dtsi > @@ -512,6 +512,21 @@ vic3: interrupt-controller@f2300000 { > #interrupt-cells = <1>; > }; > > + g3d: g3d@f3000000 { > + compatible = "samsung,s5pv210-sgx540-120"; > + reg = <0xf3000000 0x10000>; > + interrupt-parent = <&vic2>; > + interrupts = <10>; > + clock-names = "sclk"; > + clocks = <&clocks CLK_G3D>; Not part of bindings, please remove or add to the bindings. > + > + power-domains = <&pd S5PV210_PD_G3D>; Ditto > + > + assigned-clocks = <&clocks MOUT_G3D>, <&clocks DOUT_G3D>; > + assigned-clock-rates = <0>, <66700000>; > + assigned-clock-parents = <&clocks MOUT_MPLL>; Probably this should have status disabled because you do not set regulator supply. Best regards, Krzysztof _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel