From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B484C43215 for ; Thu, 21 Nov 2019 07:38:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E77612089D for ; Thu, 21 Nov 2019 07:38:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574321904; bh=iPaegC2Fc/YfqxXzQq+rKC4ut3oJhHjxsJHyhJOMr6o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=oMBs+RrOvbkwGHZmwq6jswFbScMS6kzyRmg7tnz/NlzBeGwUAQ5O1Qi2otSBcwFbm FYXNhVvScUnxHm7GBBUgaIFnT4+5foxUuw+Vj0dnVL9WpGo54yp0/+GPH1QxXgsmzb wYLBfV2v0xps5xhuk7YLguenDApaJoVLvWWtO4eo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726343AbfKUHiX (ORCPT ); Thu, 21 Nov 2019 02:38:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:40588 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726170AbfKUHiX (ORCPT ); Thu, 21 Nov 2019 02:38:23 -0500 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8E9672089F; Thu, 21 Nov 2019 07:38:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574321901; bh=iPaegC2Fc/YfqxXzQq+rKC4ut3oJhHjxsJHyhJOMr6o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Gxmr7hkqoqe4nozqTBM5oRmtM3cW053hJ1ImnHqQFqn1tLjOTuUcVPQFfefy/lrPK yeX0TKfwGDSz3ZuemTTnDzyMNjNySRvpFCGcqHoF/ttJLxHAHrHwH889CiGd6tCK0Y 3oa+LmP/JdwIg1SLH+4Bw3porGtIoT1wzexr5ExY= Received: by mail-lj1-f177.google.com with SMTP id g3so2014686ljl.11; Wed, 20 Nov 2019 23:38:21 -0800 (PST) X-Gm-Message-State: APjAAAUhvwKWD3iH1D8OJsUHN9o6gygBy/lOZPra62d2T2wbXQk9MyQ9 CMFLXS7sH+COC/i9fSOvPVA1oLx8E0LpHHWsr10= X-Google-Smtp-Source: APXvYqzIZSww42wLMbKd99lnRiuy4DvVWuQlpvBLqdlbdGUmZM2j6BMEs6rEqORD0iP6Pis5OViGamvZ0Ari2qlGhoY= X-Received: by 2002:a2e:3009:: with SMTP id w9mr6359832ljw.74.1574321899606; Wed, 20 Nov 2019 23:38:19 -0800 (PST) MIME-Version: 1.0 References: <001001d5a03d$05de1f70$119a5e50$@samsung.com> In-Reply-To: <001001d5a03d$05de1f70$119a5e50$@samsung.com> From: Krzysztof Kozlowski Date: Thu, 21 Nov 2019 15:38:08 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] pinctrl: samsung: modularize samsung pinctrl driver To: =?UTF-8?B?6rWs7ZiE6riw?= Cc: Tomasz Figa , s.nawrocki@samsung.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , linux-gpio@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi, Thanks for the patch. Few comments below: On Thu, 21 Nov 2019 at 15:26, =EA=B5=AC=ED=98=84=EA=B8=B0 wrote: > > Enable samsung pinctrl driver to be compiled as modules. Why? What's the benefit? Are platforms capable of such boot? Pinctrl is needed early - even before mounting rootfs... What about module unloading? Is it reasonable? Please answer to all this also in commit message. > > Change-Id: I92a9953c92831a316f7f50146898ff19831549ec This does not belong to Git. > Signed-off-by: Hyunki Koo You "From" name is different than written here in Signed-off-by. They should match and I do not know Korean to be able to tell whether they really match or not :). How about using Latin transliteration also in "From" field? > --- > drivers/pinctrl/samsung/Kconfig | 5 +---- > drivers/pinctrl/samsung/Makefile | 13 +++++++------ > drivers/pinctrl/samsung/pinctrl-exynos-arm.c | 2 ++ > drivers/pinctrl/samsung/pinctrl-exynos-arm64.c | 2 ++ > drivers/pinctrl/samsung/pinctrl-exynos.c | 2 ++ > drivers/pinctrl/samsung/pinctrl-samsung.c | 13 +++++++++++++ > 6 files changed, 27 insertions(+), 10 deletions(-) > > diff --git a/drivers/pinctrl/samsung/Kconfig > b/drivers/pinctrl/samsung/Kconfig > index 425fadd6c346..25e16984ef23 100644 > --- a/drivers/pinctrl/samsung/Kconfig > +++ b/drivers/pinctrl/samsung/Kconfig > @@ -3,14 +3,13 @@ > # Samsung Pin control drivers > # > config PINCTRL_SAMSUNG > - bool > + tristate "Pinctrl driver data for Samsung SoCs" > select PINMUX > select PINCONF > > config PINCTRL_EXYNOS > bool "Pinctrl driver data for Samsung EXYNOS SoCs" > depends on OF && GPIOLIB && (ARCH_EXYNOS || ARCH_S5PV210) > - select PINCTRL_SAMSUNG > select PINCTRL_EXYNOS_ARM if ARM && (ARCH_EXYNOS || ARCH_S5PV210) > select PINCTRL_EXYNOS_ARM64 if ARM64 && ARCH_EXYNOS > > @@ -25,9 +24,7 @@ config PINCTRL_EXYNOS_ARM64 > config PINCTRL_S3C24XX > bool "Samsung S3C24XX SoC pinctrl driver" > depends on ARCH_S3C24XX && OF > - select PINCTRL_SAMSUNG > > config PINCTRL_S3C64XX > bool "Samsung S3C64XX SoC pinctrl driver" > depends on ARCH_S3C64XX > - select PINCTRL_SAMSUNG > diff --git a/drivers/pinctrl/samsung/Makefile > b/drivers/pinctrl/samsung/Makefile > index ed951df6a112..b3ac01838b8a 100644 > --- a/drivers/pinctrl/samsung/Makefile > +++ b/drivers/pinctrl/samsung/Makefile > @@ -1,9 +1,10 @@ > # SPDX-License-Identifier: GPL-2.0 > # Samsung pin control drivers > > -obj-$(CONFIG_PINCTRL_SAMSUNG) +=3D pinctrl-samsung.o > -obj-$(CONFIG_PINCTRL_EXYNOS) +=3D pinctrl-exynos.o > -obj-$(CONFIG_PINCTRL_EXYNOS_ARM) +=3D pinctrl-exynos-arm.o > -obj-$(CONFIG_PINCTRL_EXYNOS_ARM64) +=3D pinctrl-exynos-arm64.o > -obj-$(CONFIG_PINCTRL_S3C24XX) +=3D pinctrl-s3c24xx.o > -obj-$(CONFIG_PINCTRL_S3C64XX) +=3D pinctrl-s3c64xx.o > +obj-$(CONFIG_PINCTRL_SAMSUNG) +=3D pinctrl-samsung-super.o > +pinctrl-samsung-super-$(CONFIG_PINCTRL_SAMSUNG) +=3D pinctrl-sams= ung.o > +pinctrl-samsung-super-$(CONFIG_PINCTRL_EXYNOS) +=3D pinctrl-exynos.o > +pinctrl-samsung-super-$(CONFIG_PINCTRL_EXYNOS_ARM) +=3D pinctrl-exyn= os- > arm.o > +pinctrl-samsung-super-$(CONFIG_PINCTRL_EXYNOS_ARM64) +=3D pinctrl-exyn= os- > arm64.o > +pinctrl-samsung-super-$(CONFIG_PINCTRL_S3C24XX) +=3D pinctrl-s3c2= 4xx.o > +pinctrl-samsung-super-$(CONFIG_PINCTRL_S3C64XX) +=3D pinctrl-s3c6= 4xx.o I don't get why you need to rename obj to pinctrl-samsung-super? > diff --git a/drivers/pinctrl/samsung/pinctrl-exynos-arm.c > b/drivers/pinctrl/samsung/pinctrl-exynos-arm.c > index 85ddf49a5188..28906bf213c4 100644 > --- a/drivers/pinctrl/samsung/pinctrl-exynos-arm.c > +++ b/drivers/pinctrl/samsung/pinctrl-exynos-arm.c > @@ -14,6 +14,7 @@ > // external gpio and wakeup interrupt support. > > #include > +#include > #include > #include > #include > @@ -891,3 +892,4 @@ const struct samsung_pinctrl_of_match_data > exynos5420_of_data __initconst =3D { > .ctrl =3D exynos5420_pin_ctrl, > .num_ctrl =3D ARRAY_SIZE(exynos5420_pin_ctrl), > }; > +MODULE_LICENSE("GPL"); > diff --git a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c > b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c > index b6e56422a700..2b19476ad5ff 100644 > --- a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c > +++ b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c > @@ -14,6 +14,7 @@ > // external gpio and wakeup interrupt support. > > #include > +#include > #include > > #include "pinctrl-samsung.h" > @@ -422,3 +423,4 @@ const struct samsung_pinctrl_of_match_data > exynos7_of_data __initconst =3D { > .ctrl =3D exynos7_pin_ctrl, > .num_ctrl =3D ARRAY_SIZE(exynos7_pin_ctrl), > }; > +MODULE_LICENSE("GPL"); > diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c > b/drivers/pinctrl/samsung/pinctrl-exynos.c > index ebc27b06718c..630d606330f1 100644 > --- a/drivers/pinctrl/samsung/pinctrl-exynos.c > +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -713,3 +714,4 @@ exynos_retention_init(struct samsung_pinctrl_drv_data > *drvdata, > > return ctrl; > } > +MODULE_LICENSE("GPL"); > diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c > b/drivers/pinctrl/samsung/pinctrl-samsung.c > index de0477bb469d..4483eaed27f8 100644 > --- a/drivers/pinctrl/samsung/pinctrl-samsung.c > +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c > @@ -15,6 +15,7 @@ > // but provides extensions to which platform specific implementation of > the gpio > // and wakeup interrupts can be hooked to. > > +#include > #include > #include > #include > @@ -1275,6 +1276,7 @@ static const struct of_device_id > samsung_pinctrl_dt_match[] =3D { > #endif > {}, > }; > +MODULE_DEVICE_TABLE(of, samsung_pinctrl_dt_match); > > static const struct dev_pm_ops samsung_pinctrl_pm_ops =3D { > SET_LATE_SYSTEM_SLEEP_PM_OPS(samsung_pinctrl_suspend, > @@ -1296,3 +1298,14 @@ static int __init samsung_pinctrl_drv_register(voi= d) > return platform_driver_register(&samsung_pinctrl_driver); > } > postcore_initcall(samsung_pinctrl_drv_register); > + > +static void __exit samsung_pinctrl_drv_unregister(void) > +{ > + platform_driver_unregister(&samsung_pinctrl_driver); > +} > +module_exit(samsung_pinctrl_drv_unregister); Since .suppress_bind_attrs are defined, I find it weird to be able to unload module... Another warning sign... > + > + > +MODULE_LICENSE("GPL"); > +MODULE_AUTHOR("Hyunki Koo "); I cannot find any contributions to this file from you. The author should be the main contributor(s). You need to go through history... > +MODULE_DESCRIPTION("Samsung Exynos PINCTRL driver"); That's not Exynos but Samsung-generic part... Samsung Exynos/S3C/S5P pinctrl driver. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BBE7C432C3 for ; Thu, 21 Nov 2019 07:38:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 646652089F for ; Thu, 21 Nov 2019 07:38:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DXBsDZ8E"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Gxmr7hkq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 646652089F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ItRcShNTynRnuDhFQlFud+cK460d9SSm66lYKFYLq50=; b=DXBsDZ8El75FGd Rn+bbeaku3jRT3kLEzA7Ogdqixud8XUb9a6cr1K9TU2xrJn81NrSuh2uoVXd2NVN0Bf89u/gpK3BO +XNQ6sFTvWl0pfx15i+bvUseZqkg9eR5Pr4k92LwdGeWis06pOiJcQmFxUd3sOG0kadGG5jnp94zQ jzsqkCqq6M0j6jiZ+U+FzR7D11K3rIfVz4aEjPQ8i+6gzklZHvCyIimcjs0kD2LrdNK+HDYxtiLbs pFkGy9JeW/8jXk6al7Rz67S3yhWdX+z7QDOR5FIEg2RcIAMrEwtFdmRv92qaydq1080VIi9gNxF8P c9Ja2BqrGGRBQctwsAUA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iXh2n-0006M8-R5; Thu, 21 Nov 2019 07:38:25 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iXh2k-0006LZ-93 for linux-arm-kernel@lists.infradead.org; Thu, 21 Nov 2019 07:38:24 +0000 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 838A520898 for ; Thu, 21 Nov 2019 07:38:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574321901; bh=iPaegC2Fc/YfqxXzQq+rKC4ut3oJhHjxsJHyhJOMr6o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Gxmr7hkqoqe4nozqTBM5oRmtM3cW053hJ1ImnHqQFqn1tLjOTuUcVPQFfefy/lrPK yeX0TKfwGDSz3ZuemTTnDzyMNjNySRvpFCGcqHoF/ttJLxHAHrHwH889CiGd6tCK0Y 3oa+LmP/JdwIg1SLH+4Bw3porGtIoT1wzexr5ExY= Received: by mail-lj1-f171.google.com with SMTP id y23so2025615ljh.10 for ; Wed, 20 Nov 2019 23:38:21 -0800 (PST) X-Gm-Message-State: APjAAAWI1MVJ8lkNm/WVOvzFh5rRNnYpn/aEHZVPq/Ov+MB0TeKTSvmn qIf7xvEN2MGEmS2T8qYlFxug6L269TVRYrX4nzs= X-Google-Smtp-Source: APXvYqzIZSww42wLMbKd99lnRiuy4DvVWuQlpvBLqdlbdGUmZM2j6BMEs6rEqORD0iP6Pis5OViGamvZ0Ari2qlGhoY= X-Received: by 2002:a2e:3009:: with SMTP id w9mr6359832ljw.74.1574321899606; Wed, 20 Nov 2019 23:38:19 -0800 (PST) MIME-Version: 1.0 References: <001001d5a03d$05de1f70$119a5e50$@samsung.com> In-Reply-To: <001001d5a03d$05de1f70$119a5e50$@samsung.com> From: Krzysztof Kozlowski Date: Thu, 21 Nov 2019 15:38:08 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] pinctrl: samsung: modularize samsung pinctrl driver To: =?UTF-8?B?6rWs7ZiE6riw?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191120_233822_355923_29290E75 X-CRM114-Status: GOOD ( 19.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-samsung-soc@vger.kernel.org" , linus.walleij@linaro.org, Tomasz Figa , "linux-kernel@vger.kernel.org" , linux-gpio@vger.kernel.org, s.nawrocki@samsung.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpUaGFua3MgZm9yIHRoZSBwYXRjaC4gRmV3IGNvbW1lbnRzIGJlbG93OgoKT24gVGh1LCAy MSBOb3YgMjAxOSBhdCAxNToyNiwg6rWs7ZiE6riwIDxoeXVua2kwMC5rb29Ac2Ftc3VuZy5jb20+ IHdyb3RlOgo+Cj4gRW5hYmxlIHNhbXN1bmcgcGluY3RybCBkcml2ZXIgdG8gYmUgY29tcGlsZWQg YXMgbW9kdWxlcy4KCldoeT8gV2hhdCdzIHRoZSBiZW5lZml0PyBBcmUgcGxhdGZvcm1zIGNhcGFi bGUgb2Ygc3VjaCBib290PyBQaW5jdHJsCmlzIG5lZWRlZCBlYXJseSAtIGV2ZW4gYmVmb3JlIG1v dW50aW5nIHJvb3Rmcy4uLgpXaGF0IGFib3V0IG1vZHVsZSB1bmxvYWRpbmc/IElzIGl0IHJlYXNv bmFibGU/ClBsZWFzZSBhbnN3ZXIgdG8gYWxsIHRoaXMgYWxzbyBpbiBjb21taXQgbWVzc2FnZS4K Cj4KPiBDaGFuZ2UtSWQ6IEk5MmE5OTUzYzkyODMxYTMxNmY3ZjUwMTQ2ODk4ZmYxOTgzMTU0OWVj CgpUaGlzIGRvZXMgbm90IGJlbG9uZyB0byBHaXQuCgo+IFNpZ25lZC1vZmYtYnk6IEh5dW5raSBL b28gPGh5dW5raTAwLmtvb0BzYW1zdW5nLmNvbT4KCllvdSAiRnJvbSIgbmFtZSBpcyBkaWZmZXJl bnQgdGhhbiB3cml0dGVuIGhlcmUgaW4gU2lnbmVkLW9mZi1ieS4gVGhleQpzaG91bGQgbWF0Y2gg YW5kIEkgZG8gbm90IGtub3cgS29yZWFuIHRvIGJlIGFibGUgdG8gdGVsbCB3aGV0aGVyIHRoZXkK cmVhbGx5IG1hdGNoIG9yIG5vdCA6KS4KSG93IGFib3V0IHVzaW5nIExhdGluIHRyYW5zbGl0ZXJh dGlvbiBhbHNvIGluICJGcm9tIiBmaWVsZD8KCj4gLS0tCj4gIGRyaXZlcnMvcGluY3RybC9zYW1z dW5nL0tjb25maWcgICAgICAgICAgICAgICAgfCAgNSArLS0tLQo+ICBkcml2ZXJzL3BpbmN0cmwv c2Ftc3VuZy9NYWtlZmlsZSAgICAgICAgICAgICAgIHwgMTMgKysrKysrKy0tLS0tLQo+ICBkcml2 ZXJzL3BpbmN0cmwvc2Ftc3VuZy9waW5jdHJsLWV4eW5vcy1hcm0uYyAgIHwgIDIgKysKPiAgZHJp dmVycy9waW5jdHJsL3NhbXN1bmcvcGluY3RybC1leHlub3MtYXJtNjQuYyB8ICAyICsrCj4gIGRy aXZlcnMvcGluY3RybC9zYW1zdW5nL3BpbmN0cmwtZXh5bm9zLmMgICAgICAgfCAgMiArKwo+ICBk cml2ZXJzL3BpbmN0cmwvc2Ftc3VuZy9waW5jdHJsLXNhbXN1bmcuYyAgICAgIHwgMTMgKysrKysr KysrKysrKwo+ICA2IGZpbGVzIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9u cygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGluY3RybC9zYW1zdW5nL0tjb25maWcKPiBi L2RyaXZlcnMvcGluY3RybC9zYW1zdW5nL0tjb25maWcKPiBpbmRleCA0MjVmYWRkNmMzNDYuLjI1 ZTE2OTg0ZWYyMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BpbmN0cmwvc2Ftc3VuZy9LY29uZmln Cj4gKysrIGIvZHJpdmVycy9waW5jdHJsL3NhbXN1bmcvS2NvbmZpZwo+IEBAIC0zLDE0ICszLDEz IEBACj4gICMgU2Ftc3VuZyBQaW4gY29udHJvbCBkcml2ZXJzCj4gICMKPiAgY29uZmlnIFBJTkNU UkxfU0FNU1VORwo+IC0gICAgICAgYm9vbAo+ICsgICAgICAgdHJpc3RhdGUgIlBpbmN0cmwgZHJp dmVyIGRhdGEgZm9yIFNhbXN1bmcgU29DcyIKPiAgICAgICAgIHNlbGVjdCBQSU5NVVgKPiAgICAg ICAgIHNlbGVjdCBQSU5DT05GCj4KPiAgY29uZmlnIFBJTkNUUkxfRVhZTk9TCj4gICAgICAgICBi b29sICJQaW5jdHJsIGRyaXZlciBkYXRhIGZvciBTYW1zdW5nIEVYWU5PUyBTb0NzIgo+ICAgICAg ICAgZGVwZW5kcyBvbiBPRiAmJiBHUElPTElCICYmIChBUkNIX0VYWU5PUyB8fCBBUkNIX1M1UFYy MTApCj4gLSAgICAgICBzZWxlY3QgUElOQ1RSTF9TQU1TVU5HCj4gICAgICAgICBzZWxlY3QgUElO Q1RSTF9FWFlOT1NfQVJNIGlmIEFSTSAmJiAoQVJDSF9FWFlOT1MgfHwgQVJDSF9TNVBWMjEwKQo+ ICAgICAgICAgc2VsZWN0IFBJTkNUUkxfRVhZTk9TX0FSTTY0IGlmIEFSTTY0ICYmIEFSQ0hfRVhZ Tk9TCj4KPiBAQCAtMjUsOSArMjQsNyBAQCBjb25maWcgUElOQ1RSTF9FWFlOT1NfQVJNNjQKPiAg Y29uZmlnIFBJTkNUUkxfUzNDMjRYWAo+ICAgICAgICAgYm9vbCAiU2Ftc3VuZyBTM0MyNFhYIFNv QyBwaW5jdHJsIGRyaXZlciIKPiAgICAgICAgIGRlcGVuZHMgb24gQVJDSF9TM0MyNFhYICYmIE9G Cj4gLSAgICAgICBzZWxlY3QgUElOQ1RSTF9TQU1TVU5HCj4KPiAgY29uZmlnIFBJTkNUUkxfUzND NjRYWAo+ICAgICAgICAgYm9vbCAiU2Ftc3VuZyBTM0M2NFhYIFNvQyBwaW5jdHJsIGRyaXZlciIK PiAgICAgICAgIGRlcGVuZHMgb24gQVJDSF9TM0M2NFhYCj4gLSAgICAgICBzZWxlY3QgUElOQ1RS TF9TQU1TVU5HCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGluY3RybC9zYW1zdW5nL01ha2VmaWxl Cj4gYi9kcml2ZXJzL3BpbmN0cmwvc2Ftc3VuZy9NYWtlZmlsZQo+IGluZGV4IGVkOTUxZGY2YTEx Mi4uYjNhYzAxODM4YjhhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcGluY3RybC9zYW1zdW5nL01h a2VmaWxlCj4gKysrIGIvZHJpdmVycy9waW5jdHJsL3NhbXN1bmcvTWFrZWZpbGUKPiBAQCAtMSw5 ICsxLDEwIEBACj4gICMgU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAKPiAgIyBTYW1z dW5nIHBpbiBjb250cm9sIGRyaXZlcnMKPgo+IC1vYmotJChDT05GSUdfUElOQ1RSTF9TQU1TVU5H KSAgKz0gcGluY3RybC1zYW1zdW5nLm8KPiAtb2JqLSQoQ09ORklHX1BJTkNUUkxfRVhZTk9TKSAg ICs9IHBpbmN0cmwtZXh5bm9zLm8KPiAtb2JqLSQoQ09ORklHX1BJTkNUUkxfRVhZTk9TX0FSTSkg ICAgICAgKz0gcGluY3RybC1leHlub3MtYXJtLm8KPiAtb2JqLSQoQ09ORklHX1BJTkNUUkxfRVhZ Tk9TX0FSTTY0KSAgICAgKz0gcGluY3RybC1leHlub3MtYXJtNjQubwo+IC1vYmotJChDT05GSUdf UElOQ1RSTF9TM0MyNFhYKSAgKz0gcGluY3RybC1zM2MyNHh4Lm8KPiAtb2JqLSQoQ09ORklHX1BJ TkNUUkxfUzNDNjRYWCkgICs9IHBpbmN0cmwtczNjNjR4eC5vCj4gK29iai0kKENPTkZJR19QSU5D VFJMX1NBTVNVTkcpICArPSBwaW5jdHJsLXNhbXN1bmctc3VwZXIubwo+ICtwaW5jdHJsLXNhbXN1 bmctc3VwZXItJChDT05GSUdfUElOQ1RSTF9TQU1TVU5HKSAgICAgICAgKz0gcGluY3RybC1zYW1z dW5nLm8KPiArcGluY3RybC1zYW1zdW5nLXN1cGVyLSQoQ09ORklHX1BJTkNUUkxfRVhZTk9TKSAr PSBwaW5jdHJsLWV4eW5vcy5vCj4gK3BpbmN0cmwtc2Ftc3VuZy1zdXBlci0kKENPTkZJR19QSU5D VFJMX0VYWU5PU19BUk0pICAgICArPSBwaW5jdHJsLWV4eW5vcy0KPiBhcm0ubwo+ICtwaW5jdHJs LXNhbXN1bmctc3VwZXItJChDT05GSUdfUElOQ1RSTF9FWFlOT1NfQVJNNjQpICAgKz0gcGluY3Ry bC1leHlub3MtCj4gYXJtNjQubwo+ICtwaW5jdHJsLXNhbXN1bmctc3VwZXItJChDT05GSUdfUElO Q1RSTF9TM0MyNFhYKSAgICAgICAgKz0gcGluY3RybC1zM2MyNHh4Lm8KPiArcGluY3RybC1zYW1z dW5nLXN1cGVyLSQoQ09ORklHX1BJTkNUUkxfUzNDNjRYWCkgICAgICAgICs9IHBpbmN0cmwtczNj NjR4eC5vCgpJIGRvbid0IGdldCB3aHkgeW91IG5lZWQgdG8gcmVuYW1lIG9iaiB0byBwaW5jdHJs LXNhbXN1bmctc3VwZXI/Cgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BpbmN0cmwvc2Ftc3VuZy9w aW5jdHJsLWV4eW5vcy1hcm0uYwo+IGIvZHJpdmVycy9waW5jdHJsL3NhbXN1bmcvcGluY3RybC1l eHlub3MtYXJtLmMKPiBpbmRleCA4NWRkZjQ5YTUxODguLjI4OTA2YmYyMTNjNCAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL3BpbmN0cmwvc2Ftc3VuZy9waW5jdHJsLWV4eW5vcy1hcm0uYwo+ICsrKyBi L2RyaXZlcnMvcGluY3RybC9zYW1zdW5nL3BpbmN0cmwtZXh5bm9zLWFybS5jCj4gQEAgLTE0LDYg KzE0LDcgQEAKPiAgLy8gZXh0ZXJuYWwgZ3BpbyBhbmQgd2FrZXVwIGludGVycnVwdCBzdXBwb3J0 Lgo+Cj4gICNpbmNsdWRlIDxsaW51eC9kZXZpY2UuaD4KPiArI2luY2x1ZGUgPGxpbnV4L21vZHVs ZS5oPgo+ICAjaW5jbHVkZSA8bGludXgvb2ZfYWRkcmVzcy5oPgo+ICAjaW5jbHVkZSA8bGludXgv c2xhYi5oPgo+ICAjaW5jbHVkZSA8bGludXgvZXJyLmg+Cj4gQEAgLTg5MSwzICs4OTIsNCBAQCBj b25zdCBzdHJ1Y3Qgc2Ftc3VuZ19waW5jdHJsX29mX21hdGNoX2RhdGEKPiBleHlub3M1NDIwX29m X2RhdGEgX19pbml0Y29uc3QgPSB7Cj4gICAgICAgICAuY3RybCAgICAgICAgICAgPSBleHlub3M1 NDIwX3Bpbl9jdHJsLAo+ICAgICAgICAgLm51bV9jdHJsICAgICAgID0gQVJSQVlfU0laRShleHlu b3M1NDIwX3Bpbl9jdHJsKSwKPiAgfTsKPiArTU9EVUxFX0xJQ0VOU0UoIkdQTCIpOwo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL3BpbmN0cmwvc2Ftc3VuZy9waW5jdHJsLWV4eW5vcy1hcm02NC5jCj4g Yi9kcml2ZXJzL3BpbmN0cmwvc2Ftc3VuZy9waW5jdHJsLWV4eW5vcy1hcm02NC5jCj4gaW5kZXgg YjZlNTY0MjJhNzAwLi4yYjE5NDc2YWQ1ZmYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9waW5jdHJs L3NhbXN1bmcvcGluY3RybC1leHlub3MtYXJtNjQuYwo+ICsrKyBiL2RyaXZlcnMvcGluY3RybC9z YW1zdW5nL3BpbmN0cmwtZXh5bm9zLWFybTY0LmMKPiBAQCAtMTQsNiArMTQsNyBAQAo+ICAvLyBl eHRlcm5hbCBncGlvIGFuZCB3YWtldXAgaW50ZXJydXB0IHN1cHBvcnQuCj4KPiAgI2luY2x1ZGUg PGxpbnV4L3NsYWIuaD4KPiArI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPgo+ICAjaW5jbHVkZSA8 bGludXgvc29jL3NhbXN1bmcvZXh5bm9zLXJlZ3MtcG11Lmg+Cj4KPiAgI2luY2x1ZGUgInBpbmN0 cmwtc2Ftc3VuZy5oIgo+IEBAIC00MjIsMyArNDIzLDQgQEAgY29uc3Qgc3RydWN0IHNhbXN1bmdf cGluY3RybF9vZl9tYXRjaF9kYXRhCj4gZXh5bm9zN19vZl9kYXRhIF9faW5pdGNvbnN0ID0gewo+ ICAgICAgICAgLmN0cmwgICAgICAgICAgID0gZXh5bm9zN19waW5fY3RybCwKPiAgICAgICAgIC5u dW1fY3RybCAgICAgICA9IEFSUkFZX1NJWkUoZXh5bm9zN19waW5fY3RybCksCj4gIH07Cj4gK01P RFVMRV9MSUNFTlNFKCJHUEwiKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9waW5jdHJsL3NhbXN1 bmcvcGluY3RybC1leHlub3MuYwo+IGIvZHJpdmVycy9waW5jdHJsL3NhbXN1bmcvcGluY3RybC1l eHlub3MuYwo+IGluZGV4IGViYzI3YjA2NzE4Yy4uNjMwZDYwNjMzMGYxIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvcGluY3RybC9zYW1zdW5nL3BpbmN0cmwtZXh5bm9zLmMKPiArKysgYi9kcml2ZXJz L3BpbmN0cmwvc2Ftc3VuZy9waW5jdHJsLWV4eW5vcy5jCj4gQEAgLTE4LDYgKzE4LDcgQEAKPiAg I2luY2x1ZGUgPGxpbnV4L2lycWRvbWFpbi5oPgo+ICAjaW5jbHVkZSA8bGludXgvaXJxLmg+Cj4g ICNpbmNsdWRlIDxsaW51eC9pcnFjaGlwL2NoYWluZWRfaXJxLmg+Cj4gKyNpbmNsdWRlIDxsaW51 eC9tb2R1bGUuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L29mLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9v Zl9pcnEuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4KPiBAQCAtNzEzLDMgKzcxNCw0IEBA IGV4eW5vc19yZXRlbnRpb25faW5pdChzdHJ1Y3Qgc2Ftc3VuZ19waW5jdHJsX2Rydl9kYXRhCj4g KmRydmRhdGEsCj4KPiAgICAgICAgIHJldHVybiBjdHJsOwo+ICB9Cj4gK01PRFVMRV9MSUNFTlNF KCJHUEwiKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9waW5jdHJsL3NhbXN1bmcvcGluY3RybC1z YW1zdW5nLmMKPiBiL2RyaXZlcnMvcGluY3RybC9zYW1zdW5nL3BpbmN0cmwtc2Ftc3VuZy5jCj4g aW5kZXggZGUwNDc3YmI0NjlkLi40NDgzZWFlZDI3ZjggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9w aW5jdHJsL3NhbXN1bmcvcGluY3RybC1zYW1zdW5nLmMKPiArKysgYi9kcml2ZXJzL3BpbmN0cmwv c2Ftc3VuZy9waW5jdHJsLXNhbXN1bmcuYwo+IEBAIC0xNSw2ICsxNSw3IEBACj4gIC8vIGJ1dCBw cm92aWRlcyBleHRlbnNpb25zIHRvIHdoaWNoIHBsYXRmb3JtIHNwZWNpZmljIGltcGxlbWVudGF0 aW9uIG9mCj4gdGhlIGdwaW8KPiAgLy8gYW5kIHdha2V1cCBpbnRlcnJ1cHRzIGNhbiBiZSBob29r ZWQgdG8uCj4KPiArI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPgo+ICAjaW5jbHVkZSA8bGludXgv aW5pdC5oPgo+ICAjaW5jbHVkZSA8bGludXgvcGxhdGZvcm1fZGV2aWNlLmg+Cj4gICNpbmNsdWRl IDxsaW51eC9pby5oPgo+IEBAIC0xMjc1LDYgKzEyNzYsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0 IG9mX2RldmljZV9pZAo+IHNhbXN1bmdfcGluY3RybF9kdF9tYXRjaFtdID0gewo+ICAjZW5kaWYK PiAgICAgICAgIHt9LAo+ICB9Owo+ICtNT0RVTEVfREVWSUNFX1RBQkxFKG9mLCBzYW1zdW5nX3Bp bmN0cmxfZHRfbWF0Y2gpOwo+Cj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZGV2X3BtX29wcyBzYW1z dW5nX3BpbmN0cmxfcG1fb3BzID0gewo+ICAgICAgICAgU0VUX0xBVEVfU1lTVEVNX1NMRUVQX1BN X09QUyhzYW1zdW5nX3BpbmN0cmxfc3VzcGVuZCwKPiBAQCAtMTI5NiwzICsxMjk4LDE0IEBAIHN0 YXRpYyBpbnQgX19pbml0IHNhbXN1bmdfcGluY3RybF9kcnZfcmVnaXN0ZXIodm9pZCkKPiAgICAg ICAgIHJldHVybiBwbGF0Zm9ybV9kcml2ZXJfcmVnaXN0ZXIoJnNhbXN1bmdfcGluY3RybF9kcml2 ZXIpOwo+ICB9Cj4gIHBvc3Rjb3JlX2luaXRjYWxsKHNhbXN1bmdfcGluY3RybF9kcnZfcmVnaXN0 ZXIpOwo+ICsKPiArc3RhdGljIHZvaWQgX19leGl0IHNhbXN1bmdfcGluY3RybF9kcnZfdW5yZWdp c3Rlcih2b2lkKQo+ICt7Cj4gKyAgICAgICBwbGF0Zm9ybV9kcml2ZXJfdW5yZWdpc3Rlcigmc2Ft c3VuZ19waW5jdHJsX2RyaXZlcik7Cj4gK30KPiArbW9kdWxlX2V4aXQoc2Ftc3VuZ19waW5jdHJs X2Rydl91bnJlZ2lzdGVyKTsKClNpbmNlIC5zdXBwcmVzc19iaW5kX2F0dHJzIGFyZSBkZWZpbmVk LCBJIGZpbmQgaXQgd2VpcmQgdG8gYmUgYWJsZSB0bwp1bmxvYWQgbW9kdWxlLi4uIEFub3RoZXIg d2FybmluZyBzaWduLi4uCgo+ICsKPiArCj4gK01PRFVMRV9MSUNFTlNFKCJHUEwiKTsKPiArTU9E VUxFX0FVVEhPUigiSHl1bmtpIEtvbyA8aHl1bmtpMDAua29vQHNhbXN1bmcuY29tPiIpOwoKSSBj YW5ub3QgZmluZCBhbnkgY29udHJpYnV0aW9ucyB0byB0aGlzIGZpbGUgZnJvbSB5b3UuIFRoZSBh dXRob3IKc2hvdWxkIGJlIHRoZSBtYWluIGNvbnRyaWJ1dG9yKHMpLiBZb3UgbmVlZCB0byBnbyB0 aHJvdWdoIGhpc3RvcnkuLi4KCj4gK01PRFVMRV9ERVNDUklQVElPTigiU2Ftc3VuZyBFeHlub3Mg UElOQ1RSTCBkcml2ZXIiKTsKClRoYXQncyBub3QgRXh5bm9zIGJ1dCBTYW1zdW5nLWdlbmVyaWMg cGFydC4uLiBTYW1zdW5nIEV4eW5vcy9TM0MvUzVQCnBpbmN0cmwgZHJpdmVyLgoKQmVzdCByZWdh cmRzLApLcnp5c3p0b2YKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK