From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3CC1C76186 for ; Wed, 17 Jul 2019 08:48:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6EBFD217F4 for ; Wed, 17 Jul 2019 08:48:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563353306; bh=/NRR6ZVfH/r+x8OphvuI+fLrW6gXRTqze46/dbMGmOI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=PpsBJNgIwOzqvSGmUpSvi3aBcEGGMjM192clxtTIJ6i5fDa8NGnou959dNnMh08T/ yJcBzupxmu8osu82tVpiNtmM/4eHdwTd/Rejp0LQ2nXuUJzBRhukb+vYI2T1beyblq caCN5G9IlUL3Ff4pjjUx0LC57dNviKNtPptTzT8M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729568AbfGQIsZ (ORCPT ); Wed, 17 Jul 2019 04:48:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:52382 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727005AbfGQIsY (ORCPT ); Wed, 17 Jul 2019 04:48:24 -0400 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D5DB52182B; Wed, 17 Jul 2019 08:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563353303; bh=/NRR6ZVfH/r+x8OphvuI+fLrW6gXRTqze46/dbMGmOI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=tA5kUXM3g/1ITmUwtPKsFJorXYYsWdZPHAI65v2pUAzTk0G5/mXlmAZqiLe87cBVD /sQ70iUvSiRZ/W+QQu6S+F5ksO6lCrzb3eKHLMB1FQ+oSm56MGSh+k147/dEnsqsPE gmGQ6cLFuCsF+OJfdHUaTux6Z4yf/vaDW0bFDT8s= Received: by mail-lj1-f170.google.com with SMTP id 16so22768465ljv.10; Wed, 17 Jul 2019 01:48:22 -0700 (PDT) X-Gm-Message-State: APjAAAVz8vBVbhqqhisGUxSXt74Ld+AhEtJx3LiuQJs51yVv0cnZloEZ I/4+JXEeik/lomEPtE74VDlvJomXOhohsRv+nHQ= X-Google-Smtp-Source: APXvYqwGbnK8q2TQAV3pBRB1WO6v0CtEUty37EkyvFjQViT6TKr312fFJIuwughcF6XBbdD2YqagKHof7D4Ib2xJ1sQ= X-Received: by 2002:a2e:8155:: with SMTP id t21mr20046257ljg.80.1563353301198; Wed, 17 Jul 2019 01:48:21 -0700 (PDT) MIME-Version: 1.0 References: <20190715124417.4787-1-l.luba@partner.samsung.com> <20190715124417.4787-22-l.luba@partner.samsung.com> In-Reply-To: <20190715124417.4787-22-l.luba@partner.samsung.com> From: Krzysztof Kozlowski Date: Wed, 17 Jul 2019 10:48:10 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 21/50] ARM: dts: exynos: add OPP into FSYS APB bus in Exynos5420 To: Lukasz Luba Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , linux-clk@vger.kernel.org, mturquette@baylibre.com, sboyd@kernel.org, =?UTF-8?B?QmFydMWCb21pZWogxbtvxYJuaWVya2lld2ljeg==?= , kgene@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org, Chanwoo Choi , kyungmin.park@samsung.com, Andrzej Hajda , Marek Szyprowski , s.nawrocki@samsung.com, myungjoo.ham@samsung.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Jul 2019 at 14:44, Lukasz Luba wrote: > > Add an OPP for FSYS APB which reflects the real possible frequency. > The bus will have a new parent clock which speed has 600MHz, thus > a new possible frequency provided by the clock divider is 150MHz. > According to the documentation max possible frequency for this bus is > 200MHz. Commit msg is good but title could be improved. Focus in the title what problem/issue you are solving - add intermediate step in scaling of FSYS APB? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C86F6C76186 for ; Wed, 17 Jul 2019 08:50:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96C1321743 for ; Wed, 17 Jul 2019 08:50:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JtVX7b7d"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="tA5kUXM3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96C1321743 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H/02qXlQTESqukq/TUnlITXdFQYJ7mndnNetwRHJpR4=; b=JtVX7b7dswBDZE 71FF/Qg+xqdLX8E5WC1oKEnt4eZsceErVCULIucpUYsy/pynC46RF25G8Sqm8nr6HXfbSv+gt94pm TWfdxl+duNsc6zw2fQY2qSjHXUk4hJGm3rwwNNZCE2weG75rp/Y7x6lJPgmBdgcZI11qRvFSceMLf vhgkzGqw6aDC3Cs3FjoVD4lG7Ah87XDQom3uLUjSMilgXr4ZMZV6DTjf7oi1LhE4SlrBYtljGx9u5 4xfv6fFcp66zHvguULVQKk2166DJGeEvDU32xUmUHYqObX90ECmvBmwu6tbmvHRx5dFFk1mFFQjnk 1Tarr+QwtbQQkXzlexXA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hnfdz-0002Ay-Co; Wed, 17 Jul 2019 08:50:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hnfbr-0005Dn-Id for linux-arm-kernel@lists.infradead.org; Wed, 17 Jul 2019 08:48:24 +0000 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DF39F2184B for ; Wed, 17 Jul 2019 08:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563353303; bh=/NRR6ZVfH/r+x8OphvuI+fLrW6gXRTqze46/dbMGmOI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=tA5kUXM3g/1ITmUwtPKsFJorXYYsWdZPHAI65v2pUAzTk0G5/mXlmAZqiLe87cBVD /sQ70iUvSiRZ/W+QQu6S+F5ksO6lCrzb3eKHLMB1FQ+oSm56MGSh+k147/dEnsqsPE gmGQ6cLFuCsF+OJfdHUaTux6Z4yf/vaDW0bFDT8s= Received: by mail-lj1-f175.google.com with SMTP id r9so22783480ljg.5 for ; Wed, 17 Jul 2019 01:48:22 -0700 (PDT) X-Gm-Message-State: APjAAAW0VfPDspxCGMMC3DS9o2Pm0Ic/bAUHkEqGKG8VNYRCZ866KZBD 02fpJZlOSGYPZMKKoWZlk5sUoPPK7bQ5gJoYnOc= X-Google-Smtp-Source: APXvYqwGbnK8q2TQAV3pBRB1WO6v0CtEUty37EkyvFjQViT6TKr312fFJIuwughcF6XBbdD2YqagKHof7D4Ib2xJ1sQ= X-Received: by 2002:a2e:8155:: with SMTP id t21mr20046257ljg.80.1563353301198; Wed, 17 Jul 2019 01:48:21 -0700 (PDT) MIME-Version: 1.0 References: <20190715124417.4787-1-l.luba@partner.samsung.com> <20190715124417.4787-22-l.luba@partner.samsung.com> In-Reply-To: <20190715124417.4787-22-l.luba@partner.samsung.com> From: Krzysztof Kozlowski Date: Wed, 17 Jul 2019 10:48:10 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 21/50] ARM: dts: exynos: add OPP into FSYS APB bus in Exynos5420 To: Lukasz Luba X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190717_014823_779546_29E33D94 X-CRM114-Status: GOOD ( 11.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, "linux-samsung-soc@vger.kernel.org" , =?UTF-8?B?QmFydMWCb21pZWogxbtvxYJuaWVya2lld2ljeg==?= , sboyd@kernel.org, mturquette@baylibre.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Andrzej Hajda , Chanwoo Choi , kyungmin.park@samsung.com, kgene@kernel.org, myungjoo.ham@samsung.com, s.nawrocki@samsung.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 15 Jul 2019 at 14:44, Lukasz Luba wrote: > > Add an OPP for FSYS APB which reflects the real possible frequency. > The bus will have a new parent clock which speed has 600MHz, thus > a new possible frequency provided by the clock divider is 150MHz. > According to the documentation max possible frequency for this bus is > 200MHz. Commit msg is good but title could be improved. Focus in the title what problem/issue you are solving - add intermediate step in scaling of FSYS APB? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel