From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sylwester Nawrocki <snawrocki@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Denis GNUtoo Carikli <GNUtoo@cyberdimension.org>,
Simon Shields <simon@lineageos.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3
Date: Mon, 31 Aug 2020 12:42:37 +0200 [thread overview]
Message-ID: <CAJKOXPdF4zzXvYrOiGQM9o=4rrWHvEr=o9aSTuR238dEaiD4cQ@mail.gmail.com> (raw)
In-Reply-To: <96651e85-c27f-3167-7b41-2ea051c25c65@kernel.org>
On Mon, 31 Aug 2020 at 12:35, Sylwester Nawrocki <snawrocki@kernel.org> wrote:
>
> Hi,
>
> On 8/31/20 10:38, Krzysztof Kozlowski wrote:
> > On Mon, 31 Aug 2020 at 10:31, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
> >> On 30.08.2020 15:51, Krzysztof Kozlowski wrote:
> >>> The camera's pinctrl configuration is simply empty and not effective.
> >>> Remove it to fix dtbs_check warning:
> >>>
> >>> arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array'
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >>
> >> I think that this was intentional to properly enable support for
> >> mem-2-mem mode in Exynos4-IS (FIMC), but I'm not sure what are the
> >> default values if no pinctrl properties are provided. Sylwester, could
> >> you comment?
> >
> > Indeed it could be intentional... I see now errors:
> > [ 33.752203] s5p-fimc-md soc:camera: Failed to get pinctrl: -19
> >
> > I wonder why getting an empty pinctrl is needed... maybe the driver
> > should accept missing pinctrl?
>
> It might have been better to have the pinctrl properties optional, as there
> might be boards without the image sensor attached and FIMC could still be
> used in memory-to-memory mode, as Marek pointed out. But it seems too late
> now to change that. The binding defines the pinctrl properties as required
> (Documentation/devicetree/bindings/media/samsung-fimc.txt) and we need to
> keep them in dtses.
You can always make a required property optional and it is not a break
of ABI. The other way around would be a break. Why then not changing
the driver to accept optional pinctrl?
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sylwester Nawrocki <snawrocki@kernel.org>
Cc: Simon Shields <simon@lineageos.org>,
devicetree@vger.kernel.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Denis GNUtoo Carikli <GNUtoo@cyberdimension.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3
Date: Mon, 31 Aug 2020 12:42:37 +0200 [thread overview]
Message-ID: <CAJKOXPdF4zzXvYrOiGQM9o=4rrWHvEr=o9aSTuR238dEaiD4cQ@mail.gmail.com> (raw)
In-Reply-To: <96651e85-c27f-3167-7b41-2ea051c25c65@kernel.org>
On Mon, 31 Aug 2020 at 12:35, Sylwester Nawrocki <snawrocki@kernel.org> wrote:
>
> Hi,
>
> On 8/31/20 10:38, Krzysztof Kozlowski wrote:
> > On Mon, 31 Aug 2020 at 10:31, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
> >> On 30.08.2020 15:51, Krzysztof Kozlowski wrote:
> >>> The camera's pinctrl configuration is simply empty and not effective.
> >>> Remove it to fix dtbs_check warning:
> >>>
> >>> arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array'
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >>
> >> I think that this was intentional to properly enable support for
> >> mem-2-mem mode in Exynos4-IS (FIMC), but I'm not sure what are the
> >> default values if no pinctrl properties are provided. Sylwester, could
> >> you comment?
> >
> > Indeed it could be intentional... I see now errors:
> > [ 33.752203] s5p-fimc-md soc:camera: Failed to get pinctrl: -19
> >
> > I wonder why getting an empty pinctrl is needed... maybe the driver
> > should accept missing pinctrl?
>
> It might have been better to have the pinctrl properties optional, as there
> might be boards without the image sensor attached and FIMC could still be
> used in memory-to-memory mode, as Marek pointed out. But it seems too late
> now to change that. The binding defines the pinctrl properties as required
> (Documentation/devicetree/bindings/media/samsung-fimc.txt) and we need to
> keep them in dtses.
You can always make a required property optional and it is not a break
of ABI. The other way around would be a break. Why then not changing
the driver to accept optional pinctrl?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-31 10:42 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-30 13:51 [PATCH 01/33] ARM: dts: exynos: Silence i2c-gpio dtschema warning in Galaxy I9100 Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 02/33] ARM: dts: exynos: Correct GPU regulator properties " Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 03/33] ARM: dts: exynos: Correct S3C RTC bindings and enable it " Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 04/33] ARM: dts: exynos: Correct S3C RTC bindings and enable it in Origen Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-31 9:49 ` Marek Szyprowski
2020-08-31 9:49 ` Marek Szyprowski
2020-08-30 13:51 ` [PATCH 05/33] ARM: dts: exynos: Correct S3C RTC bindings and enable it in Trats Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-31 9:49 ` Marek Szyprowski
2020-08-31 9:49 ` Marek Szyprowski
2020-08-30 13:51 ` [PATCH 06/33] ARM: dts: exynos: Correct S3C RTC bindings and enable it in Universal C210 Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-31 9:49 ` Marek Szyprowski
2020-08-31 9:49 ` Marek Szyprowski
2020-08-30 13:51 ` [PATCH 07/33] ARM: dts: exynos: Correct S3C RTC bindings in SMDKv310 Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 08/33] ARM: dts: exynos: Add and enable 32 kHz modem clock in Galaxy I9100 Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-09-02 15:41 ` Krzysztof Kozlowski
2020-09-02 15:41 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 09/33] ARM: dts: exynos: Add and enable 32 kHz modem clock in Origen Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-31 9:16 ` Marek Szyprowski
2020-08-31 9:16 ` Marek Szyprowski
2020-08-31 9:37 ` Krzysztof Kozlowski
2020-08-31 9:37 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 10/33] ARM: dts: exynos: Add and enable 32 kHz modem clock in Trats Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 11/33] ARM: dts: exynos: Remove empty camera pinctrl configuration " Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 12/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Universal C210 Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 13/33] ARM: dts: exynos: Align SPI GPIO node name with dtschema " Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [RFT 14/33] ARM: dts: exynos: Replace deprecated GPIO spi-gpio properties " Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-31 9:25 ` Marek Szyprowski
2020-08-31 9:25 ` Marek Szyprowski
2020-08-30 13:51 ` [PATCH 15/33] ARM: dts: exynos: Align SPI GPIO node name with dtschema in Galaxy I9100 Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 16/33] ARM: dts: exynos: Override thermal by label in Exynos4210 Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 17/33] ARM: dts: exynos: Override thermal by label in Galaxy I9000 Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 18/33] ARM: dts: exynos: Override thermal by label in Trats Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 19/33] ARM: dts: exynos: Add CPU cooling in Origen Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 20/33] ARM: dts: exynos: Add CPU cooling in SMDKv310 Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 21/33] ARM: dts: exynos: Add CPU cooling in Universal C210 Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 22/33] ARM: dts: exynos: Align MHL GPIO pin configuration with dtschema on Galaxy I9100 Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-09-02 15:45 ` Krzysztof Kozlowski
2020-09-02 15:45 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3 Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-31 8:31 ` Marek Szyprowski
2020-08-31 8:31 ` Marek Szyprowski
2020-08-31 8:38 ` Krzysztof Kozlowski
2020-08-31 8:38 ` Krzysztof Kozlowski
2020-08-31 8:44 ` Marek Szyprowski
2020-08-31 8:44 ` Marek Szyprowski
2020-08-31 10:35 ` Sylwester Nawrocki
2020-08-31 10:35 ` Sylwester Nawrocki
2020-08-31 10:42 ` Krzysztof Kozlowski [this message]
2020-08-31 10:42 ` Krzysztof Kozlowski
2020-08-31 13:57 ` Sylwester Nawrocki
2020-08-31 13:57 ` Sylwester Nawrocki
2020-08-31 13:59 ` Krzysztof Kozlowski
2020-08-31 13:59 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 24/33] ARM: dts: exynos: Correct compatible of fixed clocks in Midas boards Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-09-02 15:48 ` Krzysztof Kozlowski
2020-09-02 15:48 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 25/33] ARM: dts: exynos: Add S5M8767 clocks for RTC in Exynos4412 Origen Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 26/33] ARM: dts: exynos: Override thermal by label in Midas Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 27/33] ARM: dts: exynos: Override thermal by label in Exynos4412 Odroids Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 28/33] ARM: dts: exynos: Add CPU cooling in Exynos4412 Origen Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 29/33] ARM: dts: exynos: Add CPU cooling in SMDK4412 Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 30/33] ARM: dts: exynos: Add CPU cooling in Tiny4412 Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 31/33] ARM: dts: exynos: Correct S3C RTC bindings in SMDK4412 Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 32/33] ARM: dts: exynos: Correct S3C RTC bindings in Tiny4412 Krzysztof Kozlowski
2020-08-30 13:51 ` Krzysztof Kozlowski
2020-08-30 13:52 ` [PATCH 33/33] ARM: dts: exynos: Correct whitespace and indentation issues Krzysztof Kozlowski
2020-08-30 13:52 ` Krzysztof Kozlowski
2020-09-02 15:38 ` [PATCH 01/33] ARM: dts: exynos: Silence i2c-gpio dtschema warning in Galaxy I9100 Krzysztof Kozlowski
2020-09-02 15:38 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKOXPdF4zzXvYrOiGQM9o=4rrWHvEr=o9aSTuR238dEaiD4cQ@mail.gmail.com' \
--to=krzk@kernel.org \
--cc=GNUtoo@cyberdimension.org \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
--cc=simon@lineageos.org \
--cc=snawrocki@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.