All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	arm@kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Olof Johansson <olof@lixom.net>,
	Kevin Hilman <khilman@linaro.org>,
	Doug Anderson <dianders@chromium.org>,
	Kukjin Kim <kgene@kernel.org>,
	"linux-samsung-soc@vger.kernel.org" 
	<linux-samsung-soc@vger.kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 7/9] ARM: multi_v7_defconfig: Enable options for Exynos display support
Date: Fri, 15 May 2015 10:08:56 +0900	[thread overview]
Message-ID: <CAJKOXPdWb3onJcTOSGJpaqwE4NWd=QN4FDarWj1jVZM1sTv1VQ@mail.gmail.com> (raw)
In-Reply-To: <CABxcv=kyM8KCp+QtJrrjuBO+hXx1Y-9xYOZGQx8BWyOdLqsCiA@mail.gmail.com>

2015-05-15 9:58 GMT+09:00 Javier Martinez Canillas <javier@dowhile0.org>:
> Hello Krzysztof,
>
> On Fri, May 15, 2015 at 2:36 AM, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
>> 2015-05-15 0:40 GMT+09:00 Javier Martinez Canillas
>> <javier.martinez@collabora.co.uk>:
>>> Many Exynos devices have devices attached to their display ports.
>>> This patch enables the needed Kconfig options to support different
>>> configuration such as simple panel, embedded DisplayPort (eDP) to
>>> LVDS bridges and HDMI displays.
>>
>> Enabling the display would be nice but for some quite long time we had
>> issues with DRM on Exynos. exynos_defconfig has it enabled and most of
>> boards boot fine with it. Exception is Arndale 5250:
>
> Yes, like I said in the other thread, the fact that Exynos DRM is
> working fine now on most boards is mostly because the bugs were
> exposed when the Exynos DRM options were enabled.

I saw your response in email 0/9 but let us stick to one thread.
So these are my only concerns - instability in the past.

>> http://storage.kernelci.org/next/next-20150514/arm-exynos_defconfig/lab-khilman/boot-exynos5250-arndale.html
>> [    1.630290] [drm:exynos_dp_bind] *ERROR* failed: of_get_videomode() : -22
>> [    1.637071] exynos-drm exynos-drm: failed to bind
>> 145b0000.dp-controller (ops exynos_dp_ops): -22
>> [    1.646504] exynos-drm exynos-drm: master bind failed: -22
>> [    1.651391] exynos-drm: probe of exynos-drm failed with error -22
>>
>
> Ajay Kumar changed the DT bindings for the Exynos DRM Display Panel
> driver some time ago but it seems that the Arndale 5250 DTS was never
> updated. Something along the lines of commit [0] is needed.

Thanks,

>
>> Anyway it is not like I am against it... just wondering. On the other
>> hand enabling it could help in early detection of errors.
>>
>
> I think that not enabling these options will just make latent bugs to
> not be exposed. As an example I found that module auto-loading was
> broken for the driver of the PTN3460 eDP to LVDS bridge used in the
> Exynos5250 Snow Chromebook and already posted a fix [1].

Right, enabling the options helps in exposing problems so they could
be spotted and fixed.


> I would had never found that bug if wouldn't had tried enabling these
> options in multi_v7 as a module. Also remember that the consumer
> version of these machines don't have a serial console so for users
> building images with multi_v7, not having display support means that
> the machine is pretty useless.

That is indeed good reason.

FWIW, I tested multi_v7 with your patches on Exynos4412 Trats2 board
and it worked fine.

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

  reply	other threads:[~2015-05-15  1:09 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14 15:40 [PATCH 0/9] multi_v7_defconfig: Enable options for Exynos Chromebooks Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 1/9] ARM: multi_v7_defconfig: Enable support for Samsung S3C64XX SPI Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 2/9] ARM: multi_v7_defconfig: Enable max77802 regulator, rtc and clock drivers Javier Martinez Canillas
2015-07-15 15:38   ` Javier Martinez Canillas
2015-07-15 15:38     ` Javier Martinez Canillas
2015-07-16  0:42     ` Krzysztof Kozlowski
2015-07-16  0:42       ` Krzysztof Kozlowski
2015-07-16  5:30       ` Javier Martinez Canillas
2015-07-16  5:30         ` Javier Martinez Canillas
2015-07-17 16:49       ` Olof Johansson
2015-07-17 16:49         ` Olof Johansson
2015-07-17 18:47         ` Javier Martinez Canillas
2015-07-17 18:47           ` Javier Martinez Canillas
2015-07-17 18:49           ` Olof Johansson
2015-07-17 18:49             ` Olof Johansson
2015-07-25  2:01             ` Kukjin Kim
2015-05-14 15:40 ` [PATCH 3/9] ARM: multi_v7_defconfig: Enable Exynos USB PHY drivers support Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 4/9] ARM: multi_v7_defconfig: Enable support for missing ChromeOS EC drivers Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 5/9] ARM: multi_v7_defconfig: Enable Samsung PWM support Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 6/9] ARM: multi_v7_defconfig: Enable Samsung S3C SoC RTC Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 7/9] ARM: multi_v7_defconfig: Enable options for Exynos display support Javier Martinez Canillas
2015-05-15  0:36   ` Krzysztof Kozlowski
2015-05-15  0:58     ` Javier Martinez Canillas
2015-05-15  0:58       ` Javier Martinez Canillas
2015-05-15  1:08       ` Krzysztof Kozlowski [this message]
2015-05-15  1:08         ` Krzysztof Kozlowski
2015-05-14 15:40 ` [PATCH 8/9] ARM: multi_v7_defconfig: Enable GPIO-based I2C arbitration support Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 9/9] ARM: multi_v7_defconfig: Enable Cypress APA I2C Trackpad support Javier Martinez Canillas
2015-05-15  0:18 ` [PATCH 0/9] multi_v7_defconfig: Enable options for Exynos Chromebooks Krzysztof Kozlowski
2015-05-15  0:33   ` Javier Martinez Canillas
2015-05-15  0:33     ` Javier Martinez Canillas
2015-05-15 11:37 ` Arnd Bergmann
2015-05-15 12:00   ` Krzysztof Kozlowski
2015-05-16  3:25     ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJKOXPdWb3onJcTOSGJpaqwE4NWd=QN4FDarWj1jVZM1sTv1VQ@mail.gmail.com' \
    --to=k.kozlowski@samsung.com \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=dianders@chromium.org \
    --cc=javier.martinez@collabora.co.uk \
    --cc=javier@dowhile0.org \
    --cc=kgene@kernel.org \
    --cc=khilman@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=olof@lixom.net \
    --subject='Re: [PATCH 7/9] ARM: multi_v7_defconfig: Enable options for Exynos display support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.