Re: [PATCH 2/6] extcon: max77843: Add max77843 MUIC driver

From: "Krzysztof Kozłowski" <k.kozlowski.k@gmail.com>
To: Jaewon Kim <jaewon02.kim@samsung.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-pm@vger.kernel.org, Inki Dae <inki.dae@samsung.com>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Lee Jones <lee.jones@linaro.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Sebastian Reichel <sre@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Beomho Seo <beomho.seo@samsung.com>
Subject: Re: [PATCH 2/6] extcon: max77843: Add max77843 MUIC driver
Date: Fri, 23 Jan 2015 07:38:22 +0100	[thread overview]
Message-ID: <CAJKOXPdoDZH1CmNOkZuw_Bx9pT_drP0ZrSLB8jmJpDR+sacRjg@mail.gmail.com> (raw)
In-Reply-To: <1421989367-32721-3-git-send-email-jaewon02.kim@samsung.com>

2015-01-23 6:02 GMT+01:00 Jaewon Kim <jaewon02.kim@samsung.com>:
> This patch adds MAX77843 extcon driver to support for MUIC(Micro
> USB Interface Controller) device by using EXTCON subsystem to handle
> various external connectors.
>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
>  drivers/extcon/Kconfig           |   10 +
>  drivers/extcon/Makefile          |    1 +
>  drivers/extcon/extcon-max77843.c |  871 ++++++++++++++++++++++++++++++++++++++
>  3 files changed, 882 insertions(+)
>  create mode 100644 drivers/extcon/extcon-max77843.c
>

(...)

> +static int max77843_muic_remove(struct platform_device *pdev)
> +{
> +       struct max77843_muic_info *info = platform_get_drvdata(pdev);
> +
> +       cancel_work_sync(&info->irq_work);
> +

Missing regmap_del_irq_chip().

Best regards,
Krzysztof