From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29E59C433DB for ; Mon, 28 Dec 2020 08:35:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1CF5225A9 for ; Mon, 28 Dec 2020 08:35:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726540AbgL1IfL (ORCPT ); Mon, 28 Dec 2020 03:35:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:55498 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726371AbgL1IfK (ORCPT ); Mon, 28 Dec 2020 03:35:10 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 66C7422582; Mon, 28 Dec 2020 08:34:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609144469; bh=5G1n56C71j9pJKhwGAx7IkLxlpCqLn9XwcLEY9aCJiw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=XCJ4F3quy8czwg3PgpCPumaVqfvn4NqeG0UWe+gNHoLUwB3S4O/vril6+rIed6W3v Wdlc4Rjq+502oN0LSOeKd+In1Ta2l2xJNAhprmwbhjSbyB8xVd4ooQMNBnHyhorYP6 R3v2qMRaLohD/ADiL79RPo4vJR6XyFTEh9lSQA7hEQVyNvw9bRKCEMmsMWHg2oTDX0 2WFuIvmvGUuGZDeVisRlll1Sqgm6SQRUQ77ctlfSkBQ+/VeaL4zBZmmeMzizbMfrwK Yo0eoQ9cry3ZZnx2y8UpxYHI1o91uQQ0NZblU4AyBtrZntlC7uPbpDswvPXN7n1UR2 kupP3mLCIkaeg== Received: by mail-ed1-f50.google.com with SMTP id c7so9074112edv.6; Mon, 28 Dec 2020 00:34:29 -0800 (PST) X-Gm-Message-State: AOAM532FIlrWLHwJQnMw6dlRqU5KQvx5DUci/G+C0ZhiZXp1qYOBUQz9 Gf1BLybSmkrypbQOpSATJlj2fuAT7GyNEbUGBGw= X-Google-Smtp-Source: ABdhPJxen+9UAJDztAzg+fITSQGg9bxnmZAhYyOn8CI9mcfodTpkQviRZmkAQUxK8JsyVC27u+Zj7qo2zPf3lEoIiS4= X-Received: by 2002:aa7:d593:: with SMTP id r19mr41858975edq.246.1609144467956; Mon, 28 Dec 2020 00:34:27 -0800 (PST) MIME-Version: 1.0 References: <20201223110343.126638-1-jagan@amarulasolutions.com> <20201223110343.126638-5-jagan@amarulasolutions.com> <20201223115933.GC21091@kozik-lap> In-Reply-To: From: Krzysztof Kozlowski Date: Mon, 28 Dec 2020 09:34:16 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 4/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0 To: Jagan Teki Cc: Rob Herring , Shawn Guo , Li Yang , Fabio Estevam , devicetree , linux-kernel , linux-arm-kernel , NXP Linux Team , linux-amarula , Catalin Marinas , Will Deacon , Matteo Lisi Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Dec 2020 at 09:21, Jagan Teki wrote: > > > #include "imx8mm.dtsi" > > > #include "imx8mm-beacon-som.dtsi" > > > #include "imx8mm-beacon-baseboard.dtsi" > > > > > > (SoC dtsi, SoM dtsi, Carrier board dtsi) > > > > > > > design which makes any sense. We do not create empty DTS files which > > > > only include one more DTSI. The contents of > > > > imx8mm-engicam-ctouch2.dtsi should be directly in > > > > imx8mm-icore-mx8mm-ctouch2.dts. That's the same problem as with v1 - > > > > you overcomplicate simple stuff. It really looks like you ignored the > > > > comments from v1 in multiple places. > > > > > > As explained above, the design is pretty much the same as the existing SoM's. > > > > > > imx8mm-engicam-ctouch2.dtsi is not just a dtsi file where nodes are > > > enabled. It has nodes enabled for Carrier board, so keeping nodes > > > separately will > > > > The files represent real devices or their components. So you have a > > SOM - a DTSI file. You have a carrier board - a DTS file. That's > > simple design which is mostly followed, unless something over > > complicated passes the review. > > > > > 1. More verbose for which IP's are available in the carrier board > > > > No difference when carrier DTSI is the DTS. Exactly the same. > > > > > 2. Easy to extend if someone can create another SoM with a similar Carrier. > > > > Not really, if they include carrier DTSI they need to override a lot. > > So usually (including practice - I did it) they *copy* the carrier to > > create their own design. > > But what if the new board has slite change to use exiting carrier like > what ctouch2 10" OF. Can we add ctouch2 dtsi as a separate file for > this case? If you submit another DTS using the imx8mm-engicam-ctouch2.dtsi - with its own differences of course (not copying other DTS...) - then having a DTSI makes sense. In current form, still NAK for all the reasons I explained more than once. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A38F9C433E0 for ; Mon, 28 Dec 2020 08:36:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37E4A21D94 for ; Mon, 28 Dec 2020 08:36:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37E4A21D94 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3WSFRkey7D0e7xk7c36xdLm/MVnoyHaKrQe1NpnwktM=; b=XaIEoxhtZnd8v4FYWYz2VfHCK KvL1kLXb51veqAfhPeg1iB7eK1SEd92UcBxnSX8pj2Z/Ezo6/R4B5FfOzgPg1TAfj2ScVTcYvYosu vX/SIFWn3UTBfF7MyseGufIwMAGPY9DkMTWxCcw5M9HreHmApdKJsq9SVewdS46/j30Bvv9iq36qD pq3KG4PoBuDQzeiUNASe/SPJ/q/ESp4oFRTD4CutyM1BiOptEdi3mGSIF7yBkImAG73xcL93sfdF5 EwY/z9Ji+RCtxDAgeI1737yf5zXEIoR2Y8iSEvJD1hGej12zm6FVi0Sz31vGxdApYwKCjLiGOoBLm m97jYdUiw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ktnz7-0001m2-71; Mon, 28 Dec 2020 08:34:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ktnz5-0001lb-GN for linux-arm-kernel@lists.infradead.org; Mon, 28 Dec 2020 08:34:32 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4FAC72242A for ; Mon, 28 Dec 2020 08:34:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609144469; bh=5G1n56C71j9pJKhwGAx7IkLxlpCqLn9XwcLEY9aCJiw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=XCJ4F3quy8czwg3PgpCPumaVqfvn4NqeG0UWe+gNHoLUwB3S4O/vril6+rIed6W3v Wdlc4Rjq+502oN0LSOeKd+In1Ta2l2xJNAhprmwbhjSbyB8xVd4ooQMNBnHyhorYP6 R3v2qMRaLohD/ADiL79RPo4vJR6XyFTEh9lSQA7hEQVyNvw9bRKCEMmsMWHg2oTDX0 2WFuIvmvGUuGZDeVisRlll1Sqgm6SQRUQ77ctlfSkBQ+/VeaL4zBZmmeMzizbMfrwK Yo0eoQ9cry3ZZnx2y8UpxYHI1o91uQQ0NZblU4AyBtrZntlC7uPbpDswvPXN7n1UR2 kupP3mLCIkaeg== Received: by mail-ed1-f51.google.com with SMTP id b73so9041864edf.13 for ; Mon, 28 Dec 2020 00:34:29 -0800 (PST) X-Gm-Message-State: AOAM533Uugz1vU9jJF3isBiemc9XxDUOeLOL7dz8OJIQKm4v2lwgdxL6 LNAtkKkcFELKMYpQSuZm4cfDTEhZeWgDkeLBpSY= X-Google-Smtp-Source: ABdhPJxen+9UAJDztAzg+fITSQGg9bxnmZAhYyOn8CI9mcfodTpkQviRZmkAQUxK8JsyVC27u+Zj7qo2zPf3lEoIiS4= X-Received: by 2002:aa7:d593:: with SMTP id r19mr41858975edq.246.1609144467956; Mon, 28 Dec 2020 00:34:27 -0800 (PST) MIME-Version: 1.0 References: <20201223110343.126638-1-jagan@amarulasolutions.com> <20201223110343.126638-5-jagan@amarulasolutions.com> <20201223115933.GC21091@kozik-lap> In-Reply-To: From: Krzysztof Kozlowski Date: Mon, 28 Dec 2020 09:34:16 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 4/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0 To: Jagan Teki X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201228_033431_797029_AD016BB0 X-CRM114-Status: GOOD ( 23.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Matteo Lisi , Will Deacon , Shawn Guo , linux-kernel , Li Yang , Rob Herring , NXP Linux Team , Catalin Marinas , Fabio Estevam , linux-amarula , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 28 Dec 2020 at 09:21, Jagan Teki wrote: > > > #include "imx8mm.dtsi" > > > #include "imx8mm-beacon-som.dtsi" > > > #include "imx8mm-beacon-baseboard.dtsi" > > > > > > (SoC dtsi, SoM dtsi, Carrier board dtsi) > > > > > > > design which makes any sense. We do not create empty DTS files which > > > > only include one more DTSI. The contents of > > > > imx8mm-engicam-ctouch2.dtsi should be directly in > > > > imx8mm-icore-mx8mm-ctouch2.dts. That's the same problem as with v1 - > > > > you overcomplicate simple stuff. It really looks like you ignored the > > > > comments from v1 in multiple places. > > > > > > As explained above, the design is pretty much the same as the existing SoM's. > > > > > > imx8mm-engicam-ctouch2.dtsi is not just a dtsi file where nodes are > > > enabled. It has nodes enabled for Carrier board, so keeping nodes > > > separately will > > > > The files represent real devices or their components. So you have a > > SOM - a DTSI file. You have a carrier board - a DTS file. That's > > simple design which is mostly followed, unless something over > > complicated passes the review. > > > > > 1. More verbose for which IP's are available in the carrier board > > > > No difference when carrier DTSI is the DTS. Exactly the same. > > > > > 2. Easy to extend if someone can create another SoM with a similar Carrier. > > > > Not really, if they include carrier DTSI they need to override a lot. > > So usually (including practice - I did it) they *copy* the carrier to > > create their own design. > > But what if the new board has slite change to use exiting carrier like > what ctouch2 10" OF. Can we add ctouch2 dtsi as a separate file for > this case? If you submit another DTS using the imx8mm-engicam-ctouch2.dtsi - with its own differences of course (not copying other DTS...) - then having a DTSI makes sense. In current form, still NAK for all the reasons I explained more than once. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel