All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC 4/6] configs: exynos: Add new CONFIG_SYS_ODROID_USB config option
Date: Tue, 2 Apr 2019 09:02:19 +0200	[thread overview]
Message-ID: <CAJKOXPeLscxHPjcnzuY2OTbkriLPket6kj4sch2CKu_3UGRG=g@mail.gmail.com> (raw)
In-Reply-To: <CANAwSgSL2_0SgBZShQnT0+3jUMpwdajf3Rpuv8n7SkUJA=gbSA@mail.gmail.com>

On Mon, 1 Apr 2019 at 19:17, Anand Moon <linux.amoon@gmail.com> wrote:
>
> Hi Krzysztof,
>
> On Mon, 1 Apr 2019 at 21:46, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Mon, 1 Apr 2019 at 17:50, Anand Moon <linux.amoon@gmail.com> wrote:
> > >
> > > Hi Krzysztof,
> > >
> > > On Mon, 1 Apr 2019 at 18:27, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > >
> > > > On Mon, 1 Apr 2019 at 13:53, Anand Moon <linux.amoon@gmail.com> wrote:
> > > > >
> > > > > Add new CONFIG_SYS_ODROID_USB flag to avoid compliation
> > > > > error on other development boards.
> > > > >
> > > > > Fix below compilation error:
> > > > > Error: You must add new CONFIG options using Kconfig
> > > > > The following new ad-hoc CONFIG options were detected:
> > > > > CONFIG_SYS_ODROID_USB
> > > >
> > > > There is no ad-hoc option "SYS_ODROID_USB" so it cannot cause build error.
> > > >
> > > > This is something wrong... Are you sure that you are compiling master branch?
> > > >
> > > > Best regards,
> > > > Krzysztof
> > > >
> > >
> > > [snip]
> > >
> > > CONFIG_SYS_ODROID_USB is adder to fix compilation error other development board.
> > > so this code is specific to the Odroid U3 and Odroid X2 boards.
> > >
> > > I have compiled both XU3 and U3 build with no problem.
> >
> > You quoted the error message saying that ad-hoc option
> > CONFIG_SYS_ODROID_USB was added. But such ad-hoc option does not
> > exist. Now you say that you add this to fix build problem... I really
> > do not understand. So let's simplify it - please tell me how I can
> > reproduce the problem and what is expected.
> >
> > Best regards,
> > Krzysztof
>
> This CONFIG_SYS_ODROID_USB options is more like and compile time flag
> defined in odroid.h and not on any other boards, so this flags add
> guard to the code.
>
> At the end of  u-boot compilation it would prompt that new config
> option is added
> please add this to some Kconfig so that it could be selected via make menuconfig
>
> See the link below, why I chose this options.
>
> [0] https://github.com/Xilinx/u-boot-xlnx/blob/master/doc/README.kconfig

Can you provide answer to this:
"So let's simplify it - please tell me how I can reproduce the problem
and what is expected."
?

Best regards,
Krzysztof

  reply	other threads:[~2019-04-02  7:02 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 11:52 [U-Boot] [RFC 0/6] Odroid U3 usb initialization Anand Moon
2019-04-01 11:52 ` [U-Boot] [RFC 1/6] odroid: exynos: USB initialization on the U3/X2 Anand Moon
2019-04-01 12:48   ` Krzysztof Kozlowski
2019-04-01 16:20     ` Anand Moon
2019-04-01 12:57   ` Lukasz Majewski
2019-04-01 13:22     ` Jack Mitchell
2019-04-03 19:58   ` Tobias Jakobi
2019-04-04  3:01     ` Anand Moon
2019-04-01 11:52 ` [U-Boot] [RFC 2/6] odroid: exynos: usb clean up for U3/X2 Anand Moon
2019-04-01 12:51   ` Krzysztof Kozlowski
2019-04-01 15:57     ` Anand Moon
2019-04-01 16:12       ` Krzysztof Kozlowski
2019-04-01 11:52 ` [U-Boot] [RFC 3/6] usb: exynos: add init_after_reset for usb reset Anand Moon
2019-04-01 12:55   ` Krzysztof Kozlowski
2019-04-01 16:05     ` Anand Moon
2019-04-01 16:14       ` Krzysztof Kozlowski
2019-04-01 11:52 ` [U-Boot] [RFC 4/6] configs: exynos: Add new CONFIG_SYS_ODROID_USB config option Anand Moon
2019-04-01 12:57   ` Krzysztof Kozlowski
2019-04-01 15:50     ` Anand Moon
2019-04-01 16:16       ` Krzysztof Kozlowski
2019-04-01 17:16         ` Anand Moon
2019-04-02  7:02           ` Krzysztof Kozlowski [this message]
2019-04-02  7:52             ` Anand Moon
2019-04-02  7:56               ` Krzysztof Kozlowski
2019-04-01 11:52 ` [U-Boot] [RFC 5/6] arm: exynos: odroid: fix the confict scripaddr extra env setting Anand Moon
2019-04-01 13:00   ` Krzysztof Kozlowski
2019-04-01 15:43     ` Anand Moon
2019-04-01 11:52 ` [U-Boot] [RFC 6/6] arm: exynos: add usbnet_devaddr setting to env Anand Moon
2019-04-01 13:04   ` Krzysztof Kozlowski
2019-04-01 16:42     ` Anand Moon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJKOXPeLscxHPjcnzuY2OTbkriLPket6kj4sch2CKu_3UGRG=g@mail.gmail.com' \
    --to=krzk@kernel.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.