From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4010BC433E2 for ; Sun, 6 Sep 2020 14:43:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F33BD20714 for ; Sun, 6 Sep 2020 14:43:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599403381; bh=7IEOIE7fQw9QHXmykxTiIVu886iDkKJ30802n3q5IwU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=tSL2QnUdgBiTEuLUk2T/jJ9Ea1VugfQ7xVfaMFOuH7G5/349Kk9KFqe/PDQj2sH81 HcYZlAhTPait5kDwy1ZnfQCl4tbIWVVJ4mtrBUMkw3tY3HOHjDZ6sb8pikn9Mt6tlK YU/0fnQ8xwnH0/Di4izip1AEsp9kpFkPowRoJexU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728941AbgIFOmx (ORCPT ); Sun, 6 Sep 2020 10:42:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:34590 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728850AbgIFOkJ (ORCPT ); Sun, 6 Sep 2020 10:40:09 -0400 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 01B9B20838; Sun, 6 Sep 2020 14:39:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599403147; bh=7IEOIE7fQw9QHXmykxTiIVu886iDkKJ30802n3q5IwU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=etXM+rlB1+DW1J4jNFEGcm+fF67s78ieiIJMokib3gbJ/4axa/QC0n2G8dk5lqyab qBGZpGxKO4g23EzVrnLE9URUV/18btbD6jd7BioxTKQiRAZiF9j5rBoO60/0+AU19R QrrjUKSu0Uk6jLxywtE5Upy8feMDExtu7wnkOdM4= Received: by mail-ej1-f51.google.com with SMTP id o8so1353409ejb.10; Sun, 06 Sep 2020 07:39:06 -0700 (PDT) X-Gm-Message-State: AOAM531tqYkhj80e+PXdMwLyhpduhVhMUwWc77d5dfLswhKd6azxDxHT 2qwXRhjc+5czxV+tq8MIXY63DKTLCaqjHxLMBoQ= X-Google-Smtp-Source: ABdhPJwZbjzSkmXyfdB9RtLYvattBo3H9pni7matmcNuK/Qe1S1r3L8Nqgb9OFRwyrC4kvI+4viaz1GbEG+WoE49O3Y= X-Received: by 2002:a17:907:724f:: with SMTP id ds15mr16286701ejc.119.1599403145475; Sun, 06 Sep 2020 07:39:05 -0700 (PDT) MIME-Version: 1.0 References: <20200829142948.32365-1-krzk@kernel.org> <20200903163255.GA2903619@bogus> In-Reply-To: <20200903163255.GA2903619@bogus> From: Krzysztof Kozlowski Date: Sun, 6 Sep 2020 16:38:53 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/4] dt-bindings: net: nfc: s3fwrn5: Convert to dtschema To: Rob Herring Cc: "David S. Miller" , Jakub Kicinski , Krzysztof Opasiak , Kukjin Kim , netdev@vger.kernel.org, devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-nfc@lists.01.org, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Sylwester Nawrocki , Chanwoo Choi , Inki Dae Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Sep 2020 at 18:33, Rob Herring wrote: > > On Sat, Aug 29, 2020 at 04:29:45PM +0200, Krzysztof Kozlowski wrote: > > Convert the Samsung S3FWRN5 NCI NFC controller bindings to dtschema. > > This is conversion only so it includes properties with invalid prefixes > > (s3fwrn5,en-gpios) which should be addressed later. > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > .../devicetree/bindings/net/nfc/s3fwrn5.txt | 25 -------- > > .../devicetree/bindings/net/nfc/s3fwrn5.yaml | 59 +++++++++++++++++++ > > Please rename to samsung,s3fwrn5-i2c.yaml. > > > MAINTAINERS | 1 + > > 3 files changed, 60 insertions(+), 25 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt > > create mode 100644 Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt b/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt > > deleted file mode 100644 > > index f02f6fb7f81c..000000000000 > > --- a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt > > +++ /dev/null > > @@ -1,25 +0,0 @@ > > -* Samsung S3FWRN5 NCI NFC Controller > > - > > -Required properties: > > -- compatible: Should be "samsung,s3fwrn5-i2c". > > -- reg: address on the bus > > -- interrupts: GPIO interrupt to which the chip is connected > > -- s3fwrn5,en-gpios: Output GPIO pin used for enabling/disabling the chip > > -- s3fwrn5,fw-gpios: Output GPIO pin used to enter firmware mode and > > - sleep/wakeup control > > - > > -Example: > > - > > -&hsi2c_4 { > > - s3fwrn5@27 { > > - compatible = "samsung,s3fwrn5-i2c"; > > - > > - reg = <0x27>; > > - > > - interrupt-parent = <&gpa1>; > > - interrupts = <3 0 0>; > > - > > - s3fwrn5,en-gpios = <&gpf1 4 0>; > > - s3fwrn5,fw-gpios = <&gpj0 2 0>; > > - }; > > -}; > > diff --git a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml b/Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > > new file mode 100644 > > index 000000000000..c22451dea350 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > > @@ -0,0 +1,59 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/nfc/s3fwrn5.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Samsung S3FWRN5 NCI NFC Controller > > + > > +maintainers: > > + - Krzysztof Kozlowski > > + - Krzysztof Opasiak > > + > > +properties: > > + compatible: > > + const: samsung,s3fwrn5-i2c > > + > > + interrupts: > > + maxItems: 1 > > + > > + reg: > > + maxItems: 1 > > + > > + s3fwrn5,en-gpios: > > + maxItems: 1 > > + description: > > + Output GPIO pin used for enabling/disabling the chip > > + > > + s3fwrn5,fw-gpios: > > + maxItems: 1 > > + description: > > + Output GPIO pin used to enter firmware mode and sleep/wakeup control > > + > > +required: > > + - compatible > > + - interrupts > > + - reg > > + - s3fwrn5,en-gpios > > + - s3fwrn5,fw-gpios > > additionalProperties: false Sure, I'll fix both issues. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4604483959167109225==" MIME-Version: 1.0 From: Krzysztof Kozlowski To: linux-nfc@lists.01.org Subject: [linux-nfc] Re: [PATCH 1/4] dt-bindings: net: nfc: s3fwrn5: Convert to dtschema Date: Sun, 06 Sep 2020 16:38:53 +0200 Message-ID: In-Reply-To: 20200903163255.GA2903619@bogus --===============4604483959167109225== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu, 3 Sep 2020@18:33, Rob Herring wrote: > > On Sat, Aug 29, 2020@04:29:45PM +0200, Krzysztof Kozlowski wrote: > > Convert the Samsung S3FWRN5 NCI NFC controller bindings to dtschema. > > This is conversion only so it includes properties with invalid prefixes > > (s3fwrn5,en-gpios) which should be addressed later. > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > .../devicetree/bindings/net/nfc/s3fwrn5.txt | 25 -------- > > .../devicetree/bindings/net/nfc/s3fwrn5.yaml | 59 +++++++++++++++++++ > > Please rename to samsung,s3fwrn5-i2c.yaml. > > > MAINTAINERS | 1 + > > 3 files changed, 60 insertions(+), 25 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/net/nfc/s3fwrn5.t= xt > > create mode 100644 Documentation/devicetree/bindings/net/nfc/s3fwrn5.y= aml > > > > diff --git a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt b/Do= cumentation/devicetree/bindings/net/nfc/s3fwrn5.txt > > deleted file mode 100644 > > index f02f6fb7f81c..000000000000 > > --- a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt > > +++ /dev/null > > @@ -1,25 +0,0 @@ > > -* Samsung S3FWRN5 NCI NFC Controller > > - > > -Required properties: > > -- compatible: Should be "samsung,s3fwrn5-i2c". > > -- reg: address on the bus > > -- interrupts: GPIO interrupt to which the chip is connected > > -- s3fwrn5,en-gpios: Output GPIO pin used for enabling/disabling the ch= ip > > -- s3fwrn5,fw-gpios: Output GPIO pin used to enter firmware mode and > > - sleep/wakeup control > > - > > -Example: > > - > > -&hsi2c_4 { > > - s3fwrn5@27 { > > - compatible =3D "samsung,s3fwrn5-i2c"; > > - > > - reg =3D <0x27>; > > - > > - interrupt-parent =3D <&gpa1>; > > - interrupts =3D <3 0 0>; > > - > > - s3fwrn5,en-gpios =3D <&gpf1 4 0>; > > - s3fwrn5,fw-gpios =3D <&gpj0 2 0>; > > - }; > > -}; > > diff --git a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml b/D= ocumentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > > new file mode 100644 > > index 000000000000..c22451dea350 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > > @@ -0,0 +1,59 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/nfc/s3fwrn5.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Samsung S3FWRN5 NCI NFC Controller > > + > > +maintainers: > > + - Krzysztof Kozlowski > > + - Krzysztof Opasiak > > + > > +properties: > > + compatible: > > + const: samsung,s3fwrn5-i2c > > + > > + interrupts: > > + maxItems: 1 > > + > > + reg: > > + maxItems: 1 > > + > > + s3fwrn5,en-gpios: > > + maxItems: 1 > > + description: > > + Output GPIO pin used for enabling/disabling the chip > > + > > + s3fwrn5,fw-gpios: > > + maxItems: 1 > > + description: > > + Output GPIO pin used to enter firmware mode and sleep/wakeup con= trol > > + > > +required: > > + - compatible > > + - interrupts > > + - reg > > + - s3fwrn5,en-gpios > > + - s3fwrn5,fw-gpios > > additionalProperties: false Sure, I'll fix both issues. Best regards, Krzysztof --===============4604483959167109225==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5849C43461 for ; Sun, 6 Sep 2020 14:40:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79B0C20714 for ; Sun, 6 Sep 2020 14:40:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QbzwsA7A"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="etXM+rlB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79B0C20714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7qweqNWgR0rNMX7C47wwT2WOCBfY76FC1DRuZQCxi6E=; b=QbzwsA7AKFYi/1eI8fZ3Cb3+P Et3Rer3K5gxEIl0jXX4Bet58i0WuGACpL5NiqkuzI87dSE24m+ku3aYvolijC/gLe9NzKp0KEgMJr jgWTGoaSV5Lm/YHyczar+xNwoMoSsb+8jmSIax6JPynhShM4qMetIj/J/x58plWtQC4lGDNJlX0XT ewdjt1nviRCS3HQ9ETnWjHTi9m91jC7w3sW8+Hdk/CfiYCfiJr1hcLRGoUIW2pccNMwrIFUd3SWNY EuQiwQAUN4OD33gDBaNuRq6sD1iNQCQgjmmg2FUhDWhC/kRBM71lhETJJyPJwV44FydI9xK9wrzQI R9/TYCRMQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEvp3-0002TT-4s; Sun, 06 Sep 2020 14:39:13 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEvoz-0002T6-QD for linux-arm-kernel@lists.infradead.org; Sun, 06 Sep 2020 14:39:11 +0000 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 028232083E for ; Sun, 6 Sep 2020 14:39:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599403147; bh=7IEOIE7fQw9QHXmykxTiIVu886iDkKJ30802n3q5IwU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=etXM+rlB1+DW1J4jNFEGcm+fF67s78ieiIJMokib3gbJ/4axa/QC0n2G8dk5lqyab qBGZpGxKO4g23EzVrnLE9URUV/18btbD6jd7BioxTKQiRAZiF9j5rBoO60/0+AU19R QrrjUKSu0Uk6jLxywtE5Upy8feMDExtu7wnkOdM4= Received: by mail-ej1-f49.google.com with SMTP id i22so14548352eja.5 for ; Sun, 06 Sep 2020 07:39:06 -0700 (PDT) X-Gm-Message-State: AOAM532cWwN4M+OfrIya4J9U0tqgoLitCCkmnBt+h9YamTsTq5wykBuc hBNt9RVXs25xHxGcMPAOIoNtuVDuKBQsbuIcD3A= X-Google-Smtp-Source: ABdhPJwZbjzSkmXyfdB9RtLYvattBo3H9pni7matmcNuK/Qe1S1r3L8Nqgb9OFRwyrC4kvI+4viaz1GbEG+WoE49O3Y= X-Received: by 2002:a17:907:724f:: with SMTP id ds15mr16286701ejc.119.1599403145475; Sun, 06 Sep 2020 07:39:05 -0700 (PDT) MIME-Version: 1.0 References: <20200829142948.32365-1-krzk@kernel.org> <20200903163255.GA2903619@bogus> In-Reply-To: <20200903163255.GA2903619@bogus> From: Krzysztof Kozlowski Date: Sun, 6 Sep 2020 16:38:53 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/4] dt-bindings: net: nfc: s3fwrn5: Convert to dtschema To: Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200906_103910_070369_24DBCD7B X-CRM114-Status: GOOD ( 28.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, "linux-samsung-soc@vger.kernel.org" , linux-nfc@lists.01.org, Bartlomiej Zolnierkiewicz , Sylwester Nawrocki , netdev@vger.kernel.org, "linux-kernel@vger.kernel.org" , Inki Dae , Chanwoo Choi , Kukjin Kim , Krzysztof Opasiak , Jakub Kicinski , "David S. Miller" , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 3 Sep 2020 at 18:33, Rob Herring wrote: > > On Sat, Aug 29, 2020 at 04:29:45PM +0200, Krzysztof Kozlowski wrote: > > Convert the Samsung S3FWRN5 NCI NFC controller bindings to dtschema. > > This is conversion only so it includes properties with invalid prefixes > > (s3fwrn5,en-gpios) which should be addressed later. > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > .../devicetree/bindings/net/nfc/s3fwrn5.txt | 25 -------- > > .../devicetree/bindings/net/nfc/s3fwrn5.yaml | 59 +++++++++++++++++++ > > Please rename to samsung,s3fwrn5-i2c.yaml. > > > MAINTAINERS | 1 + > > 3 files changed, 60 insertions(+), 25 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt > > create mode 100644 Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt b/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt > > deleted file mode 100644 > > index f02f6fb7f81c..000000000000 > > --- a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt > > +++ /dev/null > > @@ -1,25 +0,0 @@ > > -* Samsung S3FWRN5 NCI NFC Controller > > - > > -Required properties: > > -- compatible: Should be "samsung,s3fwrn5-i2c". > > -- reg: address on the bus > > -- interrupts: GPIO interrupt to which the chip is connected > > -- s3fwrn5,en-gpios: Output GPIO pin used for enabling/disabling the chip > > -- s3fwrn5,fw-gpios: Output GPIO pin used to enter firmware mode and > > - sleep/wakeup control > > - > > -Example: > > - > > -&hsi2c_4 { > > - s3fwrn5@27 { > > - compatible = "samsung,s3fwrn5-i2c"; > > - > > - reg = <0x27>; > > - > > - interrupt-parent = <&gpa1>; > > - interrupts = <3 0 0>; > > - > > - s3fwrn5,en-gpios = <&gpf1 4 0>; > > - s3fwrn5,fw-gpios = <&gpj0 2 0>; > > - }; > > -}; > > diff --git a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml b/Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > > new file mode 100644 > > index 000000000000..c22451dea350 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > > @@ -0,0 +1,59 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/nfc/s3fwrn5.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Samsung S3FWRN5 NCI NFC Controller > > + > > +maintainers: > > + - Krzysztof Kozlowski > > + - Krzysztof Opasiak > > + > > +properties: > > + compatible: > > + const: samsung,s3fwrn5-i2c > > + > > + interrupts: > > + maxItems: 1 > > + > > + reg: > > + maxItems: 1 > > + > > + s3fwrn5,en-gpios: > > + maxItems: 1 > > + description: > > + Output GPIO pin used for enabling/disabling the chip > > + > > + s3fwrn5,fw-gpios: > > + maxItems: 1 > > + description: > > + Output GPIO pin used to enter firmware mode and sleep/wakeup control > > + > > +required: > > + - compatible > > + - interrupts > > + - reg > > + - s3fwrn5,en-gpios > > + - s3fwrn5,fw-gpios > > additionalProperties: false Sure, I'll fix both issues. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5296241818495432814==" MIME-Version: 1.0 From: Krzysztof Kozlowski To: linux-nfc@lists.01.org Subject: Re: [PATCH 1/4] dt-bindings: net: nfc: s3fwrn5: Convert to dtschema Date: Sun, 06 Sep 2020 16:38:53 +0200 Message-ID: In-Reply-To: <20200903163255.GA2903619@bogus> List-Id: --===============5296241818495432814== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu, 3 Sep 2020 at 18:33, Rob Herring wrote: > > On Sat, Aug 29, 2020 at 04:29:45PM +0200, Krzysztof Kozlowski wrote: > > Convert the Samsung S3FWRN5 NCI NFC controller bindings to dtschema. > > This is conversion only so it includes properties with invalid prefixes > > (s3fwrn5,en-gpios) which should be addressed later. > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > .../devicetree/bindings/net/nfc/s3fwrn5.txt | 25 -------- > > .../devicetree/bindings/net/nfc/s3fwrn5.yaml | 59 +++++++++++++++++++ > > Please rename to samsung,s3fwrn5-i2c.yaml. > > > MAINTAINERS | 1 + > > 3 files changed, 60 insertions(+), 25 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/net/nfc/s3fwrn5.t= xt > > create mode 100644 Documentation/devicetree/bindings/net/nfc/s3fwrn5.y= aml > > > > diff --git a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt b/Do= cumentation/devicetree/bindings/net/nfc/s3fwrn5.txt > > deleted file mode 100644 > > index f02f6fb7f81c..000000000000 > > --- a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.txt > > +++ /dev/null > > @@ -1,25 +0,0 @@ > > -* Samsung S3FWRN5 NCI NFC Controller > > - > > -Required properties: > > -- compatible: Should be "samsung,s3fwrn5-i2c". > > -- reg: address on the bus > > -- interrupts: GPIO interrupt to which the chip is connected > > -- s3fwrn5,en-gpios: Output GPIO pin used for enabling/disabling the ch= ip > > -- s3fwrn5,fw-gpios: Output GPIO pin used to enter firmware mode and > > - sleep/wakeup control > > - > > -Example: > > - > > -&hsi2c_4 { > > - s3fwrn5(a)27 { > > - compatible =3D "samsung,s3fwrn5-i2c"; > > - > > - reg =3D <0x27>; > > - > > - interrupt-parent =3D <&gpa1>; > > - interrupts =3D <3 0 0>; > > - > > - s3fwrn5,en-gpios =3D <&gpf1 4 0>; > > - s3fwrn5,fw-gpios =3D <&gpj0 2 0>; > > - }; > > -}; > > diff --git a/Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml b/D= ocumentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > > new file mode 100644 > > index 000000000000..c22451dea350 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/nfc/s3fwrn5.yaml > > @@ -0,0 +1,59 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/nfc/s3fwrn5.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Samsung S3FWRN5 NCI NFC Controller > > + > > +maintainers: > > + - Krzysztof Kozlowski > > + - Krzysztof Opasiak > > + > > +properties: > > + compatible: > > + const: samsung,s3fwrn5-i2c > > + > > + interrupts: > > + maxItems: 1 > > + > > + reg: > > + maxItems: 1 > > + > > + s3fwrn5,en-gpios: > > + maxItems: 1 > > + description: > > + Output GPIO pin used for enabling/disabling the chip > > + > > + s3fwrn5,fw-gpios: > > + maxItems: 1 > > + description: > > + Output GPIO pin used to enter firmware mode and sleep/wakeup con= trol > > + > > +required: > > + - compatible > > + - interrupts > > + - reg > > + - s3fwrn5,en-gpios > > + - s3fwrn5,fw-gpios > > additionalProperties: false Sure, I'll fix both issues. Best regards, Krzysztof --===============5296241818495432814==--