From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C2DFC76186 for ; Wed, 17 Jul 2019 09:08:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 50E522077C for ; Wed, 17 Jul 2019 09:08:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563354508; bh=4vu4Okxb5WZcflRFF6tQdhHwvtvePiCyc0cLWLfo7E0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=il4hP4eLTrGmJu7JgqSdJV960dOA/x4z+tlPsuqGWJBz9HOkG9KAgAPyh5jNB79oK MbbNfku9yz1RD8JoCdKuwkFg9kuB5IIF6RbAGsoGWPoG057Nwx63atvpXczI63wYV+ WAm/ACssNMLu00hxnsjT4iAokxP1jtIhw53WOvQw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730888AbfGQJI0 (ORCPT ); Wed, 17 Jul 2019 05:08:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:45350 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726380AbfGQJIZ (ORCPT ); Wed, 17 Jul 2019 05:08:25 -0400 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 51F502077C; Wed, 17 Jul 2019 09:08:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563354504; bh=4vu4Okxb5WZcflRFF6tQdhHwvtvePiCyc0cLWLfo7E0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=RALEPS5CHWpeiDfu+HsvmOaOtvbO5k1yXwr0S9XTymblJwDF6sHvV4gEFnM2bVK9j yKQMewHedSijshe748912a1/XBQpOFpER3JlkGbAUAI0kxVSMiGP7AzuAWb+5Y5IyL Qh+O+M84QxD+z/qPh2CYiANXO29KI04JSGWeFggE= Received: by mail-lf1-f54.google.com with SMTP id q26so15878610lfc.3; Wed, 17 Jul 2019 02:08:24 -0700 (PDT) X-Gm-Message-State: APjAAAU0XUJ6xSvg4HhNSZVVu2G/t6K8+Up57poQKMjmikFKEf3A5q59 WHqBCXQ5ji9eJG/Rlpbv/ftQTuB+I+k6hS+pGNc= X-Google-Smtp-Source: APXvYqzPzGPDBYSh581qW48n1T0W9q70m0vdtu/7IVr2GTIxxD6DYirb0vG3PGSnLIb3eXrPmw69lCfnIFHh/iYbG8w= X-Received: by 2002:ac2:4d1c:: with SMTP id r28mr16685179lfi.159.1563354502661; Wed, 17 Jul 2019 02:08:22 -0700 (PDT) MIME-Version: 1.0 References: <20190715124417.4787-1-l.luba@partner.samsung.com> <20190715124417.4787-24-l.luba@partner.samsung.com> In-Reply-To: <20190715124417.4787-24-l.luba@partner.samsung.com> From: Krzysztof Kozlowski Date: Wed, 17 Jul 2019 11:08:11 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 23/50] ARM: dts: exynos: change lowest OPP in bus_disp1_fimd in Exynos5420 To: Lukasz Luba Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , linux-clk@vger.kernel.org, mturquette@baylibre.com, sboyd@kernel.org, =?UTF-8?B?QmFydMWCb21pZWogxbtvxYJuaWVya2lld2ljeg==?= , kgene@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org, Chanwoo Choi , kyungmin.park@samsung.com, Andrzej Hajda , Marek Szyprowski , s.nawrocki@samsung.com, myungjoo.ham@samsung.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Jul 2019 at 14:44, Lukasz Luba wrote: > > The lowest OPP must be aligned to possible value after division of parent > clock rate. Thus, change it to the value which is true for clock 1200MHz. I think this is getting slightly too granular. It seems you are solving the same problem (or very small subset of the same problem) as in patch 22: https://patchwork.kernel.org/patch/11043849/ Please combine such changes per IP block, unless you have really reproducible different issues (e.g. reproducible different performance problem or OOPS, but not just what clk_summary prints). I imagine that you align entire subsystem (DISP) buses to real clock frequencies (or to match real frequencies, or to achieve more granular scaling, or to get slightly better performance). Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0AB0C76192 for ; Wed, 17 Jul 2019 09:08:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 754862077C for ; Wed, 17 Jul 2019 09:08:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LPWOFE7G"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="RALEPS5C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 754862077C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k8cmgdZHSoT/QcR4qFbhsjk8BYTk7GvJlOKwCAJrghE=; b=LPWOFE7G/VTA5a Q1oVq66lORT8IXJnQQ/xMe2+/RTNOoNsM9rAJF0WWSsomKy//4GdhkQXSxOqUCVaTo+MVIVxYlOa1 S792DjOVPv8+hmCQIPfxV1MDrdEmpSB8s+80IA4zfW4snLGvEUAAsuvNQcT7A3of7rOYZp62fKE0a dE/KjFYam1GnbvVSe1z1mdO//JG0PWFcg+umHdRHnK3Tf0j1wQo15lWaKqSrm3pFnFYKfnHIjhaUW RRm1jabNKRN6nsKz1FZNEctYYdBYcXIxulgiq2qgHDpO0yuHwjUSS+JF5yPKTY7ZcRytLgs+ax97E Zc1aMN8dXESH1T+lolJA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hnfvI-0007Br-Nw; Wed, 17 Jul 2019 09:08:28 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hnfvF-0007Ay-53 for linux-arm-kernel@lists.infradead.org; Wed, 17 Jul 2019 09:08:26 +0000 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 700AC21850 for ; Wed, 17 Jul 2019 09:08:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563354504; bh=4vu4Okxb5WZcflRFF6tQdhHwvtvePiCyc0cLWLfo7E0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=RALEPS5CHWpeiDfu+HsvmOaOtvbO5k1yXwr0S9XTymblJwDF6sHvV4gEFnM2bVK9j yKQMewHedSijshe748912a1/XBQpOFpER3JlkGbAUAI0kxVSMiGP7AzuAWb+5Y5IyL Qh+O+M84QxD+z/qPh2CYiANXO29KI04JSGWeFggE= Received: by mail-lf1-f49.google.com with SMTP id r15so10978596lfm.11 for ; Wed, 17 Jul 2019 02:08:24 -0700 (PDT) X-Gm-Message-State: APjAAAUPew0JKEb9p8yGuRHW4mX0Q7uT2ywqWFFV2B3pRKNw15zJOMcj RgiHG24UuQij2OSl+bRmOBDwbvowH56XDn70X34= X-Google-Smtp-Source: APXvYqzPzGPDBYSh581qW48n1T0W9q70m0vdtu/7IVr2GTIxxD6DYirb0vG3PGSnLIb3eXrPmw69lCfnIFHh/iYbG8w= X-Received: by 2002:ac2:4d1c:: with SMTP id r28mr16685179lfi.159.1563354502661; Wed, 17 Jul 2019 02:08:22 -0700 (PDT) MIME-Version: 1.0 References: <20190715124417.4787-1-l.luba@partner.samsung.com> <20190715124417.4787-24-l.luba@partner.samsung.com> In-Reply-To: <20190715124417.4787-24-l.luba@partner.samsung.com> From: Krzysztof Kozlowski Date: Wed, 17 Jul 2019 11:08:11 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 23/50] ARM: dts: exynos: change lowest OPP in bus_disp1_fimd in Exynos5420 To: Lukasz Luba X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190717_020825_215634_27C7146E X-CRM114-Status: GOOD ( 11.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, "linux-samsung-soc@vger.kernel.org" , =?UTF-8?B?QmFydMWCb21pZWogxbtvxYJuaWVya2lld2ljeg==?= , sboyd@kernel.org, mturquette@baylibre.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Andrzej Hajda , Chanwoo Choi , kyungmin.park@samsung.com, kgene@kernel.org, myungjoo.ham@samsung.com, s.nawrocki@samsung.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 15 Jul 2019 at 14:44, Lukasz Luba wrote: > > The lowest OPP must be aligned to possible value after division of parent > clock rate. Thus, change it to the value which is true for clock 1200MHz. I think this is getting slightly too granular. It seems you are solving the same problem (or very small subset of the same problem) as in patch 22: https://patchwork.kernel.org/patch/11043849/ Please combine such changes per IP block, unless you have really reproducible different issues (e.g. reproducible different performance problem or OOPS, but not just what clk_summary prints). I imagine that you align entire subsystem (DISP) buses to real clock frequencies (or to match real frequencies, or to achieve more granular scaling, or to get slightly better performance). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel