From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v3 01/13] soc: samsung: pmu: Provide global function to get PMU regmap Date: Thu, 26 Jan 2017 16:41:55 +0200 Message-ID: References: <1484833733-16082-1-git-send-email-m.szyprowski@samsung.com> <1484833733-16082-2-git-send-email-m.szyprowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail.kernel.org ([198.145.29.136]:40188 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752788AbdAZOmG (ORCPT ); Thu, 26 Jan 2017 09:42:06 -0500 In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij Cc: Marek Szyprowski , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-pm@vger.kernel.org" , linux-samsung-soc , Sylwester Nawrocki , Tomasz Figa , Bartlomiej Zolnierkiewicz On Thu, Jan 26, 2017 at 11:43 AM, Linus Walleij wrote: > On Thu, Jan 19, 2017 at 2:48 PM, Marek Szyprowski > wrote: > >> PMU is something like a SoC wide service, so add a helper function to get >> PMU regmap. This will be used by other Exynos device drivers. This way it >> can be avoided to model this dependency in device tree (as phandles to PMU >> node) for almost every device in the SoC. >> >> Signed-off-by: Marek Szyprowski >> Reviewed-by: Tomasz Figa > > But why? I could understand it as a local header in > drivers/soc/samsung/*.h for those files. Marek gave quite detailed answer... so let me just add minor note. Apparently we cannot satisfy everyone. When break the DT ABI, DT people are not happy. When we try to avoid ABI break, we create such dependency. In fact, such compile and runtime dependency is not unusual. Our drivers are coupled because our hardware modules are coupled. When they were put in arch/arm/mach-exynos, no one cared because everything was contained in mach-exynos. We try to move the code out of there thus we need to model such dependencies in a new way... or break the DT ABI. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: krzk@kernel.org (Krzysztof Kozlowski) Date: Thu, 26 Jan 2017 16:41:55 +0200 Subject: [PATCH v3 01/13] soc: samsung: pmu: Provide global function to get PMU regmap In-Reply-To: References: <1484833733-16082-1-git-send-email-m.szyprowski@samsung.com> <1484833733-16082-2-git-send-email-m.szyprowski@samsung.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jan 26, 2017 at 11:43 AM, Linus Walleij wrote: > On Thu, Jan 19, 2017 at 2:48 PM, Marek Szyprowski > wrote: > >> PMU is something like a SoC wide service, so add a helper function to get >> PMU regmap. This will be used by other Exynos device drivers. This way it >> can be avoided to model this dependency in device tree (as phandles to PMU >> node) for almost every device in the SoC. >> >> Signed-off-by: Marek Szyprowski >> Reviewed-by: Tomasz Figa > > But why? I could understand it as a local header in > drivers/soc/samsung/*.h for those files. Marek gave quite detailed answer... so let me just add minor note. Apparently we cannot satisfy everyone. When break the DT ABI, DT people are not happy. When we try to avoid ABI break, we create such dependency. In fact, such compile and runtime dependency is not unusual. Our drivers are coupled because our hardware modules are coupled. When they were put in arch/arm/mach-exynos, no one cared because everything was contained in mach-exynos. We try to move the code out of there thus we need to model such dependencies in a new way... or break the DT ABI. Best regards, Krzysztof