All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Chanho Park <chanho61.park@samsung.com>
Cc: Linus Walleij <linus.walleij@linaro.org>, linux-gpio@vger.kernel.org
Subject: Re: [pinctrl:devel 32/33] drivers/pinctrl/samsung/pinctrl-s3c64xx.c:296:25: error: passing argument 1 of 'spin_unlock_irqrestore' from incompatible pointer type
Date: Tue, 26 Jan 2021 09:21:40 +0100	[thread overview]
Message-ID: <CAJKOXPeht+rL0Epd4jsQLgw=Yg70+gHKMSw4m1xwdvp5pO6mqg@mail.gmail.com> (raw)
In-Reply-To: <000001d6f377$6c1b3af0$4451b0d0$@samsung.com>

On Tue, 26 Jan 2021 at 01:08, Chanho Park <chanho61.park@samsung.com> wrote:
>
> >         git fetch --no-tags pinctrl devel
> >         git checkout 1f306ecbe0f66681bd87a2bb9013630233a32f7f
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
> > ARCH=c6x
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> >    In file included from include/linux/wait.h:9,
> >                     from include/linux/pid.h:6,
> >                     from include/linux/sched.h:14,
> >                     from include/linux/ratelimit.h:6,
> >                     from include/linux/dev_printk.h:16,
> >                     from include/linux/device.h:15,
> >                     from drivers/pinctrl/samsung/pinctrl-s3c64xx.c:14:
> >    drivers/pinctrl/samsung/pinctrl-s3c64xx.c: In function
> > 's3c64xx_irq_set_function':
> > >> drivers/pinctrl/samsung/pinctrl-s3c64xx.c:289:20: error: passing
> > >> argument 1 of 'spinlock_check' from incompatible pointer type
> > >> [-Werror=incompatible-pointer-types]
> >      289 |  spin_lock_irqsave(&bank->slock, flags);
> >          |                    ^~~~~~~~~~~~
> >          |                    |
> >          |                    raw_spinlock_t * {aka struct raw_spinlock *}
> >    include/linux/spinlock.h:252:34: note: in definition of macro
> > 'raw_spin_lock_irqsave'
> >      252 |   flags = _raw_spin_lock_irqsave(lock); \
> >          |                                  ^~~~
> >    drivers/pinctrl/samsung/pinctrl-s3c64xx.c:289:2: note: in expansion of
> > macro 'spin_lock_irqsave'
> >      289 |  spin_lock_irqsave(&bank->slock, flags);
> >          |  ^~~~~~~~~~~~~~~~~
> >    In file included from include/linux/wait.h:9,
> >                     from include/linux/pid.h:6,
> >                     from include/linux/sched.h:14,
> >                     from include/linux/ratelimit.h:6,
> >                     from include/linux/dev_printk.h:16,
> >                     from include/linux/device.h:15,
> >                     from drivers/pinctrl/samsung/pinctrl-s3c64xx.c:14:
> >    include/linux/spinlock.h:327:67: note: expected 'spinlock_t *' {aka
> > 'struct spinlock *'} but argument is of type 'raw_spinlock_t *' {aka
> > 'struct raw_spinlock *'}
> >      327 | static __always_inline raw_spinlock_t
> *spinlock_check(spinlock_t
> > *lock)
> >          |
> ~~~~~~~~~~~~^~~~
> > >> drivers/pinctrl/samsung/pinctrl-s3c64xx.c:296:25: error: passing
> > >> argument 1 of 'spin_unlock_irqrestore' from incompatible pointer type
> > >> [-Werror=incompatible-pointer-types]
> >      296 |  spin_unlock_irqrestore(&bank->slock, flags);
> >          |                         ^~~~~~~~~~~~
> >          |                         |
> >          |                         raw_spinlock_t * {aka struct
> raw_spinlock *}
> >    In file included from include/linux/wait.h:9,
> >                     from include/linux/pid.h:6,
> >                     from include/linux/sched.h:14,
> >                     from include/linux/ratelimit.h:6,
> >                     from include/linux/dev_printk.h:16,
> >                     from include/linux/device.h:15,
> >                     from drivers/pinctrl/samsung/pinctrl-s3c64xx.c:14:
> >    include/linux/spinlock.h:407:64: note: expected 'spinlock_t *' {aka
> > 'struct spinlock *'} but argument is of type 'raw_spinlock_t *' {aka
> > 'struct raw_spinlock *'}
> >      407 | static __always_inline void spin_unlock_irqrestore(spinlock_t
> > *lock, unsigned long flags)
> >          |
> ~~~~~~~~~~~~^~~~
> >    cc1: some warnings being treated as errors
> >
> >
>
> Hi Linus,
>
> I was not aware PINCTRL_S3C64XX because it's not enabled in
> s3c6410_defconfig.
> Please pick the v2 patch. Sorry for the inconvenience.

For arm:
make allyesconfig
make -j4 drivers/pinctrl/samsung/

and indeed it does not compile...

Best regards,
Krzysztof

  reply	other threads:[~2021-01-26 18:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210125232704epcas2p4f362849a8f5e85f46d406d20b7983429@epcas2p4.samsung.com>
2021-01-25 23:26 ` [pinctrl:devel 32/33] drivers/pinctrl/samsung/pinctrl-s3c64xx.c:296:25: error: passing argument 1 of 'spin_unlock_irqrestore' from incompatible pointer type kernel test robot
2021-01-25 23:26   ` kernel test robot
2021-01-26  0:08   ` Chanho Park
2021-01-26  8:21     ` Krzysztof Kozlowski [this message]
2021-01-26 15:05     ` Linus Walleij
2021-01-27  2:18       ` Chanho Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJKOXPeht+rL0Epd4jsQLgw=Yg70+gHKMSw4m1xwdvp5pO6mqg@mail.gmail.com' \
    --to=krzk@kernel.org \
    --cc=chanho61.park@samsung.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.