From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752865AbbJLXta (ORCPT ); Mon, 12 Oct 2015 19:49:30 -0400 Received: from mail-qg0-f45.google.com ([209.85.192.45]:36788 "EHLO mail-qg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751950AbbJLXt2 (ORCPT ); Mon, 12 Oct 2015 19:49:28 -0400 MIME-Version: 1.0 In-Reply-To: <561C0589.7010103@kernel.org> References: <1444653438-6532-1-git-send-email-alim.akhtar@samsung.com> <561BAFE0.5070205@samsung.com> <561C0589.7010103@kernel.org> Date: Tue, 13 Oct 2015 08:49:27 +0900 X-Google-Sender-Auth: bMS3UXVbIORKiYyNYtHinmXUdtI Message-ID: Subject: Re: [PATCH v2] arm: dts: Fix audio card detection on peach boards From: Krzysztof Kozlowski To: Kukjin Kim Cc: Krzysztof Kozlowski , Alim Akhtar , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, dianders@chromium.org, stable@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2015-10-13 4:10 GMT+09:00 Kukjin Kim : > On 10/12/15 22:04, Krzysztof Kozlowski wrote: >> W dniu 12.10.2015 o 21:37, Alim Akhtar pisze: >>> Since commit 2fad972d45c4 ("ARM: dts: Add mclk entry for Peach boards"), >>> sound card detection is broken on peach boards and gives below errors: >>> >>> [ 3.630457] max98090 7-0010: MAX98091 REVID=0x51 >>> [ 3.634233] max98090 7-0010: use default 2.8v micbias >>> [ 3.640985] snow-audio sound: HiFi <-> 3830000.i2s mapping ok >>> [ 3.645307] max98090 7-0010: Invalid master clock frequency >>> [ 3.650824] snow-audio sound: ASoC: Peach-Pi-I2S-MAX98091 late_probe() failed: -22 >>> [ 3.658914] snow-audio sound: snd_soc_register_card failed (-22) >>> [ 3.664366] snow-audio: probe of sound failed with error -22 >>> >>> This patch adds missing assigned-clocks and assigned-clock-parents for >>> pmu_system_controller node which is used as "mclk" for audio codec. >>> >>> Signed-off-by: Alim Akhtar >>> Fixes: 2fad972d45c4 ("ARM: dts: Add mclk entry for Peach boards") >>> Cc: >>> --- >>> Changes since v1: >>> Addressed Krzysztof's review comments. >> >> Looks good, thanks! >> >> Reviewed-by: Krzysztof Kozlowski >> > Applied, thanks. I see you pulled that one and of_node_put() fix into fixes. Thanks! Can you apply also Sudip's fix for thermal (acked by Lukasz)? I have it my try but since you applied these two already it does not have sense any more. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Tue, 13 Oct 2015 08:49:27 +0900 Subject: [PATCH v2] arm: dts: Fix audio card detection on peach boards In-Reply-To: <561C0589.7010103@kernel.org> References: <1444653438-6532-1-git-send-email-alim.akhtar@samsung.com> <561BAFE0.5070205@samsung.com> <561C0589.7010103@kernel.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 2015-10-13 4:10 GMT+09:00 Kukjin Kim : > On 10/12/15 22:04, Krzysztof Kozlowski wrote: >> W dniu 12.10.2015 o 21:37, Alim Akhtar pisze: >>> Since commit 2fad972d45c4 ("ARM: dts: Add mclk entry for Peach boards"), >>> sound card detection is broken on peach boards and gives below errors: >>> >>> [ 3.630457] max98090 7-0010: MAX98091 REVID=0x51 >>> [ 3.634233] max98090 7-0010: use default 2.8v micbias >>> [ 3.640985] snow-audio sound: HiFi <-> 3830000.i2s mapping ok >>> [ 3.645307] max98090 7-0010: Invalid master clock frequency >>> [ 3.650824] snow-audio sound: ASoC: Peach-Pi-I2S-MAX98091 late_probe() failed: -22 >>> [ 3.658914] snow-audio sound: snd_soc_register_card failed (-22) >>> [ 3.664366] snow-audio: probe of sound failed with error -22 >>> >>> This patch adds missing assigned-clocks and assigned-clock-parents for >>> pmu_system_controller node which is used as "mclk" for audio codec. >>> >>> Signed-off-by: Alim Akhtar >>> Fixes: 2fad972d45c4 ("ARM: dts: Add mclk entry for Peach boards") >>> Cc: >>> --- >>> Changes since v1: >>> Addressed Krzysztof's review comments. >> >> Looks good, thanks! >> >> Reviewed-by: Krzysztof Kozlowski >> > Applied, thanks. I see you pulled that one and of_node_put() fix into fixes. Thanks! Can you apply also Sudip's fix for thermal (acked by Lukasz)? I have it my try but since you applied these two already it does not have sense any more. Best regards, Krzysztof