From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5B64C433E0 for ; Thu, 24 Dec 2020 09:19:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 679412225E for ; Thu, 24 Dec 2020 09:19:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727270AbgLXJTc (ORCPT ); Thu, 24 Dec 2020 04:19:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:33152 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726258AbgLXJTb (ORCPT ); Thu, 24 Dec 2020 04:19:31 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id A85112225E; Thu, 24 Dec 2020 09:18:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1608801530; bh=GrZBQnU+qs+9KKvyhKv76m1eyHbFM5iOSlMTcbWXJOg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=kAil0DY9Y5UR2hbGOAzuVrsZ85YxbruYDSjFTS2Q8meg4HytCM+razeOZv6Z/Ps7y 9Vtlm13EkiAIDWTr6sX8daOG9a6sevttfAt0Gzi9KymKL7NeW5DXHGtFNalInm5iB6 ONpxaQyu8RcszuRJ7dEuJPOm7roKtHmk+Mj0squPGF5K1b37LbcR8sHZaFadnmNtmk N5jd01k73qZfZkaRm45FQjNRht4NqsZv6xeL8DApVrmOpthH5sVyTk5kOnIhIkkoiH MkAds58gSi2hlp9CSqYm2VdKFUdMGXOXk0ArVtvqiSRczI7cYlsNO/LQ+XjZrti0tv MlhEDRJyNQB3g== Received: by mail-ej1-f45.google.com with SMTP id g20so2642371ejb.1; Thu, 24 Dec 2020 01:18:49 -0800 (PST) X-Gm-Message-State: AOAM531T5b4LVOCgsVAY2I9RHCyzcj0pyiPFooahYmepe5BpHCqHpoG3 oVX0FxdUbylQkwEJEXuD4+g0PGgVaoJTls/fDuA= X-Google-Smtp-Source: ABdhPJwAQg0S1MOOurh2CiV95fqh0bRtne1MLee1I3LcHv9JUaRf2XvE22Hb8eMqRu8k7od2nyrVM5xGqeeG4XPfAhk= X-Received: by 2002:a17:906:158c:: with SMTP id k12mr9315554ejd.119.1608801528194; Thu, 24 Dec 2020 01:18:48 -0800 (PST) MIME-Version: 1.0 References: <20201223110343.126638-1-jagan@amarulasolutions.com> <20201223110343.126638-5-jagan@amarulasolutions.com> <20201223115933.GC21091@kozik-lap> In-Reply-To: From: Krzysztof Kozlowski Date: Thu, 24 Dec 2020 10:18:36 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 4/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0 To: Jagan Teki Cc: Rob Herring , Shawn Guo , Li Yang , Fabio Estevam , devicetree , linux-kernel , linux-arm-kernel , NXP Linux Team , linux-amarula , Catalin Marinas , Will Deacon , Matteo Lisi Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 23 Dec 2020 at 13:07, Jagan Teki wrote: > > On Wed, Dec 23, 2020 at 5:29 PM Krzysztof Kozlowski wrote: > > > > On Wed, Dec 23, 2020 at 04:33:41PM +0530, Jagan Teki wrote: > > > Engicam C.TOUCH 2.0 is an EDIMM compliant general purpose Carrier > > > board. > > > > > > Genaral features: > > > - Ethernet 10/100 > > > - Wifi/BT > > > - USB Type A/OTG > > > - Audio Out > > > - CAN > > > - LVDS panel connector > > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam. > > > > > > i.Core MX8M Mini needs to mount on top of this Carrier board for > > > creating complete i.Core MX8M Mini C.TOUCH 2.0 board. > > > > > > Add support for it. > > > > > > Signed-off-by: Matteo Lisi > > > Signed-off-by: Jagan Teki > > > --- > > > Changes for v3: > > > - don't maintain common nodes and include it, if no feature diff > > > Changes for v2: > > > - enabled fec1 node > > > - updated commit message > > > - dropped engicam from filename since it aligned with imx6 engicam > > > dts files naming conventions. > > > - add i2c nodes > > > - fixed v1 comments > > > > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > > .../dts/freescale/imx8mm-engicam-ctouch2.dtsi | 82 +++++++++++++++++++ > > > .../freescale/imx8mm-icore-mx8mm-ctouch2.dts | 21 +++++ > > > 3 files changed, 104 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-ctouch2.dtsi > > > > You split some common part to ctouch2.dtsi so it can be reused in > > multiple places. I saw so far only one usage, where are the others? > > To be clear, ctouch2.dtsi not mean for common it is C.TOUCH2 carrier > board dtsi. The other carrier is C.TOUCH2 10.1" Open Frame(display), > since DSI is not yet mainlined, I didn't add this yet. If I understand correctly: it is a DTSI which is included only by one DTS... and DTS does not have any other nodes. This as well is not the design which makes any sense. We do not create empty DTS files which only include one more DTSI. The contents of imx8mm-engicam-ctouch2.dtsi should be directly in imx8mm-icore-mx8mm-ctouch2.dts. That's the same problem as with v1 - you overcomplicate simple stuff. It really looks like you ignored the comments from v1 in multiple places. The same applies to imx8mm-engicam-edimm2.2.dtsi. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67A51C433DB for ; Thu, 24 Dec 2020 09:20:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1757A2225E for ; Thu, 24 Dec 2020 09:20:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1757A2225E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=raTFhUVXLOTWKLTafZ3nV9M5ydXmRVvJg4ekJJCpph4=; b=hEj37JGyY3Msr95IDd0QnY3o0 h7xxMnSlKmttYGHOZ1nytCxyfwRkA0UEs6uC+JbNzAH3wK3VIODXnMnRxL5vBTXw5PIz8FfQxga/9 +A31/kjzg9Mcwll9LniVGGo9otA2rF/Oyw90KzgtFLBMnfJK29b9rzBLC8/mF8zblQURHvFoiyxqO Ia2IpWD5OBgINEZiOcF1EIzfE4CvFSTYYRmDSxe6Wd1LEwn5ryXPDTZYUXStkl8QzfwPWm+0sxJr7 VXK/v4HmYrXLjNz2ppfLJy/juHnYeontTF+kqnwgtOnX4DYrIWv++JT7fIvzZCGgsSx13PYEmk+k5 ZmYMvRgVQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ksMlr-0004Gv-Fx; Thu, 24 Dec 2020 09:18:55 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ksMlo-0004GS-34 for linux-arm-kernel@lists.infradead.org; Thu, 24 Dec 2020 09:18:52 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id B929922AAC for ; Thu, 24 Dec 2020 09:18:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1608801530; bh=GrZBQnU+qs+9KKvyhKv76m1eyHbFM5iOSlMTcbWXJOg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=kAil0DY9Y5UR2hbGOAzuVrsZ85YxbruYDSjFTS2Q8meg4HytCM+razeOZv6Z/Ps7y 9Vtlm13EkiAIDWTr6sX8daOG9a6sevttfAt0Gzi9KymKL7NeW5DXHGtFNalInm5iB6 ONpxaQyu8RcszuRJ7dEuJPOm7roKtHmk+Mj0squPGF5K1b37LbcR8sHZaFadnmNtmk N5jd01k73qZfZkaRm45FQjNRht4NqsZv6xeL8DApVrmOpthH5sVyTk5kOnIhIkkoiH MkAds58gSi2hlp9CSqYm2VdKFUdMGXOXk0ArVtvqiSRczI7cYlsNO/LQ+XjZrti0tv MlhEDRJyNQB3g== Received: by mail-ej1-f46.google.com with SMTP id q22so2629723eja.2 for ; Thu, 24 Dec 2020 01:18:49 -0800 (PST) X-Gm-Message-State: AOAM5319jGMj7DXU5oAL/LaS2moUyplcWpiX7VdGI841kw5fCqD/mvDC u7orvbHw24OyRIdGGfD+xKfQ/iWaNM9+2HfIgls= X-Google-Smtp-Source: ABdhPJwAQg0S1MOOurh2CiV95fqh0bRtne1MLee1I3LcHv9JUaRf2XvE22Hb8eMqRu8k7od2nyrVM5xGqeeG4XPfAhk= X-Received: by 2002:a17:906:158c:: with SMTP id k12mr9315554ejd.119.1608801528194; Thu, 24 Dec 2020 01:18:48 -0800 (PST) MIME-Version: 1.0 References: <20201223110343.126638-1-jagan@amarulasolutions.com> <20201223110343.126638-5-jagan@amarulasolutions.com> <20201223115933.GC21091@kozik-lap> In-Reply-To: From: Krzysztof Kozlowski Date: Thu, 24 Dec 2020 10:18:36 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 4/6] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0 To: Jagan Teki X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201224_041852_288695_ED15F7B5 X-CRM114-Status: GOOD ( 23.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Matteo Lisi , Will Deacon , Shawn Guo , linux-kernel , Li Yang , Rob Herring , NXP Linux Team , Catalin Marinas , Fabio Estevam , linux-amarula , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 23 Dec 2020 at 13:07, Jagan Teki wrote: > > On Wed, Dec 23, 2020 at 5:29 PM Krzysztof Kozlowski wrote: > > > > On Wed, Dec 23, 2020 at 04:33:41PM +0530, Jagan Teki wrote: > > > Engicam C.TOUCH 2.0 is an EDIMM compliant general purpose Carrier > > > board. > > > > > > Genaral features: > > > - Ethernet 10/100 > > > - Wifi/BT > > > - USB Type A/OTG > > > - Audio Out > > > - CAN > > > - LVDS panel connector > > > > > > i.Core MX8M Mini is an EDIMM SoM based on NXP i.MX8M Mini from Engicam. > > > > > > i.Core MX8M Mini needs to mount on top of this Carrier board for > > > creating complete i.Core MX8M Mini C.TOUCH 2.0 board. > > > > > > Add support for it. > > > > > > Signed-off-by: Matteo Lisi > > > Signed-off-by: Jagan Teki > > > --- > > > Changes for v3: > > > - don't maintain common nodes and include it, if no feature diff > > > Changes for v2: > > > - enabled fec1 node > > > - updated commit message > > > - dropped engicam from filename since it aligned with imx6 engicam > > > dts files naming conventions. > > > - add i2c nodes > > > - fixed v1 comments > > > > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > > .../dts/freescale/imx8mm-engicam-ctouch2.dtsi | 82 +++++++++++++++++++ > > > .../freescale/imx8mm-icore-mx8mm-ctouch2.dts | 21 +++++ > > > 3 files changed, 104 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-ctouch2.dtsi > > > > You split some common part to ctouch2.dtsi so it can be reused in > > multiple places. I saw so far only one usage, where are the others? > > To be clear, ctouch2.dtsi not mean for common it is C.TOUCH2 carrier > board dtsi. The other carrier is C.TOUCH2 10.1" Open Frame(display), > since DSI is not yet mainlined, I didn't add this yet. If I understand correctly: it is a DTSI which is included only by one DTS... and DTS does not have any other nodes. This as well is not the design which makes any sense. We do not create empty DTS files which only include one more DTSI. The contents of imx8mm-engicam-ctouch2.dtsi should be directly in imx8mm-icore-mx8mm-ctouch2.dts. That's the same problem as with v1 - you overcomplicate simple stuff. It really looks like you ignored the comments from v1 in multiple places. The same applies to imx8mm-engicam-edimm2.2.dtsi. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel