From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7DDAC4727C for ; Tue, 29 Sep 2020 09:19:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46BE920897 for ; Tue, 29 Sep 2020 09:19:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601371142; bh=7d9m8YtmM0oZBYPyOHbYl7Ajwa8TOm2mgFhI2B2FaTY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=kS7It4qEz4hdWW+png/y2VLbH0cpqgzoQqlnWm1nXDt6Chx81ztmF0xHK/C0jK0cd h18YNrgvGI8eb0IvFmJLWkoTL4W/4BpuLCicOQMF4pu2cSHhrcbkCRecfcSZmx41/M 1a1DCPL7f4MqjEzFifO/eZ0y4LyYWekCnenDN3bQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728012AbgI2JTB (ORCPT ); Tue, 29 Sep 2020 05:19:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:40618 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727781AbgI2JTB (ORCPT ); Tue, 29 Sep 2020 05:19:01 -0400 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E734420C09; Tue, 29 Sep 2020 09:18:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601371140; bh=7d9m8YtmM0oZBYPyOHbYl7Ajwa8TOm2mgFhI2B2FaTY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=QCn0viO1E7fFEdHcrG7XpKuS95w0MxGkvORWGZ4t8rgF0qiA1+8nlhMIYTEzkHgKO tMS3ZAI+vnstBUhPaeajoxZcysKp/06r7djzKNzINavjuKE453czOsxSWsXsDnekBQ 3xwjgzTsTovs86xQb71msEABZM9wIK1RIrNEOwVk= Received: by mail-ej1-f43.google.com with SMTP id i26so13940200ejb.12; Tue, 29 Sep 2020 02:18:59 -0700 (PDT) X-Gm-Message-State: AOAM53181Mc47J8DKcZFghPN05OTCHF2YApuw7uNePPXbnKPgMW47C84 wRR8rc3I0CfFCiH+qd2pO6pMjG21SvxzuU2indY= X-Google-Smtp-Source: ABdhPJxGllGR2UiacyCTtjrgcZvi5cZtvrKkih45ZyLS0pOKgdvpZZMzMI6hYkQvt1+O3W0WIqLB4Ct0t3vT/qbhxdg= X-Received: by 2002:a17:906:8401:: with SMTP id n1mr2757814ejx.215.1601371138361; Tue, 29 Sep 2020 02:18:58 -0700 (PDT) MIME-Version: 1.0 References: <20200923152129.21736-1-krzk@kernel.org> <20200929091512.GF26842@paasikivi.fi.intel.com> In-Reply-To: <20200929091512.GF26842@paasikivi.fi.intel.com> From: Krzysztof Kozlowski Date: Tue, 29 Sep 2020 11:18:46 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 1/4] dt-bindings: media: imx258: add bindings for IMX258 sensor To: Sakari Ailus Cc: Mauro Carvalho Chehab , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Sep 2020 at 11:15, Sakari Ailus wrote: > > Hi Krzysztof, > > On Wed, Sep 23, 2020 at 05:21:26PM +0200, Krzysztof Kozlowski wrote: > > Add bindings for the IMX258 camera sensor. The bindings, just like the > > driver, are quite limited, e.g. do not support regulator supplies. > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > Changes since v3: > > 1. Document also two lane setup. > > > > Changes since v2: > > 1. Remove clock-frequency, add reset GPIOs, add supplies. > > Oops. I missed this one. > > How does the driver know the appropriate clock frequency for the platform > if it's not in DT? The sensor supports a range of frequencies, not a single > frequency. > > Could you add clock-frequency back? Not really, it was removed on Rob's request. The bindings do not describe driver's behavior so how the driver gets frequency should not be part of the bindings. Also it's not a real problem - the driver just calls clk_get_rate(). Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F17CAC4727F for ; Tue, 29 Sep 2020 09:21:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BDEB206FC for ; Tue, 29 Sep 2020 09:21:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s7aAOgiL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="QCn0viO1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BDEB206FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QgVThDKv025klxSsKr3tFUXqa1Y0J8VVbbWk7OzRd7E=; b=s7aAOgiLFNWdQC9/vEKQ1bnzA 3c67MgszoY5oat1ZXYcwAuP68q9vQm0XYA+36PVZ3PEERPyNkURCOGBq+jFcBzv0UUUQnd9bkOpPg 1Tok8oAk+gLGy+QTJNUAEiEvSWLyWeKN8mABIBkBzN3vX6tWyDys52LgUFbGs++HUIz7wmyWTkJ/p zYSNfmF7cRz5ppcqB4hdod8szpAk9nt/PLgxnaS68rybHzVBoCY94by/AGprLlBPQ7ToQGCsBCpye 942ORLCBuRjmG9xsStdu0vPl5tMXWdt3b6uS2oPhfiKux3lk+zAQ6p4Xg6JKxmBnWSLbRuJoUBPVL LOPRmgI4w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNBnG-00045B-US; Tue, 29 Sep 2020 09:19:31 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNBmn-0003ub-Aa for linux-arm-kernel@lists.infradead.org; Tue, 29 Sep 2020 09:19:23 +0000 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E920F21548 for ; Tue, 29 Sep 2020 09:18:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601371140; bh=7d9m8YtmM0oZBYPyOHbYl7Ajwa8TOm2mgFhI2B2FaTY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=QCn0viO1E7fFEdHcrG7XpKuS95w0MxGkvORWGZ4t8rgF0qiA1+8nlhMIYTEzkHgKO tMS3ZAI+vnstBUhPaeajoxZcysKp/06r7djzKNzINavjuKE453czOsxSWsXsDnekBQ 3xwjgzTsTovs86xQb71msEABZM9wIK1RIrNEOwVk= Received: by mail-ej1-f41.google.com with SMTP id j11so14016710ejk.0 for ; Tue, 29 Sep 2020 02:18:59 -0700 (PDT) X-Gm-Message-State: AOAM532l79vJMBnhyIok9iVV5NOG+kPjzjT2H/FoHjf7grd3Nvh2GBvY Vfk6X1sJqaXl03/c2zeFg05IKE3d89F9za5XYIM= X-Google-Smtp-Source: ABdhPJxGllGR2UiacyCTtjrgcZvi5cZtvrKkih45ZyLS0pOKgdvpZZMzMI6hYkQvt1+O3W0WIqLB4Ct0t3vT/qbhxdg= X-Received: by 2002:a17:906:8401:: with SMTP id n1mr2757814ejx.215.1601371138361; Tue, 29 Sep 2020 02:18:58 -0700 (PDT) MIME-Version: 1.0 References: <20200923152129.21736-1-krzk@kernel.org> <20200929091512.GF26842@paasikivi.fi.intel.com> In-Reply-To: <20200929091512.GF26842@paasikivi.fi.intel.com> From: Krzysztof Kozlowski Date: Tue, 29 Sep 2020 11:18:46 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 1/4] dt-bindings: media: imx258: add bindings for IMX258 sensor To: Sakari Ailus X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200929_051901_611827_410F287C X-CRM114-Status: GOOD ( 21.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Shawn Guo , Sascha Hauer , "linux-kernel@vger.kernel.org" , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Mauro Carvalho Chehab , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 29 Sep 2020 at 11:15, Sakari Ailus wrote: > > Hi Krzysztof, > > On Wed, Sep 23, 2020 at 05:21:26PM +0200, Krzysztof Kozlowski wrote: > > Add bindings for the IMX258 camera sensor. The bindings, just like the > > driver, are quite limited, e.g. do not support regulator supplies. > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > Changes since v3: > > 1. Document also two lane setup. > > > > Changes since v2: > > 1. Remove clock-frequency, add reset GPIOs, add supplies. > > Oops. I missed this one. > > How does the driver know the appropriate clock frequency for the platform > if it's not in DT? The sensor supports a range of frequencies, not a single > frequency. > > Could you add clock-frequency back? Not really, it was removed on Rob's request. The bindings do not describe driver's behavior so how the driver gets frequency should not be part of the bindings. Also it's not a real problem - the driver just calls clk_get_rate(). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel