From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2513BC6379F for ; Wed, 15 Feb 2023 11:21:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229784AbjBOLVb (ORCPT ); Wed, 15 Feb 2023 06:21:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233135AbjBOLV3 (ORCPT ); Wed, 15 Feb 2023 06:21:29 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 423C137B6D for ; Wed, 15 Feb 2023 03:21:28 -0800 (PST) Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 059193F4B8 for ; Wed, 15 Feb 2023 11:21:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1676460087; bh=hwzNkkVHAMig3SgTdNBISffkqWyB+YZfYs1moUFjJBQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=cQ/cbKTc7GkCr29Mxcb5UBckJwcf7/15OPWJehCFZc66ItYrp/W6igA0CYlVe3/kB x1JuRl4ascRlF0s06xqPeox0O50+4fLmNf4u3tlgO95jZiS7fFwVkfr0sUbZO4El5J ezi550gUwk3tYvGylY3NAttl32HRIHwhFSnJzRHnwxiFJ8/nHVbhvcK0ocklPsDEZB zdtC2uXFSaev8AeeqBKlA4dmSmiDdTf2UN4xpFxnPoWpKCYsti3+JT72//NsVu232j L3BbhFtUZrSDWe0W5pKhIzZi+HqmK1W6zPrXpKoMMRoU5oLzg+QU0AdA7atq9V84Hq jMp5Zbu2aSMng== Received: by mail-qt1-f200.google.com with SMTP id a24-20020ac87218000000b003bb7c7a82f7so10799292qtp.9 for ; Wed, 15 Feb 2023 03:21:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hwzNkkVHAMig3SgTdNBISffkqWyB+YZfYs1moUFjJBQ=; b=E7zm06h2AX5NDEoDgkwBShdaKB9Z8LxlpnlgOMUGLehVHumal/lGTdq03MUkz+h2+M G+yvBQ0M5lga/3A6mQRPvqUlxPs9jMgRiVvnuQuHwlBTjPBI1HjCOIemq2vTyklAcGBX QO1c3SMDNoOwi9IlDPl9qnAkMCpvmPs8ElWqcVoNH/yoeCCJssC04P6eDPDiZXCpQjc+ C48fMsjCpYLXmzbSA5etft+ibOJDb7rDs89EQXqT5SigctnZWUt65rJYAIAq77xq13Y6 etYXdnPr71Ni7IcHZC/R0qCldNEZt1jbO9a3GsPgfxM8uJgz0ERBq85S0YC5vt5z8fgl Pexw== X-Gm-Message-State: AO0yUKXILDmdmum1rnkxSHGrudQvUD21uC1hLL5dD124+FV8hVhyAkrp ZRFeky39Cu0tLpIgMmyv9YdhUKoDRwiF69gdwNqd4nIVPSB9lfoWZuAeMJ3mjKmqwfgxABprg9g CyJEcVKM6ZGkyI3pjS9qvj3L1m9weHZmex3SEcrMM10jGV3hlsXnXIbUFuQ== X-Received: by 2002:a05:622a:164f:b0:3bc:e3a8:d1d6 with SMTP id y15-20020a05622a164f00b003bce3a8d1d6mr195956qtj.229.1676460075472; Wed, 15 Feb 2023 03:21:15 -0800 (PST) X-Google-Smtp-Source: AK7set9/NeWH75yJcn/t46NzwvdAG3kpXtrEWKot0xC2tKbCmHsBGrLAxxXzoc7xjxLRcnJ3CgUfTfDnKiYp8juZgUM= X-Received: by 2002:a05:622a:164f:b0:3bc:e3a8:d1d6 with SMTP id y15-20020a05622a164f00b003bce3a8d1d6mr195937qtj.229.1676460075213; Wed, 15 Feb 2023 03:21:15 -0800 (PST) MIME-Version: 1.0 References: <20230211031821.976408-1-cristian.ciocaltea@collabora.com> <20230211031821.976408-9-cristian.ciocaltea@collabora.com> In-Reply-To: From: Emil Renner Berthing Date: Wed, 15 Feb 2023 12:20:58 +0100 Message-ID: Subject: Re: [PATCH 08/12] net: stmmac: Add glue layer for StarFive JH7100 SoC To: Cristian Ciocaltea Cc: Andrew Lunn , Lee Jones , Rob Herring , Krzysztof Kozlowski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Emil Renner Berthing , Conor Dooley , Palmer Dabbelt , Paul Walmsley , Albert Ou , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Sagar Kadam , Yanhong Wang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@collabora.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Feb 2023 at 01:09, Cristian Ciocaltea wrote: > > On 2/11/23 18:11, Andrew Lunn wrote: > >> + > >> +#define JH7100_SYSMAIN_REGISTER28 0x70 > >> +/* The value below is not a typo, just really bad naming by StarFive = =C2=AF\_(=E3=83=84)_/=C2=AF */ > >> +#define JH7100_SYSMAIN_REGISTER49 0xc8 > > > > Seems like the comment should be one line earlier? Well yes, the very generic register names are also bad, but this comment refers to the fact that it kind of makes sense that register 28 has the offset 28 * 4 bytes pr. register =3D 0x70 ..but then register 49 is oddly out of place at offset 0xc8 instead of 49 * 4 bytes pr. register =3D 0xc4 > > There is value in basing the names on the datasheet, but you could > > append something meaningful on the end: > > > > #define JH7100_SYSMAIN_REGISTER49_DLYCHAIN 0xc8 > > Unfortunately the JH7100 datasheet I have access to doesn't provide any > information regarding the SYSCTRL-MAINSYS related registers. Maybe Emil > could provide some details here? This is reverse engineered from the auto generated headers in their u-boot: https://github.com/starfive-tech/u-boot/blob/JH7100_VisionFive_devel/arch/r= iscv/include/asm/arch-jh7100/syscon_sysmain_ctrl_macro.h Christian, I'm happy that you're working on this, but mess like this and waiting for the non-coherent dma to be sorted is why I didn't send it upstream yet. > >> + if (!of_property_read_u32(np, "starfive,gtxclk-dlychain", >xclk= _dlychain)) { > >> + ret =3D regmap_write(sysmain, JH7100_SYSMAIN_REGISTER49, = gtxclk_dlychain); > >> + if (ret) > >> + return dev_err_probe(dev, ret, "error selecting g= txclk delay chain\n"); > >> + } > > > > You should probably document that if starfive,gtxclk-dlychain is not > > found in the DT blob, the value for the delay chain is undefined. It > > would actually be better to define it, set it to 0 for example. That > > way, you know you don't have any dependency on the bootloader for > > example. > > Sure, I will set it to 0. > > > > > Andrew > > Thanks for reviewing, > Cristian > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E49E5C636D4 for ; Wed, 15 Feb 2023 11:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FJoPrpdiVwgZcJK1zCwzD+NuGOXtCd9XSKT/fYqOjAA=; b=ScEoIqu5+Pv2CL ozEUKJv32KdBa/DfG38k/lNyp+Hpb3JcOhUex7HiJ5IoXKfqzmqM/rzxTy1BuEZ6ly9Ce3ChnrD8R a6XV6wh+HQm6put1rv7Wl96JDnbspQQWAnthlViw8iRuoNHqazAwBNo7U0xpl2uQbDML/rmS0+6dd 0+TQlgwsBwLERJ5tQCQXjVAYbtYtOvHTtxm52P4sgunBCnNZ65z/E9m7RXcHZDhyh12EA5Cgi+S82 Ae680v55SQLHcP8/4msgBIkfKVDRgdDm2FkdhePMB48gJGAKe+XtPTRd02megZaKj/uvsOQSb9ta+ M6V/N45oPL17AjZChGyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSFqx-005aIG-9W; Wed, 15 Feb 2023 11:21:35 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSFql-005aDf-AP for linux-riscv@lists.infradead.org; Wed, 15 Feb 2023 11:21:25 +0000 Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 4EA283F71B for ; Wed, 15 Feb 2023 11:21:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1676460077; bh=hwzNkkVHAMig3SgTdNBISffkqWyB+YZfYs1moUFjJBQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=A+IZ+CWRwgyejGne7EI3/hIFUYzJnGJjgGeZJ9ut6aoRpODPYfE9TeYN/Z9v84yMa ekKvc2YKG58K1qoA5dJbWCO/qk8O2s52Wesldwfd/SDMQXgdsaOgV3CTo04/Cx6aQ2 ubDImuiPnqdIcDseDrs8tNUABxahqPqVJfkjEX+u1AAIuB+fpKFpH3q7CufXWYZpZ7 6b/yvxDZevEhJmpbMhV/y2BhJ6l/f/hyEmWwRQ8I/s8/TXjxqIsM8y10y1zek1vS76 BiFU1K4tv0OL6HVCRBbvx7xWwAZ1eUqAmITLWLN1IRotyoXvTDfiJdNhW3zLB/Y9Yu lHYamaQpw+81Q== Received: by mail-qt1-f197.google.com with SMTP id g26-20020ac8481a000000b003bd01832685so370940qtq.3 for ; Wed, 15 Feb 2023 03:21:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hwzNkkVHAMig3SgTdNBISffkqWyB+YZfYs1moUFjJBQ=; b=Br3MkIXnJY5w70n05rJhaMA7amgndRFFW7k1MtdP1Sqd5VKmogoBwNcAmX8fQUr8Vo 0ApEfusFscEHzVF2cWhbToXuDxeWsOxtW/o0JepdJn2xBsdVBwm2D0rf89Acihta8YCH FpOBNy/cVFzFY642qNZ59le24fP689RnYBl6Vu7h+h7JZTzG+JtiwfqW/V6MXzoUwPOZ DWq7InroFGiTvZj4SGRE5VwjFXFsD6wQPa9IE4CAXWRd1VgMvxZqiJUSu08eyZaz2lpE 2fqUfgK8As8nNOGJWdFU+Lp1gb3vyenpQnfv+IuTfv9E084KY4nNDQIXwwPZ1jZV655m 5uuQ== X-Gm-Message-State: AO0yUKWvYLJzr8RcVRfY3/u2+RS2lgxrwt/qGYOligbw1BpDhBCyAO0a elK2yjBynyB1IOk91lFEsgEC7AO7lUw/QsF/yAzz89J2rOaTvh2Hno/pGSw3roTcNT63FPB+wgL q5S/c4s6OPfj/2U2NXpXDYqUQRHKdnf2H0ERMXoGccgrhEvQiBoCotamRzvnYGA== X-Received: by 2002:a05:622a:164f:b0:3bc:e3a8:d1d6 with SMTP id y15-20020a05622a164f00b003bce3a8d1d6mr195949qtj.229.1676460075472; Wed, 15 Feb 2023 03:21:15 -0800 (PST) X-Google-Smtp-Source: AK7set9/NeWH75yJcn/t46NzwvdAG3kpXtrEWKot0xC2tKbCmHsBGrLAxxXzoc7xjxLRcnJ3CgUfTfDnKiYp8juZgUM= X-Received: by 2002:a05:622a:164f:b0:3bc:e3a8:d1d6 with SMTP id y15-20020a05622a164f00b003bce3a8d1d6mr195937qtj.229.1676460075213; Wed, 15 Feb 2023 03:21:15 -0800 (PST) MIME-Version: 1.0 References: <20230211031821.976408-1-cristian.ciocaltea@collabora.com> <20230211031821.976408-9-cristian.ciocaltea@collabora.com> In-Reply-To: From: Emil Renner Berthing Date: Wed, 15 Feb 2023 12:20:58 +0100 Message-ID: Subject: Re: [PATCH 08/12] net: stmmac: Add glue layer for StarFive JH7100 SoC To: Cristian Ciocaltea Cc: Andrew Lunn , Lee Jones , Rob Herring , Krzysztof Kozlowski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Emil Renner Berthing , Conor Dooley , Palmer Dabbelt , Paul Walmsley , Albert Ou , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Sagar Kadam , Yanhong Wang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@collabora.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230215_032123_786468_D0568453 X-CRM114-Status: GOOD ( 24.20 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gV2VkLCAxNSBGZWIgMjAyMyBhdCAwMTowOSwgQ3Jpc3RpYW4gQ2lvY2FsdGVhCjxjcmlzdGlh bi5jaW9jYWx0ZWFAY29sbGFib3JhLmNvbT4gd3JvdGU6Cj4KPiBPbiAyLzExLzIzIDE4OjExLCBB bmRyZXcgTHVubiB3cm90ZToKPiA+PiArCj4gPj4gKyNkZWZpbmUgSkg3MTAwX1NZU01BSU5fUkVH SVNURVIyOCAweDcwCj4gPj4gKy8qIFRoZSB2YWx1ZSBiZWxvdyBpcyBub3QgYSB0eXBvLCBqdXN0 IHJlYWxseSBiYWQgbmFtaW5nIGJ5IFN0YXJGaXZlIMKvXF8o44OEKV8vwq8gKi8KPiA+PiArI2Rl ZmluZSBKSDcxMDBfU1lTTUFJTl9SRUdJU1RFUjQ5IDB4YzgKPiA+Cj4gPiBTZWVtcyBsaWtlIHRo ZSBjb21tZW50IHNob3VsZCBiZSBvbmUgbGluZSBlYXJsaWVyPwoKV2VsbCB5ZXMsIHRoZSB2ZXJ5 IGdlbmVyaWMgcmVnaXN0ZXIgbmFtZXMgYXJlIGFsc28gYmFkLCBidXQgdGhpcwpjb21tZW50IHJl ZmVycyB0byB0aGUgZmFjdCB0aGF0IGl0IGtpbmQgb2YgbWFrZXMgc2Vuc2UgdGhhdCByZWdpc3Rl cgoyOCBoYXMgdGhlIG9mZnNldAogIDI4ICogNCBieXRlcyBwci4gcmVnaXN0ZXIgPSAweDcwCi4u YnV0IHRoZW4gcmVnaXN0ZXIgNDkgaXMgb2RkbHkgb3V0IG9mIHBsYWNlIGF0IG9mZnNldCAweGM4 IGluc3RlYWQgb2YKICA0OSAqIDQgYnl0ZXMgcHIuIHJlZ2lzdGVyID0gMHhjNAoKPiA+IFRoZXJl IGlzIHZhbHVlIGluIGJhc2luZyB0aGUgbmFtZXMgb24gdGhlIGRhdGFzaGVldCwgYnV0IHlvdSBj b3VsZAo+ID4gYXBwZW5kIHNvbWV0aGluZyBtZWFuaW5nZnVsIG9uIHRoZSBlbmQ6Cj4gPgo+ID4g I2RlZmluZSBKSDcxMDBfU1lTTUFJTl9SRUdJU1RFUjQ5X0RMWUNIQUlOIDB4YzgKPgo+IFVuZm9y dHVuYXRlbHkgdGhlIEpINzEwMCBkYXRhc2hlZXQgSSBoYXZlIGFjY2VzcyB0byBkb2Vzbid0IHBy b3ZpZGUgYW55Cj4gaW5mb3JtYXRpb24gcmVnYXJkaW5nIHRoZSBTWVNDVFJMLU1BSU5TWVMgcmVs YXRlZCByZWdpc3RlcnMuIE1heWJlIEVtaWwKPiBjb3VsZCBwcm92aWRlIHNvbWUgZGV0YWlscyBo ZXJlPwoKVGhpcyBpcyByZXZlcnNlIGVuZ2luZWVyZWQgZnJvbSB0aGUgYXV0byBnZW5lcmF0ZWQg aGVhZGVycyBpbiB0aGVpciB1LWJvb3Q6Cmh0dHBzOi8vZ2l0aHViLmNvbS9zdGFyZml2ZS10ZWNo L3UtYm9vdC9ibG9iL0pINzEwMF9WaXNpb25GaXZlX2RldmVsL2FyY2gvcmlzY3YvaW5jbHVkZS9h c20vYXJjaC1qaDcxMDAvc3lzY29uX3N5c21haW5fY3RybF9tYWNyby5oCgpDaHJpc3RpYW4sIEkn bSBoYXBweSB0aGF0IHlvdSdyZSB3b3JraW5nIG9uIHRoaXMsIGJ1dCBtZXNzIGxpa2UgdGhpcwph bmQgd2FpdGluZyBmb3IgdGhlIG5vbi1jb2hlcmVudCBkbWEgdG8gYmUgc29ydGVkIGlzIHdoeSBJ IGRpZG4ndCBzZW5kCml0IHVwc3RyZWFtIHlldC4KCj4gPj4gKyAgICBpZiAoIW9mX3Byb3BlcnR5 X3JlYWRfdTMyKG5wLCAic3RhcmZpdmUsZ3R4Y2xrLWRseWNoYWluIiwgJmd0eGNsa19kbHljaGFp bikpIHsKPiA+PiArICAgICAgICAgICAgcmV0ID0gcmVnbWFwX3dyaXRlKHN5c21haW4sIEpINzEw MF9TWVNNQUlOX1JFR0lTVEVSNDksIGd0eGNsa19kbHljaGFpbik7Cj4gPj4gKyAgICAgICAgICAg IGlmIChyZXQpCj4gPj4gKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGRldl9lcnJfcHJvYmUo ZGV2LCByZXQsICJlcnJvciBzZWxlY3RpbmcgZ3R4Y2xrIGRlbGF5IGNoYWluXG4iKTsKPiA+PiAr ICAgIH0KPiA+Cj4gPiBZb3Ugc2hvdWxkIHByb2JhYmx5IGRvY3VtZW50IHRoYXQgaWYgc3RhcmZp dmUsZ3R4Y2xrLWRseWNoYWluIGlzIG5vdAo+ID4gZm91bmQgaW4gdGhlIERUIGJsb2IsIHRoZSB2 YWx1ZSBmb3IgdGhlIGRlbGF5IGNoYWluIGlzIHVuZGVmaW5lZC4gIEl0Cj4gPiB3b3VsZCBhY3R1 YWxseSBiZSBiZXR0ZXIgdG8gZGVmaW5lIGl0LCBzZXQgaXQgdG8gMCBmb3IgZXhhbXBsZS4gVGhh dAo+ID4gd2F5LCB5b3Uga25vdyB5b3UgZG9uJ3QgaGF2ZSBhbnkgZGVwZW5kZW5jeSBvbiB0aGUg Ym9vdGxvYWRlciBmb3IKPiA+IGV4YW1wbGUuCj4KPiBTdXJlLCBJIHdpbGwgc2V0IGl0IHRvIDAu Cj4KPiA+Cj4gPiAgICAgICBBbmRyZXcKPgo+IFRoYW5rcyBmb3IgcmV2aWV3aW5nLAo+IENyaXN0 aWFuCj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ IGxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdAo+IGxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5v cmcKPiBodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJp c2N2CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5D6DC636CC for ; Wed, 15 Feb 2023 11:22:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SNR7XsN5/Droh4tCWPiGGbSlkNnfytELr7rFiI8B9hg=; b=f42az5SB0GTu+U CE19qTk9P861j75FqLDGeMnAEo7c2kfgx5mhYKD2tk+faBZ4YSQq6OBY3fwmJvZgQjwub/opXhsdz YwkkbAdFuTypxvu+VdK0zYtnEDsYtvHHjQpol3wPwBO/1DBZrE+LEA5UsUtSSx36XCuHGGhJkwNFJ l3JusMpcIlC2EZ/XvJBREgIXpV5orMRtCYabVyC3tXOM8CBpR02Sw8v9gx9DL7Z1uwY6I98JrvMb0 irJfu4l11TzmaN6qxYmJOFZN9i1kVeRoz/KW//Z0A75ILLVtbGWfqOrOcD4/75r9cti9EjzpCCnwq clBCJczF6gQIipbdzTxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSFqp-005aFw-EX; Wed, 15 Feb 2023 11:21:27 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSFql-005aDe-AQ for linux-arm-kernel@lists.infradead.org; Wed, 15 Feb 2023 11:21:25 +0000 Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 601A33F71D for ; Wed, 15 Feb 2023 11:21:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1676460077; bh=hwzNkkVHAMig3SgTdNBISffkqWyB+YZfYs1moUFjJBQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=A+IZ+CWRwgyejGne7EI3/hIFUYzJnGJjgGeZJ9ut6aoRpODPYfE9TeYN/Z9v84yMa ekKvc2YKG58K1qoA5dJbWCO/qk8O2s52Wesldwfd/SDMQXgdsaOgV3CTo04/Cx6aQ2 ubDImuiPnqdIcDseDrs8tNUABxahqPqVJfkjEX+u1AAIuB+fpKFpH3q7CufXWYZpZ7 6b/yvxDZevEhJmpbMhV/y2BhJ6l/f/hyEmWwRQ8I/s8/TXjxqIsM8y10y1zek1vS76 BiFU1K4tv0OL6HVCRBbvx7xWwAZ1eUqAmITLWLN1IRotyoXvTDfiJdNhW3zLB/Y9Yu lHYamaQpw+81Q== Received: by mail-qk1-f198.google.com with SMTP id x7-20020a05620a098700b007242aa494ddso11221716qkx.19 for ; Wed, 15 Feb 2023 03:21:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hwzNkkVHAMig3SgTdNBISffkqWyB+YZfYs1moUFjJBQ=; b=zyi7Dlez1EknqYq72De4DcJzhh35fnOG+ulTSVD6EuxDUlUCwhMM/43lmAMZN7UTnI 6cBXjSggU5i2wjWZSgVYQYEBnln8F+3kKTeTjvV5H0kzRMgKBKpiuhaMjiT9k7vYO84q WIzpynCY8asFnf1KsT5xvqEPWKSZbYTjSNzXlphv1Nz5WCv/2CEE/MhanF7p4BfoHv2c UkCn4cMlrSzaQ/5O1/lKeEfrDzL2KSqBTr9lKqypFMFeBnOy3YNz9kMVcdThFz1b8XeF 6qB5IhJZHNVPjE6KdxEy/2u3ZmubPnpU94/2jCtMm70putC4GlryAwvxRfLLd8G3STXo WlLw== X-Gm-Message-State: AO0yUKUzuh8FQ0USrPRsFl9haIH1gQK7tXtDA05b8xCUnWJuLmktgvR4 iW0cMV1T94UWxj3fGZKU4n+IopeOu0y+SbIdQfASvsYGjyZfw5q0xeiaU3MasvWh7x8iISY5Vh0 XJsn8zkfI7qHHw8ES1uUbBVSrOvVB3ktzvy9nSoc9CAY/sUUFb8CLqtHhv6+vAcxS56yK X-Received: by 2002:a05:622a:164f:b0:3bc:e3a8:d1d6 with SMTP id y15-20020a05622a164f00b003bce3a8d1d6mr195952qtj.229.1676460075472; Wed, 15 Feb 2023 03:21:15 -0800 (PST) X-Google-Smtp-Source: AK7set9/NeWH75yJcn/t46NzwvdAG3kpXtrEWKot0xC2tKbCmHsBGrLAxxXzoc7xjxLRcnJ3CgUfTfDnKiYp8juZgUM= X-Received: by 2002:a05:622a:164f:b0:3bc:e3a8:d1d6 with SMTP id y15-20020a05622a164f00b003bce3a8d1d6mr195937qtj.229.1676460075213; Wed, 15 Feb 2023 03:21:15 -0800 (PST) MIME-Version: 1.0 References: <20230211031821.976408-1-cristian.ciocaltea@collabora.com> <20230211031821.976408-9-cristian.ciocaltea@collabora.com> In-Reply-To: From: Emil Renner Berthing Date: Wed, 15 Feb 2023 12:20:58 +0100 Message-ID: Subject: Re: [PATCH 08/12] net: stmmac: Add glue layer for StarFive JH7100 SoC To: Cristian Ciocaltea Cc: Andrew Lunn , Lee Jones , Rob Herring , Krzysztof Kozlowski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Emil Renner Berthing , Conor Dooley , Palmer Dabbelt , Paul Walmsley , Albert Ou , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Sagar Kadam , Yanhong Wang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@collabora.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230215_032123_786447_733E3B9C X-CRM114-Status: GOOD ( 25.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAxNSBGZWIgMjAyMyBhdCAwMTowOSwgQ3Jpc3RpYW4gQ2lvY2FsdGVhCjxjcmlzdGlh bi5jaW9jYWx0ZWFAY29sbGFib3JhLmNvbT4gd3JvdGU6Cj4KPiBPbiAyLzExLzIzIDE4OjExLCBB bmRyZXcgTHVubiB3cm90ZToKPiA+PiArCj4gPj4gKyNkZWZpbmUgSkg3MTAwX1NZU01BSU5fUkVH SVNURVIyOCAweDcwCj4gPj4gKy8qIFRoZSB2YWx1ZSBiZWxvdyBpcyBub3QgYSB0eXBvLCBqdXN0 IHJlYWxseSBiYWQgbmFtaW5nIGJ5IFN0YXJGaXZlIMKvXF8o44OEKV8vwq8gKi8KPiA+PiArI2Rl ZmluZSBKSDcxMDBfU1lTTUFJTl9SRUdJU1RFUjQ5IDB4YzgKPiA+Cj4gPiBTZWVtcyBsaWtlIHRo ZSBjb21tZW50IHNob3VsZCBiZSBvbmUgbGluZSBlYXJsaWVyPwoKV2VsbCB5ZXMsIHRoZSB2ZXJ5 IGdlbmVyaWMgcmVnaXN0ZXIgbmFtZXMgYXJlIGFsc28gYmFkLCBidXQgdGhpcwpjb21tZW50IHJl ZmVycyB0byB0aGUgZmFjdCB0aGF0IGl0IGtpbmQgb2YgbWFrZXMgc2Vuc2UgdGhhdCByZWdpc3Rl cgoyOCBoYXMgdGhlIG9mZnNldAogIDI4ICogNCBieXRlcyBwci4gcmVnaXN0ZXIgPSAweDcwCi4u YnV0IHRoZW4gcmVnaXN0ZXIgNDkgaXMgb2RkbHkgb3V0IG9mIHBsYWNlIGF0IG9mZnNldCAweGM4 IGluc3RlYWQgb2YKICA0OSAqIDQgYnl0ZXMgcHIuIHJlZ2lzdGVyID0gMHhjNAoKPiA+IFRoZXJl IGlzIHZhbHVlIGluIGJhc2luZyB0aGUgbmFtZXMgb24gdGhlIGRhdGFzaGVldCwgYnV0IHlvdSBj b3VsZAo+ID4gYXBwZW5kIHNvbWV0aGluZyBtZWFuaW5nZnVsIG9uIHRoZSBlbmQ6Cj4gPgo+ID4g I2RlZmluZSBKSDcxMDBfU1lTTUFJTl9SRUdJU1RFUjQ5X0RMWUNIQUlOIDB4YzgKPgo+IFVuZm9y dHVuYXRlbHkgdGhlIEpINzEwMCBkYXRhc2hlZXQgSSBoYXZlIGFjY2VzcyB0byBkb2Vzbid0IHBy b3ZpZGUgYW55Cj4gaW5mb3JtYXRpb24gcmVnYXJkaW5nIHRoZSBTWVNDVFJMLU1BSU5TWVMgcmVs YXRlZCByZWdpc3RlcnMuIE1heWJlIEVtaWwKPiBjb3VsZCBwcm92aWRlIHNvbWUgZGV0YWlscyBo ZXJlPwoKVGhpcyBpcyByZXZlcnNlIGVuZ2luZWVyZWQgZnJvbSB0aGUgYXV0byBnZW5lcmF0ZWQg aGVhZGVycyBpbiB0aGVpciB1LWJvb3Q6Cmh0dHBzOi8vZ2l0aHViLmNvbS9zdGFyZml2ZS10ZWNo L3UtYm9vdC9ibG9iL0pINzEwMF9WaXNpb25GaXZlX2RldmVsL2FyY2gvcmlzY3YvaW5jbHVkZS9h c20vYXJjaC1qaDcxMDAvc3lzY29uX3N5c21haW5fY3RybF9tYWNyby5oCgpDaHJpc3RpYW4sIEkn bSBoYXBweSB0aGF0IHlvdSdyZSB3b3JraW5nIG9uIHRoaXMsIGJ1dCBtZXNzIGxpa2UgdGhpcwph bmQgd2FpdGluZyBmb3IgdGhlIG5vbi1jb2hlcmVudCBkbWEgdG8gYmUgc29ydGVkIGlzIHdoeSBJ IGRpZG4ndCBzZW5kCml0IHVwc3RyZWFtIHlldC4KCj4gPj4gKyAgICBpZiAoIW9mX3Byb3BlcnR5 X3JlYWRfdTMyKG5wLCAic3RhcmZpdmUsZ3R4Y2xrLWRseWNoYWluIiwgJmd0eGNsa19kbHljaGFp bikpIHsKPiA+PiArICAgICAgICAgICAgcmV0ID0gcmVnbWFwX3dyaXRlKHN5c21haW4sIEpINzEw MF9TWVNNQUlOX1JFR0lTVEVSNDksIGd0eGNsa19kbHljaGFpbik7Cj4gPj4gKyAgICAgICAgICAg IGlmIChyZXQpCj4gPj4gKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGRldl9lcnJfcHJvYmUo ZGV2LCByZXQsICJlcnJvciBzZWxlY3RpbmcgZ3R4Y2xrIGRlbGF5IGNoYWluXG4iKTsKPiA+PiAr ICAgIH0KPiA+Cj4gPiBZb3Ugc2hvdWxkIHByb2JhYmx5IGRvY3VtZW50IHRoYXQgaWYgc3RhcmZp dmUsZ3R4Y2xrLWRseWNoYWluIGlzIG5vdAo+ID4gZm91bmQgaW4gdGhlIERUIGJsb2IsIHRoZSB2 YWx1ZSBmb3IgdGhlIGRlbGF5IGNoYWluIGlzIHVuZGVmaW5lZC4gIEl0Cj4gPiB3b3VsZCBhY3R1 YWxseSBiZSBiZXR0ZXIgdG8gZGVmaW5lIGl0LCBzZXQgaXQgdG8gMCBmb3IgZXhhbXBsZS4gVGhh dAo+ID4gd2F5LCB5b3Uga25vdyB5b3UgZG9uJ3QgaGF2ZSBhbnkgZGVwZW5kZW5jeSBvbiB0aGUg Ym9vdGxvYWRlciBmb3IKPiA+IGV4YW1wbGUuCj4KPiBTdXJlLCBJIHdpbGwgc2V0IGl0IHRvIDAu Cj4KPiA+Cj4gPiAgICAgICBBbmRyZXcKPgo+IFRoYW5rcyBmb3IgcmV2aWV3aW5nLAo+IENyaXN0 aWFuCj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ IGxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdAo+IGxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5v cmcKPiBodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJp c2N2CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg==