All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michał Krawczyk" <mk@semihalf.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "Wiles, Keith" <keith.wiles@intel.com>, dev <dev@dpdk.org>,
	 Igor Chauskin <igorch@amazon.com>,
	Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] Fix loss of data stored in udata64 mbuf field
Date: Thu, 4 Feb 2021 10:17:54 +0100	[thread overview]
Message-ID: <CAJMMOfMaQ+-9seM+G5dg56ZLu+un8=QuCLdH0pVkC1JnXx9yHQ@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8wPZRQ13NrD-fNKve4B8bwi3hw-gYKbF+wyejD29wWLxA@mail.gmail.com>

czw., 4 lut 2021 o 10:01 David Marchand <david.marchand@redhat.com> napisał(a):
>
> On Thu, Feb 4, 2021 at 9:52 AM Michal Krawczyk <mk@semihalf.com> wrote:
> >
> > DPDK v20.11 removed udata64 field, and changed type of the dynfield1 to
> > uint32_t.
> >
> > Due to define:
> >   lib/common/pg_compat.h:#define udata64                 dynfield1[0]
> > the copy of udata64 was in fact copying only the first 32 bits.
>
> I did not look at the pktgen code, but directly accessing mbuf field
> dynfieldX is likely a bug.
>
> pktgen should register a dynfield for its own usage to avoid conflicts
> with other parts of the dpdk.
> Example of such a conversion to the new mechanism:
> https://git.dpdk.org/dpdk/commit/?id=eb8258402b3f
>

Hi David,

thanks for pointing this out. I wasn't aware of that, I'll rework my
fix to satisfy the dynfield requirements.

Best regards,
Michal

>
> --
> David Marchand
>

  reply	other threads:[~2021-02-04  9:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  8:52 [dpdk-dev] [PATCH] Fix loss of data stored in udata64 mbuf field Michal Krawczyk
2021-02-04  9:01 ` David Marchand
2021-02-04  9:17   ` Michał Krawczyk [this message]
2021-02-04  9:35     ` Thomas Monjalon
2021-02-04 12:24 ` [dpdk-dev] [PATCH v2] " Michal Krawczyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJMMOfMaQ+-9seM+G5dg56ZLu+un8=QuCLdH0pVkC1JnXx9yHQ@mail.gmail.com' \
    --to=mk@semihalf.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=igorch@amazon.com \
    --cc=keith.wiles@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.