From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B38AC76188 for ; Wed, 5 Apr 2023 09:30:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237733AbjDEJaQ (ORCPT ); Wed, 5 Apr 2023 05:30:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237573AbjDEJ3v (ORCPT ); Wed, 5 Apr 2023 05:29:51 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18D626191 for ; Wed, 5 Apr 2023 02:29:25 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id p3-20020a17090a74c300b0023f69bc7a68so36643586pjl.4 for ; Wed, 05 Apr 2023 02:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf.com; s=google; t=1680686963; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=CB65A8SjX16vPcN6BQCB8Vc5858YsTyuoCI6+70iQws=; b=HBDDhFVGtA0Aicl5sg/jfaWecYsYcMbRsHAxUQ2Cz8tDDBS4flOhkmOv0qCU1NcomF El0EcpRU94382WLwHA8YVlbhXolyMRSoVL9oJ32ZZpEwGxoET+5mPux51YWbx7xaOTPl BSuRofVFClX+/dZlhUu46hxiNjkB20ZbQbEqgSmtPAuTNlAkk2R569QAAmyVVn+nTdPA HZA/JCNY+sdBiG0F8szDCfvEIvPN8EP5/B7tHSkk32RlOkUMzRSAgFUcT8Htj4t9jtW/ 3jUl0TV7gZoKacFm3p4I3yZJq+tSdBWFv9cTQDL8AbdSlqa26/m9YN8sC+QAbIicxKFM eBiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680686963; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CB65A8SjX16vPcN6BQCB8Vc5858YsTyuoCI6+70iQws=; b=CxMz7+xpfEWDpF6S4lIjaShPHf/zckcj3W2hjoWl0Fc/8ghrpJBXuTEr8yJclK7OwF Cn1xkloueLa2uH4uN9gLlOB8cX7yCssV3wv9yPjCnG1rAUcMmMlI4bKj7rknvP97H2zF K6REm6yjhHbeDnVcEaNvdSFdaf95rMmgu9O1GODGCHAHYtsif73XPjmyJVYz/4b9tvvQ xo8udic9M7MGPPGzaIH7FcnjIeTV3Ntd+BOBOowYibEp1W7unkayCKMKl8C3N5gopvzk oWEcxWX/DBcEiaSGVx183cPQDIP3qfRrbBVWCLLkffTGMjVJv8NuTlpDTP29qp6S/r+O u+0g== X-Gm-Message-State: AAQBX9e++pxEFbcz4GrPLlg8wQI09VcW2wYJE178oDva6mphvmyT7JbI m0/LeRejzCuJaN9jRdGXPbos59xI9wCWoXSB80o4LQ== X-Google-Smtp-Source: AKy350a2aSuU+GT0mHqC7la+7TGRYdNgcToP4W9UShQRP3Mdjvc5GASCj61EyN7Q2oziPCR/E4LVbxYFgh0izappgYo= X-Received: by 2002:a17:90a:d598:b0:230:b842:143e with SMTP id v24-20020a17090ad59800b00230b842143emr2009042pju.6.1680686962913; Wed, 05 Apr 2023 02:29:22 -0700 (PDT) MIME-Version: 1.0 References: <20230130105423.1338554-1-mk@semmihalf.com> <20230130135418.1604455-1-mk@semmihalf.com> In-Reply-To: From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Wed, 5 Apr 2023 11:29:12 +0200 Message-ID: Subject: Re: [PATCH v2] media: venus: dec: Fix handling of the start cmd To: Vikash Garodia Cc: Stanimir Varbanov , "Vikash Garodia (QUIC)" , Andy Gross , Bjorn Andersson , Konrad Dybcio , Mauro Carvalho Chehab , "linux-media@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "mw@semihalf.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, just a kindly reminder about the patch. Thanks, Micha=C5=82 pt., 10 mar 2023 o 16:05 Micha=C5=82 Krawczyk napisa=C5= =82(a): > > Hi, > > Any update on this patch? It would be great if we could make some > progress there (and, hopefully, finally merge it :)) > > Thanks, > Micha=C5=82 > > pt., 10 lut 2023 o 16:18 Micha=C5=82 Krawczyk napisa=C5= =82(a): > > > > Hi, > > > > I'm wondering if there are any more comments for this patch? I would > > be happy to clarify anything that's unclear or improve the code if > > needed. > > > > I know it's pretty late, but it would be really great if this fix > > could land before v6.2 is released, so I'd appreciate your help and > > review. > > > > Thank you, > > Micha=C5=82 > > > > wt., 7 lut 2023 o 12:15 Micha=C5=82 Krawczyk napisa= =C5=82(a): > > > > > > wt., 7 lut 2023 o 10:54 Vikash Garodia na= pisa=C5=82(a): > > > > I have reviewed the patch, and the drain sequence handling looks go= od to me. > > > > Could you share some details on the test client which you are using= to catch this issue ? > > > > > > Hi Vikash, > > > > > > Thank you for looking at the code! > > > > > > I've been testing it using the Chromium implementation of the V4L2 > > > codec [1]. Meanwhile, we were running a test suite which changes the > > > encryption method in the middle of the video decoding. This triggers > > > the flush behavior and the Chromium sends the stop/start cmd to the > > > V4L2 kernel component, and the test expects the video to continue the > > > playback normally. Unfortunately, it was causing a stall of the video > > > at the same time. > > > > > > [1] https://source.chromium.org/chromium/chromium/src/+/main:media/gp= u/v4l2/ > > > > > > > > > > > > Thank you, > > > > > Micha=C5=82 > > > > > > > > Thanks, > > > > Vikash