From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78A00C072B1 for ; Thu, 30 May 2019 06:27:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4ED63259CB for ; Thu, 30 May 2019 06:27:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="TeMX9NEY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727358AbfE3G1z (ORCPT ); Thu, 30 May 2019 02:27:55 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:35400 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727272AbfE3G1z (ORCPT ); Thu, 30 May 2019 02:27:55 -0400 Received: by mail-qt1-f193.google.com with SMTP id w1so5667582qts.2 for ; Wed, 29 May 2019 23:27:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EDB9NEzcrpM7vrzDugTKwabI3NuPP3IyLOyki6rb9uw=; b=TeMX9NEYaD2Qb/D8oQumCOS5CTT5UUG3au1rn0yH9MGA8q2jHPcpr5bZd7JUPdwRha m5ZvqEa54g94x1DtzRPQXWKXAZdSvFoMgS4B1EAeBL+A2iVZ3Rdip21Yh6WWJhg1s3dc r2HUIPMkLO6PQjVZQzMZFNnBB2IZuUatc64XY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EDB9NEzcrpM7vrzDugTKwabI3NuPP3IyLOyki6rb9uw=; b=qR1TZN/lKs5R+m1axs8LFe+thuON9pLzDD3BibZkn4o12CPF4ZLA1+T2yrEPTv2T1A XQ+DE+wOgwYGyiAd4GI8DJRzCeGBF/wRilVrDrCARobkNNaQarB5aBZcEeJwsme86QRN V/Zo/bO4gngFvKH87LV/V+sIAkNgnzWT33LRcBqlpihKy1LZDeyr1ycYn7vlzbnCRLsM 09I+QDksfiEqJd7EUu+oDz8d6jlNoXPS9UmE7niZQOmv2jHuz9iJ/Tf3B5OA4ulv0Bjy 06yuDxzijVrdnq4SMtk00YDF2ryfoau9D8XwvFc4HyNRz8Lv5YnHt8VYj9uQIidzzCXM FyUg== X-Gm-Message-State: APjAAAXzj9Uke3AwCDIIoB0tO7v8KQbJv8npGF0SD/GK96mDdi6MDeyu ORScp0aQ5uErpCzorRP1qRsGxt0s1jgKM+P8eN8ukw== X-Google-Smtp-Source: APXvYqzHDlQemfhL+uQX+PxIu9PwWEguqnHq/qbjiPCrDdlMTXx+BXHgxPzV/YR2FBce1yN3dYhDwycDzH8cXlXCGsc= X-Received: by 2002:ac8:ecc:: with SMTP id w12mr1935044qti.344.1559197674339; Wed, 29 May 2019 23:27:54 -0700 (PDT) MIME-Version: 1.0 References: <1557494826-6044-1-git-send-email-michael.kao@mediatek.com> <1557494826-6044-2-git-send-email-michael.kao@mediatek.com> In-Reply-To: <1557494826-6044-2-git-send-email-michael.kao@mediatek.com> From: Hsin-Yi Wang Date: Thu, 30 May 2019 14:27:28 +0800 Message-ID: Subject: Re: [PATCH v2 1/8] arm64: dts: mt8183: add thermal zone node To: "michael.kao" Cc: Zhang Rui , Eduardo Valentin , Daniel Lezcano , Rob Herring , Mark Rutland , Matthias Brugger , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, lkml , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 10, 2019 at 9:27 PM michael.kao wrote: > + > + tzts1: tzts1 { > + polling-delay-passive = <0>; > + polling-delay = <0>; > + thermal-sensors = <&thermal 1>; > + sustainable-power = <0>; > + trips {}; > + cooling-maps {}; > + }; > + Is 0 a valid initial sustainable-power setting? Since we'll still get warning[1] about this, though it might not be harmful. If 0 is a valid setting, maybe we should consider showing the warning of not setting this property in [2]? [1] https://elixir.bootlin.com/linux/latest/source/drivers/thermal/power_allocator.c#L570 [2] https://elixir.bootlin.com/linux/latest/source/drivers/thermal/of-thermal.c#L1049 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hsin-Yi Wang Subject: Re: [PATCH v2 1/8] arm64: dts: mt8183: add thermal zone node Date: Thu, 30 May 2019 14:27:28 +0800 Message-ID: References: <1557494826-6044-1-git-send-email-michael.kao@mediatek.com> <1557494826-6044-2-git-send-email-michael.kao@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1557494826-6044-2-git-send-email-michael.kao@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: "michael.kao" Cc: Zhang Rui , Eduardo Valentin , Daniel Lezcano , Rob Herring , Mark Rutland , Matthias Brugger , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, lkml , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-mediatek@lists.infradead.org List-Id: devicetree@vger.kernel.org On Fri, May 10, 2019 at 9:27 PM michael.kao wrote: > + > + tzts1: tzts1 { > + polling-delay-passive = <0>; > + polling-delay = <0>; > + thermal-sensors = <&thermal 1>; > + sustainable-power = <0>; > + trips {}; > + cooling-maps {}; > + }; > + Is 0 a valid initial sustainable-power setting? Since we'll still get warning[1] about this, though it might not be harmful. If 0 is a valid setting, maybe we should consider showing the warning of not setting this property in [2]? [1] https://elixir.bootlin.com/linux/latest/source/drivers/thermal/power_allocator.c#L570 [2] https://elixir.bootlin.com/linux/latest/source/drivers/thermal/of-thermal.c#L1049 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F48C072B1 for ; Thu, 30 May 2019 06:28:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D19BB259D7 for ; Thu, 30 May 2019 06:28:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EJ+C2Bnx"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="TeMX9NEY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D19BB259D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c2dXUl4hJSXqLewT8rkGm1hcH4xi9NU5Cp4UexahPQE=; b=EJ+C2Bnx6Dq3SP HJz8snwOOCy8d9V1lqEPSdfn7qqVxiKmgQ2htX9fYM3mnLgs1qCsMzCYEZeSapF2TTaGp14DNotlR osuHRNXLLpHrsWP1la1TSzYKTIA2/9ahqHKu+jQ832Mc2IAHG941krTr8bIzSph+9mjf4KdQOwmMt 5cDPLvsxjk2T6cLqhfZcY93xYa21WY7Dr4Ki9VwvFV6uTmETO9B6uJbn7xDQ32Rk0JiXpBKn5o/YJ aOfbYvFvGGZ1rgKXOGmmG3VbNPI/E8k6IoWgwU1qnCtrevFewMG2kwzBDymtbm/y2dYVYBXbxKBLA wph1JBBIFmpPvhPU5zAA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWEXl-0006mZ-30; Thu, 30 May 2019 06:28:05 +0000 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWEXd-0006l5-SF for linux-arm-kernel@lists.infradead.org; Thu, 30 May 2019 06:27:59 +0000 Received: by mail-qt1-x842.google.com with SMTP id y57so5677547qtk.4 for ; Wed, 29 May 2019 23:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EDB9NEzcrpM7vrzDugTKwabI3NuPP3IyLOyki6rb9uw=; b=TeMX9NEYaD2Qb/D8oQumCOS5CTT5UUG3au1rn0yH9MGA8q2jHPcpr5bZd7JUPdwRha m5ZvqEa54g94x1DtzRPQXWKXAZdSvFoMgS4B1EAeBL+A2iVZ3Rdip21Yh6WWJhg1s3dc r2HUIPMkLO6PQjVZQzMZFNnBB2IZuUatc64XY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EDB9NEzcrpM7vrzDugTKwabI3NuPP3IyLOyki6rb9uw=; b=neLZ2pTTH7L+ne7cph7hh2MaSTeF/FdHN10WVO2SRfdQcItrh11aoQ2Qq9KoJ809/5 jYXEYn1QBZK+CZSQpofx2hw/vfv2qv/rvVnbTaCT2wbgwWU4aSCSW5Tds9D4OAinLV0t IjgPDXz0fQVLq/eH7HLWK8QXrtbwXr5Q3aKemyOVJb0OYjLBYz34ZNQ2bl3tGqqE9/KD c9QIHXcEuEQE0H6a85LjmfvnsbNIO8cMzi0mNU9G2VyMPxBMJKrkAgmu1aVsvdSW2WKx 8UCxdqyBVDy3IARzrssIqmkEg+EnGBqrV2dw2xUiBU8yFI1wUgOYjbmLiVLX0i2ULs2U fRmQ== X-Gm-Message-State: APjAAAVwU1a2WAitei5R59jWdT0TY2VpIlec7DUPcIQPsWSlfwOursvX ZYk9Y+3yYAcCpZviAc8fwAPhuON6k2T9PrF6Fb7gNg== X-Google-Smtp-Source: APXvYqzHDlQemfhL+uQX+PxIu9PwWEguqnHq/qbjiPCrDdlMTXx+BXHgxPzV/YR2FBce1yN3dYhDwycDzH8cXlXCGsc= X-Received: by 2002:ac8:ecc:: with SMTP id w12mr1935044qti.344.1559197674339; Wed, 29 May 2019 23:27:54 -0700 (PDT) MIME-Version: 1.0 References: <1557494826-6044-1-git-send-email-michael.kao@mediatek.com> <1557494826-6044-2-git-send-email-michael.kao@mediatek.com> In-Reply-To: <1557494826-6044-2-git-send-email-michael.kao@mediatek.com> From: Hsin-Yi Wang Date: Thu, 30 May 2019 14:27:28 +0800 Message-ID: Subject: Re: [PATCH v2 1/8] arm64: dts: mt8183: add thermal zone node To: "michael.kao" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190529_232757_924269_46628BC7 X-CRM114-Status: GOOD ( 10.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Daniel Lezcano , lkml , Eduardo Valentin , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Zhang Rui , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 10, 2019 at 9:27 PM michael.kao wrote: > + > + tzts1: tzts1 { > + polling-delay-passive = <0>; > + polling-delay = <0>; > + thermal-sensors = <&thermal 1>; > + sustainable-power = <0>; > + trips {}; > + cooling-maps {}; > + }; > + Is 0 a valid initial sustainable-power setting? Since we'll still get warning[1] about this, though it might not be harmful. If 0 is a valid setting, maybe we should consider showing the warning of not setting this property in [2]? [1] https://elixir.bootlin.com/linux/latest/source/drivers/thermal/power_allocator.c#L570 [2] https://elixir.bootlin.com/linux/latest/source/drivers/thermal/of-thermal.c#L1049 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel