From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 981DEC433DB for ; Mon, 18 Jan 2021 07:23:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4549E223DB for ; Mon, 18 Jan 2021 07:23:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730255AbhARHXW (ORCPT ); Mon, 18 Jan 2021 02:23:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730151AbhARHXH (ORCPT ); Mon, 18 Jan 2021 02:23:07 -0500 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EF7DC061574 for ; Sun, 17 Jan 2021 23:22:26 -0800 (PST) Received: by mail-io1-xd2d.google.com with SMTP id q1so30953889ion.8 for ; Sun, 17 Jan 2021 23:22:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pK2Uk6nXhuZCzlt00zwjkdQRevtTzU05tpGbVxLJ6ao=; b=UegXOHZTJSTiww7wd2FJffN1N01VLLcsHb28vxNh93VaYKTqvn4aXVP/tWC7+8qTrd U1XlmwOAYU5bvAecgtubtW3CXsPakUhSd4mIVRGUDDe2LjkX9htpO6OFK0ZzWzuYncvp Yb0vXA03Mjxrsx9besnUObZ3XK0WqRNxPTOeA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pK2Uk6nXhuZCzlt00zwjkdQRevtTzU05tpGbVxLJ6ao=; b=j26mjOA9vYtbTL7bBGk+VsSBWE6B/0pjqHClintPACvXcJI14OCUfEHJ7zBPSfP5D2 PVsBJS1npNLAMNUvw05tfx7qst3hkOGjsmfGz1DNyA8FDoolX2QtDxBqdvwZ1QBNXbft 3rLnC33PqfzPNAQiqjPfqkUTA7UzsCplOEE2VFSy72+oSlZCTt9hkGIPeirSP6z9w7fA siPAZtyzq26QL5mjbrUjOx0bEWqebaPdsgsENZfyD4AaygP81cpOFJ4xlvCRnaoeiz1w 8AzO1NueKkzM4ynvz4u1vDV3HEic/8IWr8lp+tRcLNkB00IyMrld/73h7L1AQwm3sajc rFiA== X-Gm-Message-State: AOAM531G7qo2JCpPqZ5aZYcyHBDzdbm7adnxDcebMd//WBpPt2BCHcPh oiM5PkL4hVGAmtQzWn7hYIEq4uPwqAnO5v1iuLWz8Q== X-Google-Smtp-Source: ABdhPJy8hW+k8dY0Z11ZlJ/Da53ypr2ffvz6Xxmn232BYZcHkvYiQDtcD3m+FhNFrV+E3carWfNsr36oKvW463w+WQs= X-Received: by 2002:a02:a498:: with SMTP id d24mr18775197jam.4.1610954545480; Sun, 17 Jan 2021 23:22:25 -0800 (PST) MIME-Version: 1.0 References: <20190717222340.137578-1-saravanak@google.com> <20190717222340.137578-4-saravanak@google.com> <20191125112812.26jk5hsdwqfnofc2@vireshk-i7> <20200127061118.5bxei6nghowlmf53@vireshk-i7> <20200130042126.ahkik6ffb5vnzdim@vireshk-i7> In-Reply-To: <20200130042126.ahkik6ffb5vnzdim@vireshk-i7> From: Hsin-Yi Wang Date: Mon, 18 Jan 2021 15:21:59 +0800 Message-ID: Subject: Re: [PATCH v3 3/5] OPP: Improve require-opps linking To: Viresh Kumar Cc: Sibi Sankar , Saravana Kannan , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" , Android Kernel Team , Linux PM , lkml , "Andrew-sh.Cheng" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 30, 2020 at 12:21 PM Viresh Kumar wrote: > > On 29-01-20, 19:04, Sibi Sankar wrote: > > I don't have a gen-pd use case to test against but with the is_genpd > > check removed it works as expected when I used it against this > > series: https://patchwork.kernel.org/cover/11353185/ > > > > In the lazy_link_required_opps fn shouldn't we skip the dynamic > > opps in the the opp list? > > Tables with dynamic OPPs should not be there in pending_opp_tables > list and so that function shall never get called for them. > > > With ^^ addressed: > > Reviewed-by: Sibi Sankar > > Tested-by: Sibi Sankar > > Thanks Sibi. > > @Saravana: Can you please give your feedback as well? I don't want to > push something that may end up breaking something else :) > Hi Viresh and Saravana, Do you still have plans to push this? I've tested on mt8183 cci with: 1. [v4,0/5] Add required-opps support to devfreq passive gov (https://patchwork.kernel.org/project/linux-pm/cover/20190724014222.110767-1-saravanak@google.com/): patch 2, 4, 5 2. opp: Allow lazy-linking of required-opps (https://patchwork.kernel.org/project/linux-pm/patch/20190717222340.137578-4-saravanak@google.com/#23020727), with minor diff to let non genpd use required-opp as well: @@ -474,13 +474,6 @@ static void lazy_link_required_opp_table(struct opp_table *required_opp_table) struct device_node *required_np, *opp_np, *required_table_np; int i, ret; - /* - * We only support genpd's OPPs in the "required-opps" for now, - * as we don't know much about other cases. - */ - if (!required_opp_table->is_genpd) - return; - mutex_lock(&opp_table_lock); list_for_each_entry_safe(opp_table, temp, &pending_opp_tables, pending) { 3. PM / devfreq: Add cpu based scaling support to passive_governor and mt8183 cci, cpufreq series (https://patchwork.kernel.org/project/linux-mediatek/cover/1594348284-14199-1-git-send-email-andrew-sh.cheng@mediatek.com/) Thanks > -- > viresh