From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C078C43334 for ; Mon, 6 Jun 2022 15:26:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6EDFF112498; Mon, 6 Jun 2022 15:26:28 +0000 (UTC) Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6492D112498 for ; Mon, 6 Jun 2022 15:26:27 +0000 (UTC) Received: by mail-ej1-x62a.google.com with SMTP id u12so29663256eja.8 for ; Mon, 06 Jun 2022 08:26:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g0CfqZDZnQGiX6/HBvu3FZf3i9OJ+2C0+13cUpQYRZM=; b=fLRQ3/QA1wNcb4MXDUqS4aU+HWo7LVK33bo5FNY/J5Vg95iJWBLdAyFukFxriEzpwA jjcSJ6rwdgTWTIyuUdKJrao/n19sdCT5gry7LauyyQwURqAJr2MEeE+aJDVRB1g8mNuJ gLH9M5JMHkqEzr4X3juuMpuGvpbhqKX7daMNE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g0CfqZDZnQGiX6/HBvu3FZf3i9OJ+2C0+13cUpQYRZM=; b=dmOnqVGIKwb5CfjRFwMYlSfGSzlentbWhpZJ923R21cm7C8r/aArOXG05ams555M2g MRJ8PJhYSa2EQM1n43Qy3Cj/hFv275T10HuZjjHvUSCLLoZz2X6JGcu+b8MMmuBKQMo2 uNvaAyV+kfC59u86qGKwkb6yse8lH//AJ7dxxCQ7DHzRD9vk0i28lWn61XvAIY1XtT97 1wLbjVeP0Yi6NjNzZ3zFUE8ZhQo3vbn8Scja+Axu7AQf6pLa0hVDuQ0wk4+VwT1dKWZ7 LXsUVhyUQtb660cWQ7fBi9Wxgc3XNtguQCxZUXCcNRABRpZwWGC0OFuQ7NRgj3NMmTCd bP7Q== X-Gm-Message-State: AOAM533kzxhm/eMJPH5lrZDBxwxbyfrLsHy9EpA4qIeqPM4j89AT2koI gcXNsFbrdhZI95/SDLTE0/exKPXqrYmcJaqQh0vpSQ== X-Google-Smtp-Source: ABdhPJwoDpT6S3WSY8htZrD/zFlYO0O4+g2JDXZf4OQeXUukmweb7201Svj1Dc8HJysdoeWK939TEdsLvzykBknOAiY= X-Received: by 2002:a17:906:9b46:b0:711:1f7e:36f8 with SMTP id ep6-20020a1709069b4600b007111f7e36f8mr10222093ejc.746.1654529183491; Mon, 06 Jun 2022 08:26:23 -0700 (PDT) MIME-Version: 1.0 References: <20220606044720.945964-1-hsinyi@chromium.org> <20220606044720.945964-2-hsinyi@chromium.org> In-Reply-To: From: Hsin-Yi Wang Date: Mon, 6 Jun 2022 23:25:57 +0800 Message-ID: Subject: Re: [PATCH v3 1/8] drm/panel: Add an API drm_panel_get_orientation() to return panel orientation To: Doug Anderson Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Chun-Kuang Hu , Rob Herring , David Airlie , LKML , Stephen Boyd , Hans de Goede , Thierry Reding , "moderated list:ARM/Mediatek SoC support" , dri-devel , Thomas Zimmermann , Matthias Brugger , Sam Ravnborg , Linux ARM Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Jun 6, 2022 at 10:21 PM Doug Anderson wrote: > > Hi, > > On Sun, Jun 5, 2022 at 9:47 PM Hsin-Yi Wang wrote: > > > > Panels usually call drm_connector_set_panel_orientation(), which is > > later than drm/kms driver calling drm_dev_register(). This leads to a > > WARN(). > > > > The orientation property is known earlier. For example, some panels > > parse the property through device tree during probe. > > > > Add an API to return the property from panel to drm/kms driver, so the > > drivers are able to call drm_connector_set_panel_orientation() before > > drm_dev_register(). > > > > Suggested-by: Hans de Goede > > Signed-off-by: Hsin-Yi Wang > > Reviewed-by: Hans de Goede > > --- > > v2->v3: no change > > --- > > drivers/gpu/drm/drm_panel.c | 8 ++++++++ > > include/drm/drm_panel.h | 10 ++++++++++ > > 2 files changed, 18 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c > > index f634371c717a..4a512ca80673 100644 > > --- a/drivers/gpu/drm/drm_panel.c > > +++ b/drivers/gpu/drm/drm_panel.c > > @@ -223,6 +223,14 @@ int drm_panel_get_modes(struct drm_panel *panel, > > } > > EXPORT_SYMBOL(drm_panel_get_modes); > > > > +enum drm_panel_orientation drm_panel_get_orientation(struct drm_panel *panel) > > +{ > > + if (panel && panel->funcs && panel->funcs->get_orientation) > > + return panel->funcs->get_orientation(panel); > > + > > + return DRM_MODE_PANEL_ORIENTATION_UNKNOWN; > > +} > > +EXPORT_SYMBOL(drm_panel_get_orientation); > > #ifdef CONFIG_OF > > nit: there used to be a blank line before the #ifdef but there no > longer is after your patch. > Added in v4. > Other than that... > > Reviewed-by: Douglas Anderson From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51781C433EF for ; Mon, 6 Jun 2022 15:28:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240672AbiFFP2u (ORCPT ); Mon, 6 Jun 2022 11:28:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240757AbiFFP03 (ORCPT ); Mon, 6 Jun 2022 11:26:29 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D60EB1AADA6 for ; Mon, 6 Jun 2022 08:26:27 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id h23so18566364ejj.12 for ; Mon, 06 Jun 2022 08:26:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g0CfqZDZnQGiX6/HBvu3FZf3i9OJ+2C0+13cUpQYRZM=; b=fLRQ3/QA1wNcb4MXDUqS4aU+HWo7LVK33bo5FNY/J5Vg95iJWBLdAyFukFxriEzpwA jjcSJ6rwdgTWTIyuUdKJrao/n19sdCT5gry7LauyyQwURqAJr2MEeE+aJDVRB1g8mNuJ gLH9M5JMHkqEzr4X3juuMpuGvpbhqKX7daMNE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g0CfqZDZnQGiX6/HBvu3FZf3i9OJ+2C0+13cUpQYRZM=; b=c0Ky7JzfFkqKRSlF1Qdi6aHP8/Hg668hhSEZGl1gNGxzLhbGMJR7R7UcgoIN6cEW1E xOsQ9fzn2jb3sEkkDhjBff9xXKLVD7QJsBrBBZpauqDgpkG81OBKjg52KbfIG9b/KvtY /3MY14oZnjqr5qpnaqUIGcSA9kh+LHPKRH7MJVQgD8wV9T5DA/l7Bj1RQYbl2JhrCjS4 Vjr1thG6Hd1So7huzzVCpL6eHT/8Gtn83qGIwymGmWEqZkvoXoChJnjzf2FMS1aPBtTY +xRP06/ZcX6OeW8gIwBrc+xZtKEr7J0bT5RUWRS5235NEzjg3+AUzOqnXn+1/fwynWig jHew== X-Gm-Message-State: AOAM5338/2WiI0Nd1FVYV7c+QRRedR68wP3k6VhnDA7OCBElQ3niH8fx ciq7rpmYNau3KJWv7QWnMsPpaRQbLjQB61I08gLEUQ== X-Google-Smtp-Source: ABdhPJwoDpT6S3WSY8htZrD/zFlYO0O4+g2JDXZf4OQeXUukmweb7201Svj1Dc8HJysdoeWK939TEdsLvzykBknOAiY= X-Received: by 2002:a17:906:9b46:b0:711:1f7e:36f8 with SMTP id ep6-20020a1709069b4600b007111f7e36f8mr10222093ejc.746.1654529183491; Mon, 06 Jun 2022 08:26:23 -0700 (PDT) MIME-Version: 1.0 References: <20220606044720.945964-1-hsinyi@chromium.org> <20220606044720.945964-2-hsinyi@chromium.org> In-Reply-To: From: Hsin-Yi Wang Date: Mon, 6 Jun 2022 23:25:57 +0800 Message-ID: Subject: Re: [PATCH v3 1/8] drm/panel: Add an API drm_panel_get_orientation() to return panel orientation To: Doug Anderson Cc: Chun-Kuang Hu , Hans de Goede , Thierry Reding , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , dri-devel , "moderated list:ARM/Mediatek SoC support" , Rob Clark , Stephen Boyd , Rob Herring , Linux ARM , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 6, 2022 at 10:21 PM Doug Anderson wrote: > > Hi, > > On Sun, Jun 5, 2022 at 9:47 PM Hsin-Yi Wang wrote: > > > > Panels usually call drm_connector_set_panel_orientation(), which is > > later than drm/kms driver calling drm_dev_register(). This leads to a > > WARN(). > > > > The orientation property is known earlier. For example, some panels > > parse the property through device tree during probe. > > > > Add an API to return the property from panel to drm/kms driver, so the > > drivers are able to call drm_connector_set_panel_orientation() before > > drm_dev_register(). > > > > Suggested-by: Hans de Goede > > Signed-off-by: Hsin-Yi Wang > > Reviewed-by: Hans de Goede > > --- > > v2->v3: no change > > --- > > drivers/gpu/drm/drm_panel.c | 8 ++++++++ > > include/drm/drm_panel.h | 10 ++++++++++ > > 2 files changed, 18 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c > > index f634371c717a..4a512ca80673 100644 > > --- a/drivers/gpu/drm/drm_panel.c > > +++ b/drivers/gpu/drm/drm_panel.c > > @@ -223,6 +223,14 @@ int drm_panel_get_modes(struct drm_panel *panel, > > } > > EXPORT_SYMBOL(drm_panel_get_modes); > > > > +enum drm_panel_orientation drm_panel_get_orientation(struct drm_panel *panel) > > +{ > > + if (panel && panel->funcs && panel->funcs->get_orientation) > > + return panel->funcs->get_orientation(panel); > > + > > + return DRM_MODE_PANEL_ORIENTATION_UNKNOWN; > > +} > > +EXPORT_SYMBOL(drm_panel_get_orientation); > > #ifdef CONFIG_OF > > nit: there used to be a blank line before the #ifdef but there no > longer is after your patch. > Added in v4. > Other than that... > > Reviewed-by: Douglas Anderson From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F6A3C433EF for ; Mon, 6 Jun 2022 15:30:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cQMpSSqnV7P4eh5TsABWi5m2Rcu/4qpmQJWCeL0NuwE=; b=szCqe5A0y632/t /73jCO2yUPOLGGF73xcvxb/dfHlPiccoNqEQeohnHlVXhhP8iY3lExlpxkJ+9v3iz5SrSveiGfxaz a4iRQ14qMOiasOMXpJXWhQpSzrdc/8S/s74USD8R+qLItiNjpJ22o3u8nemCJWzqPvGu2VsDN78dJ Pagn0igYACC3S1HgJVeF9aRMD5swRGpYvrrYVICyp1D0NyazLT0Znx2cc0zZ9NMPcWFXUTgnJlckH 121Ig190kbZyONRXmCqDTvFITSP4/32jMwnj3wRvcTVaiJdsebGn1hwmAbuUbj5aEGD1N5HIWiO2q KGcxB4oiRXGO5lJxmwMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyEgW-001pLq-KW; Mon, 06 Jun 2022 15:30:28 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyEcd-001nKo-I7 for linux-mediatek@lists.infradead.org; Mon, 06 Jun 2022 15:26:29 +0000 Received: by mail-ej1-x62c.google.com with SMTP id me5so29128132ejb.2 for ; Mon, 06 Jun 2022 08:26:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g0CfqZDZnQGiX6/HBvu3FZf3i9OJ+2C0+13cUpQYRZM=; b=fLRQ3/QA1wNcb4MXDUqS4aU+HWo7LVK33bo5FNY/J5Vg95iJWBLdAyFukFxriEzpwA jjcSJ6rwdgTWTIyuUdKJrao/n19sdCT5gry7LauyyQwURqAJr2MEeE+aJDVRB1g8mNuJ gLH9M5JMHkqEzr4X3juuMpuGvpbhqKX7daMNE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g0CfqZDZnQGiX6/HBvu3FZf3i9OJ+2C0+13cUpQYRZM=; b=ilNBf4K3qGEpDpNfQgQydVZ/1toSB3g2Mo+Hia4Hno3H7LaoAjN+OFbgLMkv/38439 5kSxZJuUFHWMypXsNoX/bDTEVg11HFqLavHcMqjcmxi0NXI098T13kQLyviP9xEAQeaL QByaN0tFico5W5c4nqm4wSK6SlWB+rd4/wBIAh6JJqwARtpkUXP9G6ufnt4l7ruE1Tio 0ZUF6NX74DwEhekj4WXJsvkpl0bLw2ljpokr0jxkALHfiQkLtwE99RN9zgFpQ8MIesRT gEs6+pULao5xpJTZU2j0+G8IYvf6POlajub4S+CjJT0MGJznkTQDXE4J38H3ZLGhQ5/i RDCw== X-Gm-Message-State: AOAM532oKAd99XiyBmI1uDQYQ9Yi08w3oaoGPWyyOj1l6/2HgFJZ7ON9 shisjlZByEJ0cqAbyeXj+7kNrdW9VHOwa0yWtUJK9Q== X-Google-Smtp-Source: ABdhPJwoDpT6S3WSY8htZrD/zFlYO0O4+g2JDXZf4OQeXUukmweb7201Svj1Dc8HJysdoeWK939TEdsLvzykBknOAiY= X-Received: by 2002:a17:906:9b46:b0:711:1f7e:36f8 with SMTP id ep6-20020a1709069b4600b007111f7e36f8mr10222093ejc.746.1654529183491; Mon, 06 Jun 2022 08:26:23 -0700 (PDT) MIME-Version: 1.0 References: <20220606044720.945964-1-hsinyi@chromium.org> <20220606044720.945964-2-hsinyi@chromium.org> In-Reply-To: From: Hsin-Yi Wang Date: Mon, 6 Jun 2022 23:25:57 +0800 Message-ID: Subject: Re: [PATCH v3 1/8] drm/panel: Add an API drm_panel_get_orientation() to return panel orientation To: Doug Anderson Cc: Chun-Kuang Hu , Hans de Goede , Thierry Reding , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , dri-devel , "moderated list:ARM/Mediatek SoC support" , Rob Clark , Stephen Boyd , Rob Herring , Linux ARM , LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_082627_671833_773ED682 X-CRM114-Status: GOOD ( 23.43 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, Jun 6, 2022 at 10:21 PM Doug Anderson wrote: > > Hi, > > On Sun, Jun 5, 2022 at 9:47 PM Hsin-Yi Wang wrote: > > > > Panels usually call drm_connector_set_panel_orientation(), which is > > later than drm/kms driver calling drm_dev_register(). This leads to a > > WARN(). > > > > The orientation property is known earlier. For example, some panels > > parse the property through device tree during probe. > > > > Add an API to return the property from panel to drm/kms driver, so the > > drivers are able to call drm_connector_set_panel_orientation() before > > drm_dev_register(). > > > > Suggested-by: Hans de Goede > > Signed-off-by: Hsin-Yi Wang > > Reviewed-by: Hans de Goede > > --- > > v2->v3: no change > > --- > > drivers/gpu/drm/drm_panel.c | 8 ++++++++ > > include/drm/drm_panel.h | 10 ++++++++++ > > 2 files changed, 18 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c > > index f634371c717a..4a512ca80673 100644 > > --- a/drivers/gpu/drm/drm_panel.c > > +++ b/drivers/gpu/drm/drm_panel.c > > @@ -223,6 +223,14 @@ int drm_panel_get_modes(struct drm_panel *panel, > > } > > EXPORT_SYMBOL(drm_panel_get_modes); > > > > +enum drm_panel_orientation drm_panel_get_orientation(struct drm_panel *panel) > > +{ > > + if (panel && panel->funcs && panel->funcs->get_orientation) > > + return panel->funcs->get_orientation(panel); > > + > > + return DRM_MODE_PANEL_ORIENTATION_UNKNOWN; > > +} > > +EXPORT_SYMBOL(drm_panel_get_orientation); > > #ifdef CONFIG_OF > > nit: there used to be a blank line before the #ifdef but there no > longer is after your patch. > Added in v4. > Other than that... > > Reviewed-by: Douglas Anderson _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96AD8C433EF for ; Mon, 6 Jun 2022 15:32:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TWk7pAlwW5YYhBtD5gZOQYU19TZsLiKEkVpNp/9f8MM=; b=pAQERumfWn9cbh v29iyR9MuPC1/FTfh5zRPEpGAdYl6oUkOLoE16rXhA0SSThXeLvf1N9Z5hRuwJ7NvtwdL+a5B0zwH V0nsnTYGy08ZuTa6NuHIRq7vU09HFtHR/QDwR1/oHEvwRnJPFUbDBGh/t1aYfGMofaRz1lEKz2pJ7 xBVag5bVpOpUqNfWFSVM355REEqjNtMNTAc/ABibAXpc6Uj+tUzmeOXJP4xZ+fHtYaCtpUX5bm089 D6cakkgizDPdY8cZafHJsEk1bxkTJqzO9BKX8zqJkwr0S4ZkmU96Y9s51BkZevo7jqz9nf5Hpw/SP XyF21NBvft/Ri7H47Dpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyEgd-001pP3-S2; Mon, 06 Jun 2022 15:30:36 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyEcg-001nKl-IH for linux-arm-kernel@lists.infradead.org; Mon, 06 Jun 2022 15:26:32 +0000 Received: by mail-ej1-x62d.google.com with SMTP id q21so29680429ejm.1 for ; Mon, 06 Jun 2022 08:26:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g0CfqZDZnQGiX6/HBvu3FZf3i9OJ+2C0+13cUpQYRZM=; b=fLRQ3/QA1wNcb4MXDUqS4aU+HWo7LVK33bo5FNY/J5Vg95iJWBLdAyFukFxriEzpwA jjcSJ6rwdgTWTIyuUdKJrao/n19sdCT5gry7LauyyQwURqAJr2MEeE+aJDVRB1g8mNuJ gLH9M5JMHkqEzr4X3juuMpuGvpbhqKX7daMNE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g0CfqZDZnQGiX6/HBvu3FZf3i9OJ+2C0+13cUpQYRZM=; b=e76p7zqp1k5Yfn9+OocS1HzpqGDFqdwKBVyyPBjE+/ZxJjKSvXlAourz9d+4ho7kUf y23JhDaa2zdkU2c7Z1tzX/WDQmRUJdJqUWz8Ogiypj4A29MUKiPrRVxuWQ/05oRS9fe7 syk9B/++Sx6USvB5m0/uJtKJoLmyI8JPAEa4qOjRRAEqdeWa+NLvli94zuxxhouWBiJ6 BbFEjwD0nfjWuq10owuCdpBcgcxGhSBC8ENuL66Wby7HtqKsjj8XIjj9EdQa05O+LfNT QiwufQrldcV4ucsTreSrqEl/KZ+pUxsXmYjdwqYM8DFTy40y4AM1u6kkdZ/YPXufCF2T F0yA== X-Gm-Message-State: AOAM5320miChsnncfwKUY937jYUyd10f8cdXUpCgyD0FZX8OVm3SHTKE CIzVkM65BQQTZHnFdDCSsNuMLDlmRhX+816fTcTJSQ== X-Google-Smtp-Source: ABdhPJwoDpT6S3WSY8htZrD/zFlYO0O4+g2JDXZf4OQeXUukmweb7201Svj1Dc8HJysdoeWK939TEdsLvzykBknOAiY= X-Received: by 2002:a17:906:9b46:b0:711:1f7e:36f8 with SMTP id ep6-20020a1709069b4600b007111f7e36f8mr10222093ejc.746.1654529183491; Mon, 06 Jun 2022 08:26:23 -0700 (PDT) MIME-Version: 1.0 References: <20220606044720.945964-1-hsinyi@chromium.org> <20220606044720.945964-2-hsinyi@chromium.org> In-Reply-To: From: Hsin-Yi Wang Date: Mon, 6 Jun 2022 23:25:57 +0800 Message-ID: Subject: Re: [PATCH v3 1/8] drm/panel: Add an API drm_panel_get_orientation() to return panel orientation To: Doug Anderson Cc: Chun-Kuang Hu , Hans de Goede , Thierry Reding , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , dri-devel , "moderated list:ARM/Mediatek SoC support" , Rob Clark , Stephen Boyd , Rob Herring , Linux ARM , LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_082630_645334_2A6B84F9 X-CRM114-Status: GOOD ( 24.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 6, 2022 at 10:21 PM Doug Anderson wrote: > > Hi, > > On Sun, Jun 5, 2022 at 9:47 PM Hsin-Yi Wang wrote: > > > > Panels usually call drm_connector_set_panel_orientation(), which is > > later than drm/kms driver calling drm_dev_register(). This leads to a > > WARN(). > > > > The orientation property is known earlier. For example, some panels > > parse the property through device tree during probe. > > > > Add an API to return the property from panel to drm/kms driver, so the > > drivers are able to call drm_connector_set_panel_orientation() before > > drm_dev_register(). > > > > Suggested-by: Hans de Goede > > Signed-off-by: Hsin-Yi Wang > > Reviewed-by: Hans de Goede > > --- > > v2->v3: no change > > --- > > drivers/gpu/drm/drm_panel.c | 8 ++++++++ > > include/drm/drm_panel.h | 10 ++++++++++ > > 2 files changed, 18 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c > > index f634371c717a..4a512ca80673 100644 > > --- a/drivers/gpu/drm/drm_panel.c > > +++ b/drivers/gpu/drm/drm_panel.c > > @@ -223,6 +223,14 @@ int drm_panel_get_modes(struct drm_panel *panel, > > } > > EXPORT_SYMBOL(drm_panel_get_modes); > > > > +enum drm_panel_orientation drm_panel_get_orientation(struct drm_panel *panel) > > +{ > > + if (panel && panel->funcs && panel->funcs->get_orientation) > > + return panel->funcs->get_orientation(panel); > > + > > + return DRM_MODE_PANEL_ORIENTATION_UNKNOWN; > > +} > > +EXPORT_SYMBOL(drm_panel_get_orientation); > > #ifdef CONFIG_OF > > nit: there used to be a blank line before the #ifdef but there no > longer is after your patch. > Added in v4. > Other than that... > > Reviewed-by: Douglas Anderson _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel